From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EB99C54EBC for ; Tue, 10 Jan 2023 11:32:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CAF608E0002; Tue, 10 Jan 2023 06:32:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C387E8E0001; Tue, 10 Jan 2023 06:32:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AB21A8E0002; Tue, 10 Jan 2023 06:32:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 96DDA8E0001 for ; Tue, 10 Jan 2023 06:32:09 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 61B80120865 for ; Tue, 10 Jan 2023 11:32:09 +0000 (UTC) X-FDA: 80338675578.04.D4406F4 Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) by imf14.hostedemail.com (Postfix) with ESMTP id AB877100010 for ; Tue, 10 Jan 2023 11:32:06 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=Tq1Vlylb; spf=pass (imf14.hostedemail.com: domain of ilias.apalodimas@linaro.org designates 209.85.218.46 as permitted sender) smtp.mailfrom=ilias.apalodimas@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673350326; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5qiv/JLLYkHcqOBIKvuqBd6ea5glLyyaQWfxWXjA4/w=; b=RSQsrPssD0FM4ZYWSCGP8OC8+lW0UcMe2DtuDZiU5yx1mD6BG9MoZdSwzcTbtuAeS7NeDN Swb21WuGrmOJXF8NmBlnnAYOPYT9PAAjNjaQvtf8v7Zh1VPHitSb9KoqvA1+vUIz1/N1DK JhTqRoYHynwfPcT9DV0Mu0wJlxr6Vns= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=Tq1Vlylb; spf=pass (imf14.hostedemail.com: domain of ilias.apalodimas@linaro.org designates 209.85.218.46 as permitted sender) smtp.mailfrom=ilias.apalodimas@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673350326; a=rsa-sha256; cv=none; b=zECgE+xGUva1gLzAcLtrKgnuepr2NOeDgQ5vnbv7pqNvh6OJ67lu1YqaGbXtN6IqupX/V3 Cjv4hxoP29k/3BNeeHw92Aq33xdApStXqbSakotDCJvJDSf7+1v8bHYpI8G63XwXFLjsiI fBuBQdpIki+GeZJY+qsx3Yizm2UPzfA= Received: by mail-ej1-f46.google.com with SMTP id fy8so27694389ejc.13 for ; Tue, 10 Jan 2023 03:32:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=5qiv/JLLYkHcqOBIKvuqBd6ea5glLyyaQWfxWXjA4/w=; b=Tq1VlylbbFTlgjSkX8Q+9jPefU/4Rh2+PThmpSY8g+9Y2LqKNxBboJiVi+Y+gqtfH7 xgfzjEcHhDKIVx2GP1MtjYvk8tG64DYXdxye5W5bOu0TZM6UB0vPsjNpe0TuEPaM3KbV fTJbZvzCCUzqYxgtXj8dkQrOVHwbdjabmLwBqp6T+l9uIV1WIi+VQbcnAsi/mOWyOxoi UqculsqF6Ydk6EhdyL0BktXzxRc9okjg4lxZno5mTMQ508paQyYVOsma+o9zxRZV0UA6 W4TT1Qp5AahAyQ5IzPDsktaKPCBO539f4KDj0ly64pHjEE+OwF1da6gSxRKS2gQ48Jzc x5eQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5qiv/JLLYkHcqOBIKvuqBd6ea5glLyyaQWfxWXjA4/w=; b=rV6lpPeCwypsZuD2IbpRUU9cwdCyWWtCgBA0AuB0BtcTSt7Hw9n92Mms665ZuV5OeP 2bFnbBG9dzahO7X2uP+QFHBM1KqnObqnsUDECQBTeeZQ2dH52hL+N6jzdeW3OmvWEsQl wLjNKj9p0D5hD5glZCLTrtmZUUZeP+wmZctWuJrneHKEDASYodcCpF2OHIiTywhWwZZ2 NKiiI99unlRciZbZNYvNFmwBO78lYjhlYF4TcTEve3FwIPcgRRI8ESgPE4heZBlaT/E0 kI0GWnlpYjf3iupLTgNFfENj4/XJRZTOQmrLJ31TdgY/owDFJ1SDXpp9WzRevRcNagjr mjfw== X-Gm-Message-State: AFqh2kqZXyIejivmUeQqc0myXPCS3G17PqziXZSl4cApPyYHW6x/C7qK GcisUislLGo5vq9NwccpgFjYdw== X-Google-Smtp-Source: AMrXdXufLSAPWJ64Vd/dBx3BWFnbyUq0u55ryQha6rwXXJXzzc1rFO5rFVi3UvNsV+PAYQkPbpBZzQ== X-Received: by 2002:a17:907:c516:b0:7c1:e78:11ed with SMTP id tq22-20020a170907c51600b007c10e7811edmr61904228ejc.0.1673350325323; Tue, 10 Jan 2023 03:32:05 -0800 (PST) Received: from hera (ppp079167090036.access.hol.gr. [79.167.90.36]) by smtp.gmail.com with ESMTPSA id ov38-20020a170906fc2600b0084d4733c428sm2382496ejb.88.2023.01.10.03.32.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jan 2023 03:32:04 -0800 (PST) Date: Tue, 10 Jan 2023 13:32:02 +0200 From: Ilias Apalodimas To: "Matthew Wilcox (Oracle)" Cc: Jesper Dangaard Brouer , netdev@vger.kernel.org, linux-mm@kvack.org, Shakeel Butt Subject: Re: [PATCH v2 21/24] page_pool: Pass a netmem to init_callback() Message-ID: References: <20230105214631.3939268-1-willy@infradead.org> <20230105214631.3939268-22-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230105214631.3939268-22-willy@infradead.org> X-Stat-Signature: hbxs37km58y5bbuasc9nemrh7t6jmsmg X-Rspam-User: X-Rspamd-Queue-Id: AB877100010 X-Rspamd-Server: rspam06 X-HE-Tag: 1673350326-11826 X-HE-Meta: U2FsdGVkX1/wp+nColiYYERmH1AuDTspIBWc7da7hLG2icD1N3Q8KoclWyyypfNbSBP6dJivCZee1FVhcDGBPvFGVmXxDQwYP55NaYxxTSMj0pqTLEhQ35JuRRvYJv6Ge68jtjCJ6FGNxRbfsFwH9id8f+GW9SXFrFzJo8Ff5RTrhW4zmKR02riKHPXgxq5f1B8kHyDXVTrlSbwmwL20p2w0brSLgRTc3Q2PUKU0U/IFu+98+XiZXuX+BaCc54CA0PMHojB1qpyriOItnzMi7DTOOgaB0WEDIXny/1CgOvQGmDLC4pyX2mFx2eMeVy2Q/KMh0mFtKJUCFuEzgBVdmwp/Fh5H8xCk04FBP2KrpCdZwLd8HfzvR98Wh2mfz0L26aMoEaZ+vf1hyInBuECQmLxBa7HGPPKwX8lv0Auf+Vd+y2xqCd0zxzEYKQHkEhlmIgzKBpNU7awd1q0x9LsstUtuDwSVZypM97lCk5UTY/4z/KbMltiMvRLrbK01FJTElfIKhZaKRhXUlzlF7mbtj63El/lTCV6L9bSo/N/HKJr2zuRWBSEJmTyMYKOcypuVsQMdVYEHZPsF3aLY2Frr4kxbngpFX/RGrgZ11GSRQxGKjIWVoSbr7GOkrs+jswF5vA1fjGu18dMpNcpnv9BitV91zpszZ+TLbwT30W3o5LT4xOys5ZJK5JK89jtuPF7kgpRBefG0votmYlV02dHxoMjA7A4joS3rje7Rzy8iR0tZ919WCbTrx3wntyNbH8/+V7u8z4XZ1tlTvxOJmQNolqFUUIwTCshZGQpoC4QPmM+fwBuKSztQdnvdxbfDX8G3jIeo0cw7RwwLoKwYYLGoGyrP0R9LqlGt1HFcmOlI8xb8XhDTOGCVOBMliX4c9VXHxruX3PFHefZQgabQVU1IJAsiNsgbSPBHQkTRkItL7caOuoHK89CMpfQ5GDewQ9caguYFJL5eULA6hu4CjjB dAPLtxKC UmJ1m9Uiev8u33DOqxc7mW2wFWjnF40CmoL9doF95uS3SxUd82b6tnXUc1t+V6Xso+dMuWDZZrq34heJJpU3U71gTem157ttiJUCzAAw908h6XAclChEw4kH+KJVGgOrDUfqT X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 05, 2023 at 09:46:28PM +0000, Matthew Wilcox (Oracle) wrote: > Convert the only user of init_callback. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > include/net/page_pool.h | 2 +- > net/bpf/test_run.c | 4 ++-- > net/core/page_pool.c | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/include/net/page_pool.h b/include/net/page_pool.h > index c607d67c96dc..d2f98b9dce13 100644 > --- a/include/net/page_pool.h > +++ b/include/net/page_pool.h > @@ -181,7 +181,7 @@ struct page_pool_params { > enum dma_data_direction dma_dir; /* DMA mapping direction */ > unsigned int max_len; /* max DMA sync memory size */ > unsigned int offset; /* DMA addr offset */ > - void (*init_callback)(struct page *page, void *arg); > + void (*init_callback)(struct netmem *nmem, void *arg); > void *init_arg; > }; > > diff --git a/net/bpf/test_run.c b/net/bpf/test_run.c > index 2723623429ac..bd3c64e69f6e 100644 > --- a/net/bpf/test_run.c > +++ b/net/bpf/test_run.c > @@ -116,9 +116,9 @@ struct xdp_test_data { > #define TEST_XDP_FRAME_SIZE (PAGE_SIZE - sizeof(struct xdp_page_head)) > #define TEST_XDP_MAX_BATCH 256 > > -static void xdp_test_run_init_page(struct page *page, void *arg) > +static void xdp_test_run_init_page(struct netmem *nmem, void *arg) > { > - struct xdp_page_head *head = phys_to_virt(page_to_phys(page)); > + struct xdp_page_head *head = netmem_to_virt(nmem); > struct xdp_buff *new_ctx, *orig_ctx; > u32 headroom = XDP_PACKET_HEADROOM; > struct xdp_test_data *xdp = arg; > diff --git a/net/core/page_pool.c b/net/core/page_pool.c > index 5624cdae1f4e..a1e404a7397f 100644 > --- a/net/core/page_pool.c > +++ b/net/core/page_pool.c > @@ -334,7 +334,7 @@ static void page_pool_set_pp_info(struct page_pool *pool, > nmem->pp = pool; > nmem->pp_magic |= PP_SIGNATURE; > if (pool->p.init_callback) > - pool->p.init_callback(netmem_page(nmem), pool->p.init_arg); > + pool->p.init_callback(nmem, pool->p.init_arg); > } > > static void page_pool_clear_pp_info(struct netmem *nmem) > -- > 2.35.1 > Reviewed-by: Ilias Apalodimas