From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B89BC46467 for ; Tue, 10 Jan 2023 11:00:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A54898E0005; Tue, 10 Jan 2023 06:00:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A04BD8E0001; Tue, 10 Jan 2023 06:00:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8CCE68E0005; Tue, 10 Jan 2023 06:00:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 801598E0001 for ; Tue, 10 Jan 2023 06:00:43 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 391E4C0607 for ; Tue, 10 Jan 2023 11:00:43 +0000 (UTC) X-FDA: 80338596366.14.1DC1D51 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) by imf28.hostedemail.com (Postfix) with ESMTP id 39DEDC001D for ; Tue, 10 Jan 2023 11:00:40 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=pabF5yDJ; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf28.hostedemail.com: domain of ilias.apalodimas@linaro.org designates 209.85.218.41 as permitted sender) smtp.mailfrom=ilias.apalodimas@linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673348441; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Y+o6cKqup0PQOc0VCM2FQDv0bt++VUD6yKUaB+WSLkU=; b=d77WK/3XP5Mjb4zsY1FMVLsaxzhW+mM/bxRlC0f5F+dnjiwWrLsInaBFD/6JgvJRLTKR+n 2A6fVzcnsuz74k7jsybFGR6DU81iu0n81SsRrODpA5yqofOe42Twlopgz8H4pdmaHWAind TUF8mzjDNLBdhQWhdLHplUY//sAIy8k= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=pabF5yDJ; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf28.hostedemail.com: domain of ilias.apalodimas@linaro.org designates 209.85.218.41 as permitted sender) smtp.mailfrom=ilias.apalodimas@linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673348441; a=rsa-sha256; cv=none; b=vEalI+YaO2lyTxUxBeGK5ZBPnjjFXns0+nAyAY8DPa/1/JTRFRobzoxERYCI0rOoAGHGQU Kc5/dmjpxNdQuZLEGWwEQTFxNAbft0EiaFYxRSdMjNOgs5+TiXwmQbU1KJ4STne2hmEltz pAlhdqOriif7lZbR/p2+pS+yTJWf7Sg= Received: by mail-ej1-f41.google.com with SMTP id ud5so27601412ejc.4 for ; Tue, 10 Jan 2023 03:00:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Y+o6cKqup0PQOc0VCM2FQDv0bt++VUD6yKUaB+WSLkU=; b=pabF5yDJIDeD61JCtwpPySIatdGRhYfV0wh3xs7Hb9yW+fCRABMyw1Bx9FoWNb3A2r xY4u526fCnyLS+YWlxlOX044yLjWwAJQiVzT4A8wbRPAEHIR5ioEW1P0q7GcBhzJphNI 9Pn2W6ReIRRKhv7JdGdTHGP10R8FsHcn5IFCxgHLaPPRcy0eIy+bqPWzd44Afy58LRW1 TkrPUEBqFeNrgop6+uv/7mW2iJGozgKOdCf9GTZt3c71PsQ2SufJ25RMPhd5TJKSK6SO 1ur3cWtL55lNWNdbL1B3QIkh6osBVmNbidmQh4/F6bfhd/Mk5I6ImQtIaU5aTMjawbGo F51A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Y+o6cKqup0PQOc0VCM2FQDv0bt++VUD6yKUaB+WSLkU=; b=wSv0IfrtYYcaKAYwJ9x3DZ4ain1SmfUNaKHLfILt9jXKbAcQvHNOv7WacRzh66SRLC 1TBB6XzIVtqRa54JlV4JVg7lMW3n1WIQV3nEfumRmcvIXOaEVl8B5uCF20A5nP9cw3iq OBEuGDz4nTRyzA2sjkKMgMF+/MDpD6j3KeTz53+zTyE6FUmHSnFcaDUEmdSB0Hvh1wBq tOzN/33y4SdGfQgNqbew0Jiq/B8zqBjEF1hvZh+ZGfJwtd1Z1JcF2yV5rrtdqCGJ9TEt KxHHU86yNUxdQbzSIRYrMQKCJ/2mtFivQMB9JYcZlLaH+3F9G6TWYpfgNexc3UiVp4Sl pVuQ== X-Gm-Message-State: AFqh2kpeZe+JYXha9L53WasgXD07+AdRmKord1Vcp07UNUOXcAXloCD9 6HpzpAr4EKu3AcxErH793t4HbicGHODYHgjn X-Google-Smtp-Source: AMrXdXu6/5NMFl5vbMqhgKJcSDWZg9ZOkBoBm4WVrFAzx3TfW/phaAzwT4OHhCymDBPDDJU2YxgwwQ== X-Received: by 2002:a17:906:9d04:b0:84d:3822:2fc7 with SMTP id fn4-20020a1709069d0400b0084d38222fc7mr8539058ejc.77.1673348439719; Tue, 10 Jan 2023 03:00:39 -0800 (PST) Received: from hera (ppp079167090036.access.hol.gr. [79.167.90.36]) by smtp.gmail.com with ESMTPSA id ec20-20020a170906b6d400b007c0f5d6f754sm4849116ejb.79.2023.01.10.03.00.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jan 2023 03:00:39 -0800 (PST) Date: Tue, 10 Jan 2023 13:00:37 +0200 From: Ilias Apalodimas To: "Matthew Wilcox (Oracle)" Cc: Jesper Dangaard Brouer , netdev@vger.kernel.org, linux-mm@kvack.org, Shakeel Butt Subject: Re: [PATCH v2 16/24] page_pool: Use netmem in page_pool_drain_frag() Message-ID: References: <20230105214631.3939268-1-willy@infradead.org> <20230105214631.3939268-17-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230105214631.3939268-17-willy@infradead.org> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 39DEDC001D X-Stat-Signature: in9yb5ct4qwrrmuox4rjbfepbmkw3die X-HE-Tag: 1673348440-632368 X-HE-Meta: U2FsdGVkX1+kC1Jg6GMlPcLBOX9IzT4x+uLp7fuA5AAfdT0s9sJ4R36CCgXUBXRwDaoKal8onD7U4R8WXGlzCDlzHCkxAghCxcHMeQPMKJZo2LySeIF8b8YuwrH52RifYB/14nftaKv26Aij84M5jRzbemZUEUZ6DdvAQIyJ3+s9GPi94w2SSDHq+WD6CcGz6qw8Czi5EgG9KiRVP6A0IS9H5V1iUWHCZ+jAD5ODnR3T78zeukSC0WXFjg3XXEsKsrxzV8qcGIAiDXRFSrxQIlmdrMdB7hQr3LL59jybC3+xbCuSrFQLZc5jlZqJE9/CF92ITHxdzFiOW3qTCdPnvLRVnMu5gs74O+38k/L85MUsaVwIOyav7GzdlHODsA91GXIk8kX0FODV/vf1MBHgoHvD6AsjJEyaVYxqOAQ/VdTPWoXPO16K4lUiStIhbT+1lp0xJ1Yg2ZdB1/O7MvVmKuGB7hoB3wXTsoqGzl8USLQ4PYNUd0faFI9Sl5CT9fWr19sIEaaVMN5FQrvvD3X5AXbiXqYdvgx0uaHBihuAWdjgmbuHxn0cxgIG5IYQCG4e/a236ds7ceYfqZEBEW/aNHGLl0X9h43/w1FWIDSnojlhdkt7r67EdvjTcAaUY80JyUkFUFkX2iQhQO3ZraOyVp7TqvWwtyGrVyUqW+RVtNmI0pbYqSjVJUnHHTi2rIqM2nt6OBqI67Zmtl/VcFQFxQx9w82usYqM7wRFJlZxeRxdIu4wVeBNBB4QWjWFzFs02J5tVANLMecqej1dPykZMUy460ljfKaBtUcK6WFZlRY8N55HazMV8ex6pwSsWgMayRofmCfgtBNz6QJEC9VYPmW87W6h3wQ/BIgzcSITMCvpn6SS5Rrr1untUYUQuCTcqMmIcTjfpaOxKbs5ykkPCcnqBydIZhuHKBTLypa3MuGnfapwRYBb8uBCvqli8uQcTkBRoxc3UDOniIR8a9z DjpRVDuL se04JT3em/n3Hl+YSgYCWdnYcLEtQaqMYm1DtPn4OOemGd32yFRtPTYp90Q1MRpEiEbPN6RXDXtVmRVWo/qMcPWmY/AwoSVMdqCilzPXPAsI/ZlPzuLyzdiUBIpPPDQr91zL0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 05, 2023 at 09:46:23PM +0000, Matthew Wilcox (Oracle) wrote: > We're not quite ready to change the API of page_pool_drain_frag(), > but we can remove the use of several wrappers by using the netmem > throughout. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > net/core/page_pool.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/net/core/page_pool.c b/net/core/page_pool.c > index c495e3a16e83..cd469a9970e7 100644 > --- a/net/core/page_pool.c > +++ b/net/core/page_pool.c > @@ -672,17 +672,17 @@ static struct page *page_pool_drain_frag(struct page_pool *pool, > long drain_count = BIAS_MAX - pool->frag_users; > > /* Some user is still using the page frag */ > - if (likely(page_pool_defrag_page(page, drain_count))) > + if (likely(page_pool_defrag_netmem(nmem, drain_count))) > return NULL; > > - if (page_ref_count(page) == 1 && !page_is_pfmemalloc(page)) { > + if (netmem_ref_count(nmem) == 1 && !netmem_is_pfmemalloc(nmem)) { > if (pool->p.flags & PP_FLAG_DMA_SYNC_DEV) > page_pool_dma_sync_for_device(pool, nmem, -1); > > return page; > } > > - page_pool_return_page(pool, page); > + page_pool_return_netmem(pool, nmem); > return NULL; > } > > -- > 2.35.1 > Reviewed-by: Ilias Apalodimas