From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C65CC46467 for ; Tue, 10 Jan 2023 10:48:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A0F288E0003; Tue, 10 Jan 2023 05:48:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9985A8E0001; Tue, 10 Jan 2023 05:48:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 839988E0003; Tue, 10 Jan 2023 05:48:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 751B18E0001 for ; Tue, 10 Jan 2023 05:48:20 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 48230AE794 for ; Tue, 10 Jan 2023 10:48:20 +0000 (UTC) X-FDA: 80338565160.15.F18C97F Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) by imf07.hostedemail.com (Postfix) with ESMTP id 8BCEA40013 for ; Tue, 10 Jan 2023 10:48:18 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=v0S35m+M; spf=pass (imf07.hostedemail.com: domain of ilias.apalodimas@linaro.org designates 209.85.208.41 as permitted sender) smtp.mailfrom=ilias.apalodimas@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673347698; a=rsa-sha256; cv=none; b=RG9bE9FxBRRavT+vvGuWacvb+dRXq2s2hzjI6PF6YYKPjSYw1t2uu50FRxWQmZeBLrPi/M 6A1MfzmWmzdAC9PT8eAyAX+pvPlSm2hhRASDb6AczTz5BtUQL8P6hLbOHSiSC50ezyB/+u HZ5FgOy+wJlxgnoqzj4uM8FWeScESh8= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=v0S35m+M; spf=pass (imf07.hostedemail.com: domain of ilias.apalodimas@linaro.org designates 209.85.208.41 as permitted sender) smtp.mailfrom=ilias.apalodimas@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673347698; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Sg0mN3VXt1Ze93ywGfUQr/46Le7Fdm7QZEKQLC5rtNw=; b=suvsgJ5zvEisIwdLQglt03OLfWxsHchTiZRKsz1jVbAaHgRVddteQ+Prrlws40DgH3Gmtp enZx6DjJi0Rv6+Psi2/gpixtyNxI2+LGJ1kHloJdhlRdmu+QBj2puLa9hFOXpB2tixx/Lw SG0yqVks1p3jLqz/Po3fBxLDi2j4iCs= Received: by mail-ed1-f41.google.com with SMTP id z11so16946737ede.1 for ; Tue, 10 Jan 2023 02:48:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Sg0mN3VXt1Ze93ywGfUQr/46Le7Fdm7QZEKQLC5rtNw=; b=v0S35m+Mr6jfxJJe/Qv5iNviBJ0gjvOiJW9UyQcqU8LpY4H5grXHxZSwMsEJMwu/Rt k67DIW87q+KcgVUmaVV3vCVZGuWMgZQjHHxkxOVjw+tlNaJxVdMiiKU9UHDcieldM0H7 9IaxltZVA1/3NE3o8qedk+LJEfHfPw6BfwYhQ8KZLQU/vxnUtWaN1I904IMm6wpwGj0t 8l7y0d8mU/vDf/nT0Z2DXc9GxgGTT/2pSqEwE72MXM4MBSiGSBmFwYd26KQ2U1h9Zq9D pOCUwFX9aMIsXvmap3nCPxmkFXmHb+uAB7CMoKQeizchFlUgq52b0rKoIY/oeho23MF3 4+Cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Sg0mN3VXt1Ze93ywGfUQr/46Le7Fdm7QZEKQLC5rtNw=; b=sWqz9PCtZRpJAMF53/OlfDQW+kJ95mryxnUE9KW6G8ECg5mz9J8tdcEhxkbQHbMEQZ LNoVhgQDAuTticH+0JmVm0trAtQMvy5TPjuTTPYiUBue+WuZ/9yrvEwX+lZCcDC0gDYD LYjoSdWGASYJUsE8xzUbV+O9LgsXiXdvKCJwszxmVtx/rxeva2eTaFjRF21dm33UHyFY UaSEbHJ85AcEfavbO0WMTX+mwuxTOg3EtMYCm0BMHx3APnrB+YCohEkPKa4X3skVuqS2 nUjWTlHIAKA43XnhWNIZJlr68mZtRsjEfy7GTgX/IEKquYrwVkTFuBVyQiE9QcdhyT0V /2sA== X-Gm-Message-State: AFqh2koVjAYEJ/QkDB8QPl2tTH8yt0gtG+K+VmQAnKCZT6DkSt2RlYeo yxuRVQ+z+tnCjPu/SwaW7pbczA== X-Google-Smtp-Source: AMrXdXu+KEnTwAOFwasWztSKGFhBkBkQMuXHSDfCMsEvvXjqwJyxYaF+4/2ydcAelNuB66nKT76BOA== X-Received: by 2002:a05:6402:685:b0:479:ab7d:1dad with SMTP id f5-20020a056402068500b00479ab7d1dadmr73490557edy.32.1673347697235; Tue, 10 Jan 2023 02:48:17 -0800 (PST) Received: from hera (ppp079167090036.access.hol.gr. [79.167.90.36]) by smtp.gmail.com with ESMTPSA id x14-20020a056402414e00b0045b4b67156fsm4750650eda.45.2023.01.10.02.48.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jan 2023 02:48:16 -0800 (PST) Date: Tue, 10 Jan 2023 12:48:14 +0200 From: Ilias Apalodimas To: "Matthew Wilcox (Oracle)" Cc: Jesper Dangaard Brouer , netdev@vger.kernel.org, linux-mm@kvack.org, Shakeel Butt Subject: Re: [PATCH v2 14/24] page_pool: Convert page_pool_recycle_in_cache() to netmem Message-ID: References: <20230105214631.3939268-1-willy@infradead.org> <20230105214631.3939268-15-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230105214631.3939268-15-willy@infradead.org> X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 8BCEA40013 X-Stat-Signature: 9bfx8ncec1qi6ufi35tpgt7zrgzszani X-HE-Tag: 1673347698-316140 X-HE-Meta: U2FsdGVkX1+7H1DnkujDO9VXmGdliU7JSyXToAufnEJsgmNyed/X/QQFcTDrwVZ1/mAfrLNQpGxd2OdECcBUUJQbBhKEoLwscRdaB9+UT2OEv83exztyw71ZzotuUQ7NJ+9bA8cuqf79hTHkRxybUYrHbWcxq6K6FB/0Ry7Y8yabbr2julQFqKnjYrottoPIxBcS1bMve4Y8WbxlDLNiRrWmiik7AZXvWY099VrVT9urhm+y5K6o2RQKVISUQnRnXeiZgg5yNXfPPnGY+1YwPd8WgGBGyVYeVzqD3UufHO4uFQvR8tJI2uVnfT6nDAl3mMf59XimekSvNNw2kHdM2B7Qq5I6tBkWuMQ7wAtGm2/9O7YMlxCfG0SfOQLH0WT2Fj3i6z5pQr+xhAjHhhBPdjyxBcOaRZTBuwMTNHjh0tPmJAGgv9+i9fsP4IgnqMO1kDSugTGzF2Lay+JwVD95XVQDKi4ixAOU90GFro2VOEmMsw1e1IYUCv6YOuJVRppnH7b0BRIVL+5MhtBcIo/tGH3Ska2yiBDAppxEwA09tL8ni5Ohu+Tp17yYyxSwi0PCNOyyy2wQDgDtxPrbyJKo5veZgaJIUiA1ARdGtK3dFFgAc6+dGnjo8Vd0jzVd5tE+58dHiXVFe2tl2sW5Hi/m+kjKwuVYzeUroILU9OQ6PZ6toFSTX4pYbcS5zhtPXaCOpav8Wg9Sq2tPl0vKulGz+JRjL26YAquwQmD6WQ8PARAdBJIpUM8RUWftWhJO8BA/vPJF5Hy5/t1Csve6jjt8VwxppTDMNoo4JNC9erBoRT8S1TnGJsW++0gd59J7pQBMf/lltLE42aNqGsUHTqGrtB67IZDHZi5N9JSwFWqac8HUjU/OqnrjCflJGebMkD/3lb9cgBoF2/04Dilmcn8YnT2JADHl1mnfBTEdXCX6yi3xj4ltTLeL8Jejb4YCz/AOpGo0skwJDI0JHjPjl6E ETz4QPB+ n+VYCRhxHIugCvn+qCU1Uuex4qFQop7ZMhC6BK26QiYaamt68YbS31SML+OjEpVhkbeWSNtq5nUX5HXS4OeaWcN1ZWY2QGJB7Notr//6hUqDIljcYYmPbdFlAyOTUfcZcKljp X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 05, 2023 at 09:46:21PM +0000, Matthew Wilcox (Oracle) wrote: > Removes a few casts. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > net/core/page_pool.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/net/core/page_pool.c b/net/core/page_pool.c > index 3fa03baa80ee..b925a4dcb09b 100644 > --- a/net/core/page_pool.c > +++ b/net/core/page_pool.c > @@ -538,7 +538,7 @@ static bool page_pool_recycle_in_ring(struct page_pool *pool, > * > * Caller must provide appropriate safe context. > */ > -static bool page_pool_recycle_in_cache(struct page *page, > +static bool page_pool_recycle_in_cache(struct netmem *nmem, > struct page_pool *pool) > { > if (unlikely(pool->alloc.count == PP_ALLOC_CACHE_SIZE)) { > @@ -547,7 +547,7 @@ static bool page_pool_recycle_in_cache(struct page *page, > } > > /* Caller MUST have verified/know (page_ref_count(page) == 1) */ > - pool->alloc.cache[pool->alloc.count++] = page_netmem(page); > + pool->alloc.cache[pool->alloc.count++] = nmem; > recycle_stat_inc(pool, cached); > return true; > } > @@ -580,7 +580,7 @@ __page_pool_put_netmem(struct page_pool *pool, struct netmem *nmem, > dma_sync_size); > > if (allow_direct && in_serving_softirq() && > - page_pool_recycle_in_cache(netmem_page(nmem), pool)) > + page_pool_recycle_in_cache(nmem, pool)) > return NULL; > > /* Page found as candidate for recycling */ > -- > 2.35.1 > Reviewed-by: Ilias Apalodimas