From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E678CC54EBE for ; Tue, 10 Jan 2023 09:40:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 674528E0002; Tue, 10 Jan 2023 04:40:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5FC0E8E0001; Tue, 10 Jan 2023 04:40:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4EAF88E0002; Tue, 10 Jan 2023 04:40:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 3AEE28E0001 for ; Tue, 10 Jan 2023 04:40:00 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 0D06F160D7C for ; Tue, 10 Jan 2023 09:40:00 +0000 (UTC) X-FDA: 80338392960.26.0F0F662 Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) by imf13.hostedemail.com (Postfix) with ESMTP id 5B5AE20009 for ; Tue, 10 Jan 2023 09:39:58 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=F4bdMogB; spf=pass (imf13.hostedemail.com: domain of ilias.apalodimas@linaro.org designates 209.85.208.49 as permitted sender) smtp.mailfrom=ilias.apalodimas@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673343598; a=rsa-sha256; cv=none; b=ML98zmkprxURN2fUpwEBpCBMVix8UMTdBncQzfrcmwBTLD4/QMtL53imDpoBRw7IobW7WA /lrLlyyzWU2K1he7YP/tyC2J9xj+/tVFOzsQpzyPewmHFMcQ3ydIDte+M2SIyelSfCU3xY lbn6ik/OLGPzwaBz5KRy1d9MHuVrVOw= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=F4bdMogB; spf=pass (imf13.hostedemail.com: domain of ilias.apalodimas@linaro.org designates 209.85.208.49 as permitted sender) smtp.mailfrom=ilias.apalodimas@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673343598; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=05rLE9bIAJu7vOSCUFT1+ZmOdeM8fWt9niDLqe6WzVs=; b=evNF0jIwcESOD0pmxAZeWfo1cDvqFVTrH9VZ44GxLvjdzwcFfWOzsniZOouM0qxDfrAVro cQ/hLj0lko9u+uAmZZYETARmR+6GLYUjy8KY5/m+58QE2OuzHS5GMkPZZKpk2PBX1/0csy e3eyd4S2WdA+WNBBAre7hawGyK8b09k= Received: by mail-ed1-f49.google.com with SMTP id i15so16663418edf.2 for ; Tue, 10 Jan 2023 01:39:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=05rLE9bIAJu7vOSCUFT1+ZmOdeM8fWt9niDLqe6WzVs=; b=F4bdMogB+1TKhJNRHbOeR3AtyP6wqjT2gyaWA1yZoGvkCLLkh7U3QGFG4n+89rKzrl +qhUAC/0ssj5H4btBJl+xMYONvQceky8vofD+GoDl3Y5EbFAHteebtU2sOe1oi40RrzB 5UPWxmch/gQyfITXFBUf/IBU1ORqGYeFUt+/rQcPpYQ6k4DPqPM16Mwi13Rs7ZsvtIxK pNo8Rj2mnDKj2S/VM7ixA9yZKZyQCWW199epGDXxXnktwiDMKmE9XUHJ7u5G1HO7p+w5 I9X5KcGdCG0TBJJsewf02GMDOnmPmKeKpRBDBGVMOwMxHCfJRnV770WsQPshKBEb3zJr IZ1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=05rLE9bIAJu7vOSCUFT1+ZmOdeM8fWt9niDLqe6WzVs=; b=6NsoW++1s4pj/+Ea+oiCL6GkpqrQ9g9cLy1Yb0F2KbqKHlf2dW4P/ZIHZfq1I1ZJab WygTyuiZEOs3VTVYnns41dYvMTi9Sr+8Dg3bx3w1BGAGWb1CCKWdDykJ0Ac4UeSCKoEg 3nbJD9NNH2EhtEqf9DM5S+ee3hkWOSEdqTiuLwuMQXajgHwg89GBPm6ADTgOq0DIwz1j eWzY6jolfIC11OHHB0H/pnzfqkko5wLcvIP66Be0Oo9BlrV2fMxjMN9zdApM+fzywAnH G8Lg84ZzVD+WmftPzVFbNXIfMXrOWpK1DfAjJwu+UsyXTspLUooaPT3pYJB/ptPUo7d/ 4A7g== X-Gm-Message-State: AFqh2kpY2FEG2oV7py+qxSLn2keEM+mV8e+5rEW7LQMLytdTmXBvMrY/ R1XzqKqazvWff6pJjHdMGSagzA== X-Google-Smtp-Source: AMrXdXvp8XNK/R9fQ7FPvDNdxg8A8r9blnlBuQZc6FtzMC0nmBdnT3//IV5yF+rW24grRQII7txYJg== X-Received: by 2002:a05:6402:f17:b0:489:5852:fbb5 with SMTP id i23-20020a0564020f1700b004895852fbb5mr40063159eda.16.1673343597089; Tue, 10 Jan 2023 01:39:57 -0800 (PST) Received: from hera (ppp079167090036.access.hol.gr. [79.167.90.36]) by smtp.gmail.com with ESMTPSA id q24-20020a056402249800b0046ac460da13sm4726222eda.53.2023.01.10.01.39.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jan 2023 01:39:56 -0800 (PST) Date: Tue, 10 Jan 2023 11:39:54 +0200 From: Ilias Apalodimas To: "Matthew Wilcox (Oracle)" Cc: Jesper Dangaard Brouer , netdev@vger.kernel.org, linux-mm@kvack.org, Shakeel Butt Subject: Re: [PATCH v2 06/24] page_pool: Convert page_pool_return_page() to page_pool_return_netmem() Message-ID: References: <20230105214631.3939268-1-willy@infradead.org> <20230105214631.3939268-7-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230105214631.3939268-7-willy@infradead.org> X-Rspam-User: X-Rspamd-Queue-Id: 5B5AE20009 X-Rspamd-Server: rspam01 X-Stat-Signature: pw5gazidpn83xbuh1xq5tfjhixfhssc5 X-HE-Tag: 1673343598-961445 X-HE-Meta: U2FsdGVkX18KHFPKK8Og6t4VsjV2QJC/0JnV7pPJ3hh40xujndSfDyd2DEpxpsWUp3baCecp2PR6qFDTPaacc16iI1TE9kRrj7gu8GqVxDb0pAbyKs85qNdU2gt78lGh42gk/5xyuhkN92ds6POhjmRnjBfdy7hW7SWwj7gJVRuYWnxVde6Do1yKuPbwdIaJ9ZiP/G2pKk5WcWhpKo4YZFZ7BD939tj85aOiJUUNik6IGeui1BGc2QO/5W5NZXiqmdCagG6JzzAipQtBPVNKFJUz6K7NVBX1UoRWKi3zZuGC7/HxkM6SGIo05Qe+QlGvLEGMEeMpGexQrYiXQ6o+xlBh2W5SOvewKGf/c9L7CGiRSeNnor1Ut5eTyMLcCIYBQa5GzLMEbI8/hmqa1x49zxu0X08MZG8IlDz13PSO277XomTT/4XPZADCQ6hK9+sxaY55R+pF4AWvIYByjr8wtg7ePnGbn+Q3eeEIpeGdqDS7eKRFH8TXDS+kkVS1Ds3Vc+Tr/tXw/aQOmeqvv5lEfWOZBZ2U2WmWaIC2g2C1+yuV0XB8cXwHo7GJRPg7P5BaLWDF/cnYkzKOwUMK6dIiaMBiUvA9P08EYPNoBHP3tFpeouxwhIak9pYTuFJvyf98ZnsNsJzoAIHF5hnXTF8iXhi9vCq9TMqHnQyv6DjnkaH9wTsHnzgqEI2X9iuk5xHv/8mct2cVYL6oa0YGZRTiA6Gnfyn7mLeC4HEhPkcyqJr6rJFjDc9FSUayLqciB6/+Xls3YxtYCL7LglzIbQsBNbB4hz9AzlnTfYNYHePWcwHqqXSW4VYx7l6hQOK91piVN5U3sZzjPeqIJeSftwiiB4lH13MzIy+7nhLO/1N29PsLIyVaasTnGOqE3yuJUypQ7mY7DSTFYRnFmOmkUEAyHmPhAX6NkyOISMih7tjNvEoyyYv19ZFKFctaGEcZ2LF4Gi8T+il8cbKhowdySXv 5ODKzKWi bmHQU7/V0i3Fzo7D9RQI8PgCtm18/KwmkDZLn2pIH95VhIePvs5Ki9VO69rK7FdmoqoywdQOTNOPQcyQKx58iVRDOJuF1/4809ZRMTXLtCGBia0CdjYAHkJlQCNFdHS+S6FLK X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 05, 2023 at 09:46:13PM +0000, Matthew Wilcox (Oracle) wrote: > Removes a call to compound_head(), saving 464 bytes of kernel text > as page_pool_return_page() is inlined seven times. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > net/core/page_pool.c | 14 ++++++++++---- > 1 file changed, 10 insertions(+), 4 deletions(-) > > diff --git a/net/core/page_pool.c b/net/core/page_pool.c > index 4e985502c569..b606952773a6 100644 > --- a/net/core/page_pool.c > +++ b/net/core/page_pool.c > @@ -220,7 +220,13 @@ struct page_pool *page_pool_create(const struct page_pool_params *params) > } > EXPORT_SYMBOL(page_pool_create); > > -static void page_pool_return_page(struct page_pool *pool, struct page *page); > +static void page_pool_return_netmem(struct page_pool *pool, struct netmem *nm); > + > +static inline > +void page_pool_return_page(struct page_pool *pool, struct page *page) > +{ > + page_pool_return_netmem(pool, page_netmem(page)); > +} > > noinline > static struct page *page_pool_refill_alloc_cache(struct page_pool *pool) > @@ -499,11 +505,11 @@ void page_pool_release_netmem(struct page_pool *pool, struct netmem *nmem) > EXPORT_SYMBOL(page_pool_release_netmem); > > /* Return a page to the page allocator, cleaning up our state */ > -static void page_pool_return_page(struct page_pool *pool, struct page *page) > +static void page_pool_return_netmem(struct page_pool *pool, struct netmem *nmem) > { > - page_pool_release_page(pool, page); > + page_pool_release_netmem(pool, nmem); > > - put_page(page); > + netmem_put(nmem); > /* An optimization would be to call __free_pages(page, pool->p.order) > * knowing page is not part of page-cache (thus avoiding a > * __page_cache_release() call). > -- > 2.35.1 > Reviewed-by: Ilias Apalodimas