From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A044C46467 for ; Tue, 10 Jan 2023 10:27:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EB2EF8E0002; Tue, 10 Jan 2023 05:27:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E61EA8E0001; Tue, 10 Jan 2023 05:27:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D29A68E0002; Tue, 10 Jan 2023 05:27:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id C2FEA8E0001 for ; Tue, 10 Jan 2023 05:27:30 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 9B1808097B for ; Tue, 10 Jan 2023 10:27:30 +0000 (UTC) X-FDA: 80338512660.25.A03D125 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) by imf27.hostedemail.com (Postfix) with ESMTP id EF30240012 for ; Tue, 10 Jan 2023 10:27:28 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=uKFZ8zPA; spf=pass (imf27.hostedemail.com: domain of ilias.apalodimas@linaro.org designates 209.85.218.48 as permitted sender) smtp.mailfrom=ilias.apalodimas@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673346449; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CQ9HaD5lhY305KANBx80wolIrRiJI7YBQDlDXhg3c7M=; b=MZZRmj7BaOyYwNgCph+uYclhW5LhKqTTIdCp0GCWIXFCwXDQ1Di+ZgvX/Fv9TUupV332RQ WTQKYo6PQz8SW5i8khq3vT+I5xyHoLsKOYyN26+3RUxJH612LOoAbT4Cylv/b2/cVqPIkd ee51n1DSflf1NcfpMyTmo6j7wtJrBQU= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=uKFZ8zPA; spf=pass (imf27.hostedemail.com: domain of ilias.apalodimas@linaro.org designates 209.85.218.48 as permitted sender) smtp.mailfrom=ilias.apalodimas@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673346449; a=rsa-sha256; cv=none; b=XzHAPgEjjCr5PQwq7ICUJ8hLBPy4oyfhu+YFu+RWgfM3MPXi264v/bWCdu/IrViS0ytoSk 3Y35eGVPF/hHHbf3PsmE9GPLXh/RJyU/+FPeqz6gvMnj+N+3drMFLeQESG+GOqNa1x3210 WD95BmMkb3wvajLOima8Rmin3P6lgho= Received: by mail-ej1-f48.google.com with SMTP id u9so27429482ejo.0 for ; Tue, 10 Jan 2023 02:27:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=CQ9HaD5lhY305KANBx80wolIrRiJI7YBQDlDXhg3c7M=; b=uKFZ8zPAe7vsnaCYjq43gODxZt9AYLBuxf2eG8LEhNGHBocdPMraf5flzuLBomTbjE d4H4JhLEAR+FZVMwZH+CH4RlO12ERnUphYm3n8GsPwkc0Qx9eF0DOKFY8zkqDOXgXWJt PQ2XL03F1kZmincyoEOyO7MACWb/3E+62KasPNnjg9vQuQHMNKoRxjRw6oezXnBWHcYN tFGKBgU8Lzq3jrESWlvF1Nfa0pBdRXL2h6kQyE9UsBLmJNlvAPd46KvOINHoKLVbu04t EVNoE1UMNKHFru6HskKyJxngSLq6jB6H5RKdTFSqrRQ0QzkkiHpP1qmeA0LSk78jCNES 11/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=CQ9HaD5lhY305KANBx80wolIrRiJI7YBQDlDXhg3c7M=; b=vqwCOLhKHyg83R0rlCP+aT+Pj1X7sDDnvkDH2Jr2rCP5lgGP7GJm0tizq5VAu+eInb MlOpZBpB1ir85Gr6+QB7oYpDpNVDcgY8L9G/SGqtb3nrCQg5zvOBy4dld4kaT5w2JIY9 8OctUIlQfHiQZ4MFwD2rHAzQW9CnL0AR1iv1GXIty7QDI+O59gUWl3VUoA+L9wmO9ie1 LEOsVgN254DtSUNJGhRrF16qHRLOZ7vh4xD498ylxsCdSF6SGU4PMmLV96sBRld/5px6 BqPGeH5T69S7w9tNkzG2Bs+gWzbb6pkIbjuA8+PztjskQP+f2C6cbUerYxOjrxOYut1X gtPg== X-Gm-Message-State: AFqh2koRAklNgxgIM2WkmdGVI4o0s+gLNspoHYMvduO0s3f+POb40vaO IPYe1wp5y67aEbExi3gglvwewg== X-Google-Smtp-Source: AMrXdXsjdaz5w3UirnEdQR0g6CZWHH4x3ZGAHI565jTu5hWXOWg03B6tnTzl6zgCe8wZvEyyj8vn+A== X-Received: by 2002:a17:907:6f18:b0:837:3ed3:9c2b with SMTP id sy24-20020a1709076f1800b008373ed39c2bmr64760224ejc.5.1673346447559; Tue, 10 Jan 2023 02:27:27 -0800 (PST) Received: from hera (ppp079167090036.access.hol.gr. [79.167.90.36]) by smtp.gmail.com with ESMTPSA id c10-20020a17090618aa00b0084d14646fd9sm4683470ejf.165.2023.01.10.02.27.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jan 2023 02:27:27 -0800 (PST) Date: Tue, 10 Jan 2023 12:27:25 +0200 From: Ilias Apalodimas To: "Matthew Wilcox (Oracle)" Cc: Jesper Dangaard Brouer , netdev@vger.kernel.org, linux-mm@kvack.org, Shakeel Butt Subject: Re: [PATCH v2 09/24] page_pool: Convert page_pool_defrag_page() to page_pool_defrag_netmem() Message-ID: References: <20230105214631.3939268-1-willy@infradead.org> <20230105214631.3939268-10-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230105214631.3939268-10-willy@infradead.org> X-Stat-Signature: gh7fsnnt5djeju61dmh9xki565frxg74 X-Rspam-User: X-Rspamd-Queue-Id: EF30240012 X-Rspamd-Server: rspam06 X-HE-Tag: 1673346448-974361 X-HE-Meta: U2FsdGVkX18kpIhSQolV13c/6oj7Mk0KBVAxrdtUPLu4qmF6V1C+p36487LjFywW4kqyghJsfv1FJRX2XnmDzdSkUyh9AijHUgNxt2+JhXjjNn2+qdZDeNYp27cdPuiTQ7khUnY2zQB08z5+F8/ZqBJmNExA9SKRBVRF/ltwiJHIjN+RyiyC6pieH8CTo3F9UK1iWKh0Y6iVRfv7xTFPpTu66qBPZXm4vg4wM02nRShXWHPwbyl/JsjkDma7yq+R9ThhZ84QxOQMZ/Ry1KeWFReKfXcZofReZ432aGcb/zF1gaqO8Qa0BH86UwD2o8TDJ8Cp+NB2s0t79F414gdx21buMfxApRKvNmugsGcbY/h9wFXyqSJqeaoBsEBgKZ2ZEO34DzdRLhLkzcBavNsY0YRmM6DHLIVBrwPcpy4QmLvE+wgD4pdKhLAkGX5vHU6rGy9TZm6UWpeyLYRwnaQPSoF283HE7gUJ9Xc5c0p/tGyVLiz7WIta3sP1wA0WUolEVBstfEB1FKBtA9qDKWs7SRTBorxnZ1RzBX4EJEZukrMVwQVyBHVSmY5GyrXzxp5cxSTQQZToTHg9CndYLAzmwoWo7Dd+w8JcYGGdjuLH7Kf94IRdTbPIYoGx4ng6PNAOViJ24dTqUyjM2f0oUjl+pBrUa5HXGIIRKtJCuNJIQ+4Mi4ZaGo8oKsBP/aU/uTe070STAHA2p9vR1/TlJVIRZgLQm+bBZlLeEukoGXFvcPXdkNealIX8yCmCLpZrUIeU9HG13avRmGXhJ6roQ/h/H4s5eop41i40xkxGg4OgwOj4gt+4kLlUXBpHo+kzLCx7osCNqiIeCMvHyoVPXE788HnnWcfJT6VD+CG3EujpM43Zjb+PXheyLWOQVAbN02rZItEE6B8if5I4bH7d15ctE/uwNV34INSYSzrZhH86esWx3UY4To6IGYqnh0URlqMEIdGhIXorgRBIGQHrMaj HIgwIilJ 6rD9ncaFSFY/kvAGin31DHWIXIzE+VWZo9NAUoL6PSUNi3n+MyX+enN9zSxW18oYZvcrijWZmBcIA2gJg3rFlG0RfJYA68JT8FsSROmRTwKJDj6WF8cqodiN2YH4ryCneVNMh X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 05, 2023 at 09:46:16PM +0000, Matthew Wilcox (Oracle) wrote: > Add a page_pool_defrag_page() wrapper. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > include/net/page_pool.h | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/include/net/page_pool.h b/include/net/page_pool.h > index 63aa530922de..8fe494166427 100644 > --- a/include/net/page_pool.h > +++ b/include/net/page_pool.h > @@ -393,7 +393,7 @@ static inline void page_pool_fragment_page(struct page *page, long nr) > atomic_long_set(&page->pp_frag_count, nr); > } > > -static inline long page_pool_defrag_page(struct page *page, long nr) > +static inline long page_pool_defrag_netmem(struct netmem *nmem, long nr) > { > long ret; > > @@ -406,14 +406,19 @@ static inline long page_pool_defrag_page(struct page *page, long nr) > * especially when dealing with a page that may be partitioned > * into only 2 or 3 pieces. > */ > - if (atomic_long_read(&page->pp_frag_count) == nr) > + if (atomic_long_read(&nmem->pp_frag_count) == nr) > return 0; > > - ret = atomic_long_sub_return(nr, &page->pp_frag_count); > + ret = atomic_long_sub_return(nr, &nmem->pp_frag_count); > WARN_ON(ret < 0); > return ret; > } > > +static inline long page_pool_defrag_page(struct page *page, long nr) > +{ > + return page_pool_defrag_netmem(page_netmem(page), nr); > +} > + > static inline bool page_pool_is_last_frag(struct page_pool *pool, > struct page *page) > { > -- > 2.35.1 > Reviewed-by: Ilias Apalodimas