From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6A74C54EBC for ; Tue, 10 Jan 2023 10:36:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2ECCD8E0002; Tue, 10 Jan 2023 05:36:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 29C3B8E0001; Tue, 10 Jan 2023 05:36:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 164258E0002; Tue, 10 Jan 2023 05:36:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 064788E0001 for ; Tue, 10 Jan 2023 05:36:09 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id CBBA4C0682 for ; Tue, 10 Jan 2023 10:36:08 +0000 (UTC) X-FDA: 80338534416.26.427A165 Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) by imf17.hostedemail.com (Postfix) with ESMTP id 1F3404000E for ; Tue, 10 Jan 2023 10:36:06 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=m2Wl07b3; spf=pass (imf17.hostedemail.com: domain of ilias.apalodimas@linaro.org designates 209.85.208.45 as permitted sender) smtp.mailfrom=ilias.apalodimas@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673346967; a=rsa-sha256; cv=none; b=Uv3WkBbTsZ8Vg31SR2HVwbp6eeXT6XDbZ2Sa0ZIC3v/LrzPmOSk1A6GdrJBeWRiCfSTcsd eVg7OK+xEESmCJFNekw2SbyXu6lU+WQQN4Pv9d0dVsmTSdK+1orSwA6o9PB2wICE1rYdCx +8YjDcV93U3mnlwym6hOXam2D9dycMQ= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=m2Wl07b3; spf=pass (imf17.hostedemail.com: domain of ilias.apalodimas@linaro.org designates 209.85.208.45 as permitted sender) smtp.mailfrom=ilias.apalodimas@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673346967; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fsWLPCgWAXbyJUmxP1P4A2zhpjbxNYdawZ7e7VhzWL8=; b=4/D2ryeQ2IaRn/4KIqgvMGjw8lO3xO6YT2k4s0KVAwunXJnFZ002yhILV0RB3PKM7EalWi uVHDtQbQ17ApiOcM7jlPtv/bwpNCa+7NADk5ukzOxZKhIC0WD+bIGbP5YPbvi8j/XZY/70 u4eWQ9O2GxxqP0vVu92VbPTsbc1PY8Q= Received: by mail-ed1-f45.google.com with SMTP id m21so16875988edc.3 for ; Tue, 10 Jan 2023 02:36:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=fsWLPCgWAXbyJUmxP1P4A2zhpjbxNYdawZ7e7VhzWL8=; b=m2Wl07b3n5eNjHDrCuw1EigL8SKkLvaYtca48Y7NVFwWTMXC0JS6af2iFpfTaj3Hc2 yAb7EV21GoFf+euVyVdc8WoRAp7/WovPM7XawQwx+OvScXQTXc+TBG4mPh8yrZoAXt9m I2BQDvQ0hJi+C7sO/gszSfNWieMBhna7EzVfvqiYDfCjZWZJ7IzlRmbNBGFrxLjQT4dj e0XU0POJt8amvccfaaV7yWW5IWbmoUicKcvdtBIvHVUdsCmH0732tVJ58QZu9G4PBlFn DwK0sJHZBILZqk9kN6H2d7kQhzNkWXYvvxz9Wbl9Uj1/ME+tuyBMenm1xwpwVtsFglUu ZcCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=fsWLPCgWAXbyJUmxP1P4A2zhpjbxNYdawZ7e7VhzWL8=; b=eGGTy7pn0/AECJnyJRc0qCjUDP9Z92ShGwQKLDXHRF/bhOzwPwgXK200yvDuNyN4x+ UGKbhryXPECfqRQau3hx3xH9+Cr/zrNZ0HCDKyUx/hUqNSZ05az8YL5MhhD3LInOmaIm jQbCthwL+1oD3/cTHhw04SW5vzadcz/tcHyNZEiBl4K+fI5GeOezKiEtj+vTs/KVike8 ECK1FdRijfbRniHe6UU5+376ZMb0dvLOH8nTLlzV24pq/YhWo6EUu7y3O6OWwJ62K0df tBEHintBOeRBj36cwxEr9ewoSxj5plmGcEolDTbG8Rxk9hCMFm3m5c4mtdLDiDXomVSx hTug== X-Gm-Message-State: AFqh2kqwuvbab0lopn5hOzqG128knWo4AJH7bLREN5NUdzDcMBEWjwVt HlkihBD76XtPnK8E6DwWnZXdBQ== X-Google-Smtp-Source: AMrXdXvX/pTChGKviC4PW+njVsgAzjNhYouj65M0XK0C1G7FvApqo+tr9glOrN9Fljci+JnS2pumNQ== X-Received: by 2002:a05:6402:414:b0:495:77a9:f108 with SMTP id q20-20020a056402041400b0049577a9f108mr17719404edv.39.1673346965835; Tue, 10 Jan 2023 02:36:05 -0800 (PST) Received: from hera (ppp079167090036.access.hol.gr. [79.167.90.36]) by smtp.gmail.com with ESMTPSA id l4-20020a056402344400b004822681a671sm4748712edc.37.2023.01.10.02.36.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jan 2023 02:36:05 -0800 (PST) Date: Tue, 10 Jan 2023 12:36:03 +0200 From: Ilias Apalodimas To: "Matthew Wilcox (Oracle)" Cc: Jesper Dangaard Brouer , netdev@vger.kernel.org, linux-mm@kvack.org, Shakeel Butt Subject: Re: [PATCH v2 10/24] page_pool: Convert page_pool_put_defragged_page() to netmem Message-ID: References: <20230105214631.3939268-1-willy@infradead.org> <20230105214631.3939268-11-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230105214631.3939268-11-willy@infradead.org> X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 1F3404000E X-Stat-Signature: 74cri9j1uw518my6tmm5644aagb4iuzs X-HE-Tag: 1673346966-8610 X-HE-Meta: U2FsdGVkX184NAWB8OJyOZ+rsjdhxAxQQtydXBPBZLrAJeO6raVg2b7SC4bUzQn5WpIpOfscekLR9UXr6Sp1vlit2SwhO0MdAbOIhmSpYoX+6UCM/vEyhupnITgMy4HWmdOdB8ky45Ki7mbccR3LoiwOKn55XCoFgARQcGEThPv0DoOs1jOYntRPNgCXL4cnroEOeDFxBNtmTZXKobKWlIrrNX++lKoOe9YeU0EH5pXNkHmcTZCOXXsl8Iti2WwwcvC3K54IjIZ98GTzuJdPaQ2CuKohe7sPDO9RDqpnucxJTrIWQ/19VbyrBxgGsPtAoxtuG2AKOP1mc0Y5+EFrPrYabTIyPvepE3AR8Is9XMyJWFJ7zZpJppyxJREup5nyLdAT/cEIozEY3uIRcy7cic9o52hGz83R0pd0RgQlqq+zvhNonn8D/nUy8/kBybEwR2Nh/uzjJ1AaECZJbBx/PBZhXQ+oQthyXqYMfHloolAKOMk7BG2w6qwi5rK4ax8SvnJmY7qh46nbd3cQUt3hQi5hrhI3DhawjDHeU84pgIoyc6TYCOE5F85EIlXzmOUkJDX/yWO7j6eVTxOABLVP0qzy/sR7fQerUpc5Zjbe2Vdmc7uO7Hwg8YIWbgbNQWCOfcRN6k76YSAjCtnojGPL1O4WfHZ2U35U+PdYzvF2+NqiS7jXj2vm0huv7DdMIxEjroI6TS7bXhPz11wt91xPh2F5NCfImPlBkGGrA2/ECw6v7Ah9+nFihNPOH/Gdx54y8YV7ykfWQ3W2Mv6w6CwrguIIWJvaQESBw7A882Q4hEflUddooVKaLO/9UIz8jO/ADs7jJrcPu/XTlTGt5nGnqX61t9xhJjO/AVvkI/Vb32+5rUsJtu38GRBdmvIW81qSRmQI8mSbQdJE9sbtUXAi+3R4FUjdGHMnzU/alhWtFlVog8EHkmlVBgYHOx/PoXJXEpl7HrN0/pjrFpODmo4 ZLoDuMe+ ArzSnb4vOqSAKAlphpApYM5K59RfPBySonClH9FuwdZrO93I2OWe491vT5flMlYtNXt2cVOJ7rt1wxEIT2FpX0vt9L38IuyIpipvv7argyJ7VMwjRoyda6YJO83s4vSLP75M3 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 05, 2023 at 09:46:17PM +0000, Matthew Wilcox (Oracle) wrote: > Also convert page_pool_is_last_frag(), page_pool_put_page(), > page_pool_recycle_in_ring() and use netmem in page_pool_put_page_bulk(). > [...] > - if (!page_pool_is_last_frag(pool, page)) > + if (!page_pool_is_last_frag(pool, nmem)) > return; > > - page_pool_put_defragged_page(pool, page, dma_sync_size, allow_direct); > + page_pool_put_defragged_netmem(pool, nmem, dma_sync_size, allow_direct); > #endif > } > nit again, but can we add a comment that this is planned for removal once we convert teh remaining drivers? > +static inline void page_pool_put_page(struct page_pool *pool, > + struct page *page, > + unsigned int dma_sync_size, > + bool allow_direct) > +{ > + page_pool_put_netmem(pool, page_netmem(page), dma_sync_size, > + allow_direct); > +} > + [...] Regards /Ilias