From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55E49C67871 for ; Thu, 12 Jan 2023 07:56:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 923FD8E0002; Thu, 12 Jan 2023 02:56:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8D3BE8E0001; Thu, 12 Jan 2023 02:56:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7C3AE8E0002; Thu, 12 Jan 2023 02:56:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 68F488E0001 for ; Thu, 12 Jan 2023 02:56:07 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 4B3EC14096A for ; Thu, 12 Jan 2023 07:56:07 +0000 (UTC) X-FDA: 80345388774.15.9C8D239 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf27.hostedemail.com (Postfix) with ESMTP id EFC3840011 for ; Thu, 12 Jan 2023 07:56:04 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=yHH+FvQE; spf=none (imf27.hostedemail.com: domain of BATV+465e1fdda261bb4183db+7081+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+465e1fdda261bb4183db+7081+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673510165; a=rsa-sha256; cv=none; b=jKgT+sD2O3lrlkYm3N9DmYSoQYLXdfiTIVPrwD7s1bkQtwpOzqGCnzgi0a6bXDYQuNQEtl 5TGT95nt4FbG2CCP70jaw6sVslpdOGmIf7ge3opWtQDa6h0rtID4wv13+LZCpiQRzdvAEp LpqQlZQcwSBqUVQLfiuj7u2vLoTzl+c= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=yHH+FvQE; spf=none (imf27.hostedemail.com: domain of BATV+465e1fdda261bb4183db+7081+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+465e1fdda261bb4183db+7081+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673510165; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3juqZYwYPTt6tYEzQZfyxL5E5PLSuO+2HSviGS3R84Q=; b=K7cBBoYIFZu7ZU76tPs8ENVlP/ATdsRt+IrSUuiPDfxASSn9MeS3LU0874CD0J2XZ0W6Iz IxTLP95MzfW5KJMArFxc5S8UgO5FckWeLHYoT//hqSb5Ub55MERCCOvqzMFbI3M8LI9nRj ae5PbfwFng+auqtoFX/GRzodmGEYgsE= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=3juqZYwYPTt6tYEzQZfyxL5E5PLSuO+2HSviGS3R84Q=; b=yHH+FvQEgFBHDaoK7vAimdW6QQ mlQx+dHomBLYLTETU/w8pivXgj/VKBndhNI/vLBEh3+c+nmCQvJqIMwz3g/fP4BK5IYQSVwc8iN/I GZcumX2URlF+kG4ol10ClDTVLZKeB5P5HUaoEe1j7xShPynHoVubvwvBI5lSyRlNbvlJuHEMQJWOD 8WHZZ1Nd57scQpLchQQiAULaeG09penseslfGyWVVmCM2YxKk+YXhpT+lTTzgK0dHHyFcExCrpt2L 4raHtXhkJinUZnbHhhauHChgWfjC/pw3H7pN0WZVqLaJoJ+JUGh6H2db9XdsozB+lOQ71Hifa6qwx E3OwZkdQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFsRD-00E3Dq-VL; Thu, 12 Jan 2023 07:55:51 +0000 Date: Wed, 11 Jan 2023 23:55:51 -0800 From: Christoph Hellwig To: David Howells Cc: Al Viro , Christoph Hellwig , John Hubbard , Matthew Wilcox , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , Jens Axboe , Jan Kara , Jeff Layton , Logan Gunthorpe , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 4/9] iov_iter: Add a function to extract a page list from an iterator Message-ID: References: <167344725490.2425628.13771289553670112965.stgit@warthog.procyon.org.uk> <167344728530.2425628.9613910866466387722.stgit@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <167344728530.2425628.9613910866466387722.stgit@warthog.procyon.org.uk> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Queue-Id: EFC3840011 X-Rspamd-Server: rspam01 X-Stat-Signature: 4pfu9ayke9ntzn5fb6kbueo9e5prx6s8 X-HE-Tag: 1673510164-456643 X-HE-Meta: U2FsdGVkX1/0I8wOuyJhHPv3nVD7VAg87XPtYY42myDDXgWlWWemYmmhDwX4BqC03cUdr/B3ZE7vElUMIQFJvX4UlR2+SMqusqL9XHcH9MoBvzYey/mh/GpP0Iof2ixV3vO/IR5LjcCX9Zv2Nvx/k9b4/CUbI1Z0lSUT1RxXtJ5QIYo0iH8sqjCjYVCwHLNZWsIjJZ1IiI/HiAedK+IQCJldoeKCoCjVVBh1RHsv8AfugXDmfT5ScwWTlnKMNXKnhKa/wNS8obqiMn3qNjNozurLFuIZh5PcpLt4O3zyqX3lCMQHi6ulNBg3Onw2ox+7kF0eKcvBm/PIgtUQgEEpgJodXtFGWJWY4/jftgSqGWrcQEMzYD+Kq9RJqADU8fkNJCzkGtRLdxLke4EIOHaPNQuWMyDDQa7nxFW7PFBI6G0WDAH799jGMUJKctB4mM3tJNnzGCBvUrdRmaTZZukfwZp8OYdoZbBngBeMoOcrNG20IEju1t8ZzWABR9QPVwvDPzUUHr/dRs8feFzIr7apvdB/utboSGcZ0yHUbb9TBK3vcQ6rNxgNiDP5f05M6BOHdbst2rsXjsM5wSgKcWirsf33MGdH4V2kfYA7HEB90HvtMr7j6EH1ZdZ/IlOmvH3AUmtp5m+xeQmiP28kPOdk6tgZ5N/+9UJIxKxilm91qhHvRz7YKJTK5a5BljxyNXZ4RMrJ2t4iYuDWhsrkDlJ1DvD19wMQdxRxCYxG9NGQLfzE1HbytUVU2cb6vev3A4DPzaUsgoHg3NBXAm8suGlxo8PM62oMSPXP2DtrmWkptjGHWFp4FGi0D0ioo49qZiatwaUDNVZTatkLHowqHJ/42pzqKn4DgEOE8SVRPJIAGWawI6FPqYmqs/j3lB1zzV2+EBIQJ99FY6ETHE/mI6mk1zlOSWZwlYrIPg0DefPCvlb6i37O0D6nT9AwC4Nj27U/5iX1DZa+eufnOBz4/BK 6zNjbmaJ gWvATwzIs6f6/93f4CxHQqpRPT4SkaLpNNL0+0GviCwz5lI65/ErtuhFnhEC6RZBQNSgniqby6TZF+xQmov5EQExqDub7PjmkYlVB0daR2TO9aEOviILWYV25Y/pIpkA/hgaV4QSwvxrSLg18+jiVI+vG+6Y039jPXnzuWkcb5nmIuSht/z8Sxm9A8Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > + BUG(); // if it had been empty, we wouldn't get called Please use a normal /* */ comment here. Otherwise looks good: Reviewed-by: Christoph Hellwig