From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 429FDC54EBD for ; Thu, 12 Jan 2023 10:36:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D66668E0002; Thu, 12 Jan 2023 05:36:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D16D38E0001; Thu, 12 Jan 2023 05:36:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C07368E0002; Thu, 12 Jan 2023 05:36:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id AFDF38E0001 for ; Thu, 12 Jan 2023 05:36:35 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 845B6806D4 for ; Thu, 12 Jan 2023 10:36:35 +0000 (UTC) X-FDA: 80345793150.21.042068B Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf05.hostedemail.com (Postfix) with ESMTP id 2903110000C for ; Thu, 12 Jan 2023 10:36:32 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=JJN8SRR0; spf=none (imf05.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673519794; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FbD0IxWuAX/Y8WsFg6u3/hujf5Ic00N3x5hHmUPVo3k=; b=52uCk01lKd61L8pUPqQGWA8llGWWRC+dOVXJ2O4flrJ+P8cusEJxOUM2c3T7rEnhtA1qyM Xaf/CmxpM78lkRlxxDlMLE5AOvaQ4l7tC/MFn5UWBV0crD5npSOp2JwjyhsTL/4k99Pont UIYlyKVYlH82aZCNMxsm3sxIv8Qe0UA= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=JJN8SRR0; spf=none (imf05.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673519794; a=rsa-sha256; cv=none; b=yNmc5RByCj2aZMY+vk680mVbnqkW3CSPFGV4yYEIoR+Zv/Ul/t6CZeTLk3pkxOUjz9f1mE LmhYzEaaU+50b9Pm05Euro5HOj0OgXxPztxaY+jKcNNRsWhg/Yxb82U0fYElyvvuWAGUVV LsNdqYGjv66EfdZskQ/FWdA/R/aDy1s= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=FbD0IxWuAX/Y8WsFg6u3/hujf5Ic00N3x5hHmUPVo3k=; b=JJN8SRR0AcR1WfdCZaFcyHSia9 //YI6UN0uXhh2PkY8RGhTr4Lygk+YYq63ibUzQ5iZpz+1D0m/a8hjCg24QcmYFH50XRKasTBj7cQJ rK31jXqyB4CIu1NKgIwZxoU11LJaKDLCg8rpBXGUQlCdhovZLYEzlHXi2Myu20rx0lcCY7yKgdq6C FjLhRA3FtITaih04d9/a29ZLOgYnFMRs7ej45UE5i53cOYM7CPQ/HL0O5laaUvjvsgY64jtnnNt4Q dCpFpDnoCkjV1Iih8lxPHE00Y25SCaI3EnkOu30Po1hfzB5iIuEgP3nCwt6o3Bano83Cx8LO/bq2B UxGw7UJA==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFuwT-004zNt-8i; Thu, 12 Jan 2023 10:36:17 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 6F8DC30084B; Thu, 12 Jan 2023 11:35:59 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 2B0E12CC6D735; Thu, 12 Jan 2023 11:35:59 +0100 (CET) Date: Thu, 12 Jan 2023 11:35:59 +0100 From: Peter Zijlstra To: Mark Rutland Cc: torvalds@linux-foundation.org, corbet@lwn.net, will@kernel.org, boqun.feng@gmail.com, catalin.marinas@arm.com, dennis@kernel.org, tj@kernel.org, cl@linux.com, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, Herbert Xu , davem@davemloft.net, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, joro@8bytes.org, suravee.suthikulpanit@amd.com, robin.murphy@arm.com, dwmw2@infradead.org, baolu.lu@linux.intel.com, Arnd Bergmann , penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, Andrew Morton , vbabka@suse.cz, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, linux-crypto@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org Subject: Re: [RFC][PATCH 05/12] arch: Introduce arch_{,try_}_cmpxchg128{,_local}() Message-ID: References: <20221219153525.632521981@infradead.org> <20221219154119.154045458@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 2903110000C X-Stat-Signature: p7eoqdq3d8hc46bh5rnb3cxxdaeknsxr X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1673519792-163901 X-HE-Meta: U2FsdGVkX1/TzRta22G9kH7hP6LJyzROPNVJuukH/N6wTN1VOlevSHVugB0kjjxIvaYxdkw85MNM7bW5vMNewDMb7pk7438aG9frjJCLm0v+O/wZBsV/291Lci5UmnVdKlWrQoWSJ9+8uQqQ4jVlPCxIjGG81gjz6Zbb9YYRXq7YBo6JGifca+YVR9CUktgOpIyiv1bgiVsFC9MSVLEmoxpKs8OUE+V8I4w2ZkVnjun3N12wDQTrOiufvMcO2kdoFCMm9gBDhKbI5bHqzJZ2EaamVKLNbLeMeT42XShZsSjFUP3zniMVBLLjQa6rMMXawuq7IRT59/4uagAmramdiA0+xWq3pyssyPPwKGCOTVU6smV7Vfou4SUEoHcR5kc0wcZo3vTc+0UaPtfBtfk4i9TUWkv17IIE+e28FUtOUoaac8TFobHkfBX77kvZOHppJ2qesS0yOxhN/ZpXdEFdrLlLE6qWeTeTYnxijzB439KAjKXJXln4S8SvqCgin+WBIdNFjbpftXCkO3ffotQcXb9WGr1HatGWUH5K6jgZkI3wGZjkTI0VDYCh9B1PiOiYZY0LeEh+w8y5lTMjVL6AsSGsSVB1KjGOscSei4VQeGG72Narnuvj0CMPt3+TEhBaBtUIa9SJ87KFhs1Z8oD1FXATnj3tZb3w5MT8FpjnTTbbsNWE/ZdMG1cBkT+k4PZnLbPkDfwiGTm3JD24mRhQTHtDDiTAq+Cos7FDlX4kFU8V13z2vEEIoxVDqOfDWgaZuWCZsLwX8xGG2SJwZcPtfLWMNKcpztybb34G3ByesBiFNRHeh4dQa+5sHYKgfwMUOe2LWeKh5ToAqwRi7DWegyYxW30GujnUvJAVSQ0iNQjvHlH+bQ85Ilyib9blEPJIReuvXMC1rFmE6lhLbGcrOkmTMSH/a/hnkTwRKi3f0miiOopSoUK1seTxyWqkd7S/TInqbKdJ+C7V9ukBxaq rpvWRa8J RhCXT X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 09, 2023 at 06:50:24PM +0000, Mark Rutland wrote: > Similarly, I'd suggest: > > | #define __CMPXCHG128(name, mb, cl...) \ > | static __always_inline u128 \ > | __lse__cmpxchg128##name(volatile u128 *ptr, u128 old, u128 new) \ > | { \ > | asm volatile( \ > | __LSE_PREAMBLE \ > | " casp" #mb "\t%[old], %H[old], %[new], %H[new], %[v]\n" \ > | : [old] "+&r" (old), \ > | [v] "+Q" (*(u128 *)ptr) \ > | : [new] "r" (new) \ > | : cl); \ > | \ > | return old; \ > | } > | > | __CMPXCHG128( , ) > | __CMPXCHG128(_mb, al, "memory") > | > | #undef __CMPXCHG128 clang-16 seems to hate on this like: arch/arm64/include/asm/atomic_lse.h:342:1: warning: value size does not match register size specified by the constraint and modifier [-Wasm-operand-widths] arch/arm64/include/asm/atomic_lse.h:334:17: note: expanded from macro '__CMPXCHG128' : [old] "+&r" (old), \ ^ (much the same for the ll_sc version; if you want the full build thing, holler and I'll bounce you the robot mail).