From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74C1FC54EBD for ; Thu, 12 Jan 2023 12:40:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 08756900006; Thu, 12 Jan 2023 07:40:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 03895900002; Thu, 12 Jan 2023 07:40:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E69E1900006; Thu, 12 Jan 2023 07:40:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D720F900002 for ; Thu, 12 Jan 2023 07:40:33 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id B0BEBA01FD for ; Thu, 12 Jan 2023 12:40:33 +0000 (UTC) X-FDA: 80346105546.13.4D965E9 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf16.hostedemail.com (Postfix) with ESMTP id 79A48180011 for ; Thu, 12 Jan 2023 12:40:31 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=T7wwF4o2; spf=none (imf16.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673527232; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mvO5tR0KUOsJdsfD0P1qEq8RUaujsRmUiyJ4CK3nBds=; b=xA5H92Bt3tko0N4koGq/7Oym/CXTxPDDsbVEPefQarzarFK1jWFgcE+jz8cXrQEKuV1ugp M7px/1yIUL7bMhMvvZ/Q2BF46so5n/hVRAa4jZa3aWNZxhoE9lO/jYg4CijUhpFg6MCpup u2LTmhBWfsdwh/wW8E/tIXnSxnwsb88= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=T7wwF4o2; spf=none (imf16.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673527232; a=rsa-sha256; cv=none; b=rbI5NWgbxQozIHlLylC5ipk8t5cWk4g/+WHa/SJpbhPu65KPLK3G3WPZUurCq7rENFGoAD Cn5da9n8nqrk5LVn3RfWk2MGBCKPGdrjClU2sYlebolX3zORl/gfeFnzu04XL/JZaX+SyB 9f3Ov0Wx0QWwDgrCy3SrEKiSz0rXO5A= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=mvO5tR0KUOsJdsfD0P1qEq8RUaujsRmUiyJ4CK3nBds=; b=T7wwF4o2wMbXAAf/nIkqgyMWQk KRznk17AxbHH0YYK6ROc6I223maGYm3P1GMMQ8qxKRvobpY6tOM7rc87nFVeSPgOzF+jfrEoj4Lzl eHvYdsNvY67W5BCue4GYVkg43DOy17Bj1fHxkqS6b41LwBka32c05CZ18gVkWpgbjNPaIxrRWm1hA DwS0zYIkJu0Sqm4IrcZ64gmOjcC3fRYGQwzaUThCEeqbF3eNCiGBMkNMNHt0Zs7NffntSkkCqCEhd Nu3AzRHcgP/YmajTIFHvKOFMEI/GFwe4z42IviqKP7d9IezG9lCvqt25MStlz9+QlI86OJwz5apvR 3CW7QAyw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFwsn-0053bD-Sp; Thu, 12 Jan 2023 12:40:38 +0000 Date: Thu, 12 Jan 2023 12:40:37 +0000 From: Matthew Wilcox To: John Hubbard Cc: Andrew Morton , linux-mm@kvack.org, Hugh Dickins Subject: Re: [PATCH 01/28] mm: Remove folio_pincount_ptr() and head_compound_pincount() Message-ID: References: <20230111142915.1001531-1-willy@infradead.org> <20230111142915.1001531-2-willy@infradead.org> <0494d96b-ce69-b40c-f766-228c1d880d0f@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0494d96b-ce69-b40c-f766-228c1d880d0f@nvidia.com> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 79A48180011 X-Stat-Signature: ztzp5z8motk3jgyujeuopmtiwg31teta X-Rspam-User: X-HE-Tag: 1673527231-210232 X-HE-Meta: U2FsdGVkX1/YnZ5phvzU3I7FVWWK5qIF6jNsyHvZtG38ZcidAOGkwaH8iLnJ2a95HXvYBY7QlOF6MGFuO/wUGeLBUQDCix+YmGHWESCvqmSRr2yUwnXUREEk5ibb+Rj5EdJq3MiEacMeI92+K6Y65olAYg2UVRtw1IqvuN1yYzcrIU0nkcN6C/54+Ryj+7iJaVFY9sxGgsT7VKuXLyRao9ApdSUK7xYo7VzOmJkoz5CofXW4q1RN7t4/RXQsSusCM+g1uKYOW0Gqs2vyAKb9Vd8ohpBURoj+9iINVM55OX/doVw6JB59bvVovBbidBADmmmCFEMGppRKiP/EhRteItn9BhEr+eczdYsK+3NwVDTIpL9qKBLLxDdWx1khxe+gzjbMzuXlCLpOX8hvqJ5vDPpHmJJ/BRGJDGn8U5FPjXs7WE5LhnVqnmaxZDUATCWHo+gdq2VbsmGtxzkkml3iWE3Rtzx0hN9kWBo3i+wRySgoVGmgXSvM6MN2PHgO503jeRc4hk38Djdf8WZuKt7FMqTlBYmajym+IFo5fpRsEEdQjMOKd5HgcnKo8Yaec7XSHqibxwVl5lgF0Gwwl7KP9hfv05EGMcPSOB2aN6AW/Jp9Nv0FImCEGf3aoqcg+X+9hhsZERTzWCAW2bgHWyX/2kRUbj72wcVF/cYDldPw+AqERSuJCAg8wAF1L1cPXRb57mRmjSIFTOvRGvWjHTy3Pe3YS7pbYPhjzCX8WF8feTulXPwKoOcO+Z3P3hLF0lGNDhoAOnHkY+ja7+bC46Ee/awO8zKFlFsdES5KSfviVAGAg93EzFgw1a4WGA4Gm8ZXHdh44enio0E0gpNndeHn7G4/n2Nh1M81zOh3sYYEvJcvHyg84N2T1V6GDDXjPVwbCsin820/XhipoegbnDs1EA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jan 11, 2023 at 07:05:29PM -0800, John Hubbard wrote: > > +++ b/mm/page_alloc.c > > @@ -775,11 +775,13 @@ void free_compound_page(struct page *page) > > static void prep_compound_head(struct page *page, unsigned int order) > > { > > + struct folio *folio = (struct folio *)page; > > Casting, eh? I wonder if prep_compound_head() should just take a folio? > There are only a few callers of that. Yes, I think both of these functions should take a folio. They're both static, so I was delaying that for later. At some point this year, I intend to convert all of page_alloc.c away from using pages, but it's not high on my todo list just yet.