From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C52BC4167B for ; Tue, 27 Dec 2022 18:15:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5DC448E0002; Tue, 27 Dec 2022 13:15:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 58C928E0001; Tue, 27 Dec 2022 13:15:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 47B368E0002; Tue, 27 Dec 2022 13:15:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 37E408E0001 for ; Tue, 27 Dec 2022 13:15:10 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 1252EC03D0 for ; Tue, 27 Dec 2022 18:15:10 +0000 (UTC) X-FDA: 80288887980.18.8983D97 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf26.hostedemail.com (Postfix) with ESMTP id AE05E140014 for ; Tue, 27 Dec 2022 18:15:06 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=BehAW4tN; spf=none (imf26.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672164908; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jTX+e2bHnTWVg1lIt3/StkB7a4hRyyJe5D+VdzEszUM=; b=7LuJUkGmfDfutz9pN1ZfFHIh17dfP1lfOKMDeEZ/IU2gQc8YbLYm1xtc1I4oxsocFl3pTE aL2n+zNtKgJ2AnwC4EKUe5v3mx4c/XWMXWkxWKBzVloiht0opXcg6DOhTCE8NGrM2W4bnN aFULVFrZNdt0ai/S4AihZhH1ZqCocgU= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=BehAW4tN; spf=none (imf26.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672164908; a=rsa-sha256; cv=none; b=QQfgRuTcKt2GuBBx1+aV9PIr9MtUfnV7ow3g9PGPD/HZNhf88BQ+/oUWawku8s+1koFysN KSR+FnnLRDOFmfbjtNcQW2/HPbXTnWAlQhuDpf+6Tu+3SIOBz9EaFwN5rTtpScIQ8rnhpw i/g14QQnnzS0YecrDVNx6vCROhe+4Zw= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=jTX+e2bHnTWVg1lIt3/StkB7a4hRyyJe5D+VdzEszUM=; b=BehAW4tNChWqBE7akCDh7QWsLr jW2Lo6FLtVBlv0UrzRHvV2g/WQ5wo0k/GnlnUlGHbPBA/eSAdh7jEeOvcGDhTXprlAsokfo2BGWeu zvb3felpXEWRknvmy3sVkMka9rw8MHeMPyto3GXdOR0xMJArnWb2ABRKzomFDJ3bKpLXJd09YoDCB 5GCoFt5Yki5ZEQoPRr2zz03ukle5ScTRFSYyP8dRVbaAMmb0L8nNbBGMWXVI3c9iqa9/zNoTgJmAz NJ1NfDHReHsQdv5el7zBESHpc8ajeAHBjiWlBwRzXoc0aCPMqpK538rAQIFax6HlVpyPXhHxlE4AO m2KIM55A==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pAETV-008CqJ-0f; Tue, 27 Dec 2022 18:14:53 +0000 Date: Tue, 27 Dec 2022 18:14:52 +0000 From: Matthew Wilcox To: Kefeng Wang Cc: Andrew Morton , SeongJae Park , damon@lists.linux.dev, linux-mm@kvack.org, vishal.moola@gmail.com, david@redhat.com Subject: Re: [PATCH -next v2 1/7] mm: page_idle: Convert page idle to use folios Message-ID: References: <20221227122714.161224-1-wangkefeng.wang@huawei.com> <20221227122714.161224-2-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221227122714.161224-2-wangkefeng.wang@huawei.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: AE05E140014 X-Rspam-User: X-Stat-Signature: pqidmsyn9dukwqgz9imnfpehjhg3p1ri X-HE-Tag: 1672164906-265380 X-HE-Meta: U2FsdGVkX18IbIYmpJ7y0M4qkqKXaaI48/IIGJzR/b+qqILRZI8QiZBrGRXRXIwdWYRn26LjHNqrKj7PQSMDvn3WcCJLQ/oROOOwBcCUSl6q2crYOw0+UUvF9adIGChZaoip+gntY+Ki2ZDl0Zp8w0tmFpmwwKxnzFWVUSe2Zunrq3zL/ZqUiXWoBdo9BE+9IBms6lCO79hixfqqh8rG955zJCoUKdRJEwq5Hakkz2xY3HfR0YsO0IYT8NgvgUGBDLadA9oDCk61eDwvlDwOgEkizP2XYj34bO8DI0u1DJ4RLUwEpJwcmBFX58MAF9ztQOCOz+ZltbtHSAXQYkD/y+xSeYz0bY8hnin39Xydy/mQBF2Q3Ni8cAzBViQDvMYQmq4Sd0pRr09dpiqQ8C4ilNgLjx0882KQsQW9mrSjNB8f8QC/n5xCEolZRYciREpo85TIzTtoRMMUYS9WM8sNKgCZx9zPrCCI3u1qt2rhF2Xx4D9HPkeEd8OTT5XxgPZTwFe2bcz/wRSeh2G7f3ZQj8mRUD0NesMNi2BjyyJNuLQJLEa9+5cfVEXHj+U8ER64ZiM9s5IEfiHy+FTcb7GyhJEEcA2/NfPhcBKVXYnlWbUFh07VL+sfBXaeHOCZsW+pKNDD0GJUvadCJW78ySUhJPWsauO7ft3rKozDFZIuevhw0UScXnWpV+59DyKeute2aneS96EQj3I7DE2Tn0a5bgLnAA7SkD5W19YTo7cpjgdoVNy26TUXZFGswVAvMT0CogyYuYOjrbaaSgkC1TedTOXxWuZliL4MmSxbA3XLJ80eYvafQg6FVqUuF1PaUW+J//RUEvUc+KbF8S04yrrrioEpC3xoHyMqWESsktDgEfAnpa4EYXfxI8dpq5wTS1hEkzARwXGuUdT/4S1xvRnh8fuqk/JkORYcEhAOvvzTBE2s1wgByzoJJomr6iQ0L2tpxQjI7QgvUgb5avonV92 f4Ufer/O xI1HV X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Dec 27, 2022 at 08:27:08PM +0800, Kefeng Wang wrote: > -static struct page *page_idle_get_page(unsigned long pfn) > +static struct folio *page_idle_get_folio(unsigned long pfn) > { > struct page *page = pfn_to_online_page(pfn); > + struct folio *folio; > > - if (!page || !PageLRU(page) || > - !get_page_unless_zero(page)) > + if (!page || !PageLRU(page) || !get_page_unless_zero(page)) > return NULL; Mmmm, no. PageLRU hides a compound_head() call. Try doing this instead: if (!page || PageTail(page)) return NULL; folio = page_folio(page); if (!folio_test_lru(folio) || !folio_try_get(folio)) return NULL; if (page_folio(page) != folio || !folio_test_lru(folio)) { folio_put(folio); folio = NULL; } return NULL;