From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D15CC3DA79 for ; Mon, 26 Dec 2022 12:23:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B456B900003; Mon, 26 Dec 2022 07:23:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AF494900002; Mon, 26 Dec 2022 07:23:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9BE12900003; Mon, 26 Dec 2022 07:23:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8C5EF900002 for ; Mon, 26 Dec 2022 07:23:40 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 5CDAD1A078B for ; Mon, 26 Dec 2022 12:23:40 +0000 (UTC) X-FDA: 80284373400.28.052EAF2 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by imf23.hostedemail.com (Postfix) with ESMTP id 580F414000D for ; Mon, 26 Dec 2022 12:23:31 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=temperror ("DNS error when getting key") header.d=alien8.de header.s=dkim header.b=Ljgg27pQ; dmarc=temperror reason="server fail" header.from=alien8.de (policy=temperror); spf=temperror (imf23.hostedemail.com: error in processing during lookup of bp@alien8.de: DNS error) smtp.mailfrom=bp@alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672057419; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hBp5bHSS6qXt/3eCZXTo0SXs4q3yzRvVOij9NcLj8MM=; b=Px6RPX0yFK+6D3OUskMsJIrOkNDA2P9W3sZng4aq5t4fs6zEEzbhhYn3TpUM7l462yHFTq 6BWwh0bcYtKHmgHL1MrhPkgyLMkaxSj0ru/g35GOZmLnFpR9baQGafgEgLgsbSxYOOUAnB AH9lqhrQqczPvIa3Ui8oTQfWYsuKgEw= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=temperror ("DNS error when getting key") header.d=alien8.de header.s=dkim header.b=Ljgg27pQ; dmarc=temperror reason="server fail" header.from=alien8.de (policy=temperror); spf=temperror (imf23.hostedemail.com: error in processing during lookup of bp@alien8.de: DNS error) smtp.mailfrom=bp@alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672057419; a=rsa-sha256; cv=none; b=Q0S+h6d7TqLmgBKtDG7KtOG3HyVH3D4EJb9sdGAlLeqfxNEE4IIedPjdpj+KncH7dDoK62 TjcaVzUZUSltW3VhPfuXJXP5Y9b0DrT/OF88xo7H7g5aymqLqOe4GLYitPpp21iArofd+4 1HduWSBSf+J86E4vRPnwQy93Rj4gyLw= Received: from zn.tnic (p5de8e9fe.dip0.t-ipconnect.de [93.232.233.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id F05AB1EC0513; Mon, 26 Dec 2022 13:23:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1672057403; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=hBp5bHSS6qXt/3eCZXTo0SXs4q3yzRvVOij9NcLj8MM=; b=Ljgg27pQVzHoyZox2bnY6q/q0vcKA8cS9hRe7S3euZ60uy7/B+gwxpFih23Ch0EIT0K4r9 e5SyxmcoKkbR5zKJSq22YMcuvIZW9DXlrOs0zoV0CONlVtxuMiqcf1xvOXcsYP1vmy6HKp m7i8DDzZ4r8SAwru3h+CMaE2scWnlaA= Date: Mon, 26 Dec 2022 13:23:18 +0100 From: Borislav Petkov To: "Kirill A. Shutemov" Cc: Andy Lutomirski , Sean Christopherson , Andrew Morton , Joerg Roedel , Ard Biesheuvel , Andi Kleen , Kuppuswamy Sathyanarayanan , David Rientjes , Vlastimil Babka , Tom Lendacky , Thomas Gleixner , Peter Zijlstra , Paolo Bonzini , Ingo Molnar , Dario Faggioli , Dave Hansen , Mike Rapoport , David Hildenbrand , Mel Gorman , marcelo.cerri@canonical.com, tim.gardner@canonical.com, khalid.elmously@canonical.com, philip.cox@canonical.com, aarcange@redhat.com, peterx@redhat.com, x86@kernel.org, linux-mm@kvack.org, linux-coco@lists.linux.dev, linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, Mike Rapoport Subject: Re: [PATCHv8 02/14] mm: Add support for unaccepted memory Message-ID: References: <20221207014933.8435-1-kirill.shutemov@linux.intel.com> <20221207014933.8435-3-kirill.shutemov@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20221207014933.8435-3-kirill.shutemov@linux.intel.com> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 580F414000D X-Stat-Signature: ey6566e35yqo78gmsp93pkroro9j9q3y X-HE-Tag: 1672057411-287320 X-HE-Meta: U2FsdGVkX18mofMklpaqE11TgcWUno+9hQG8u79qV2l3swST4DF6uT77J6VGzutiYTjlhQCyIKDrNGB4Kc9cByjY4NjwNuGJ9rAO/GTtYCpgr+aBUKkCK3x4fFEvTkwV8u2l6bjqJtGTMD4F9RnNs8POerHFNNwCNhtVEb8xNl7Dx/vu3BNWaSozFBXLApmxvQRPg88KuQBvtbYgLHID25RsQJ/VY33e23YjcUd6tyDBgf0N5mDo7qVI6jrDj4S2lMIVG8TfmlO5GhmCogVgTmK8VmlYE2XsXDcp1xJxsEunDMQ+vUlwUdlIehbw/ebSaEFRBpI3EjgwT7FIaYn8nohBtIxHDTL+fZtwCV9X9IGYt3UVtPAtLG1+Lztd03k0IhDQxUyNiFHQEohwguG+oCIAmEYd71ssZyJ2lm17Jv2gCr4GlmXm29U4kLuzDZ+imh0h5trn9oPoBz988gcnuHnHVvLBcEtb0BoTrwfGnbdxG2a6FF79zN3cQ+hMEksfDYXg+JGsSTzp8A3VFdELSW3fOaHV1Mb9sfYbBQDZTKc1+Q83QfzgOj7LkkfFsMfTaXijkDi0OtLg9AMTgRmvK3droaJTRUyrXqsXWXps+fpkjdC/ImKv/wylVM7omKcMwtjFM2NaMXo0eNTF7hdQapuwxA/1K7sLd1WdrXrEDkFyiu4Pv0cw/mpYOznVs8zI/FSYhg24B+ppcBK0gLkSgFSsXm3CT5TrDfN7jPjbJmlyoaBN82gkJEZoUtb1+iRc4kV68c/Dcgrcd8+fmhPuxE9/jSCKuyEsVp2I/c/5Mkth2H/ozirTy4m0m6vNIsuFEMxOTl+HDGycfBNi1VlpJXWyIkr/HIQl/CvuPzCFLSptHk9QQ77ZmVUXCK1VOLzzq8U7O+p4+qUCwobJ7Wit8LAf2C/oYQ/VUpEEZ33FmQjxr/RkmWJGfXnNtyX+RmKKso4cHa80/JQkX+CH3W7 mB9+xQ/5 PsrzIV4aa8BoxYljUbiA89Dcy/r4N3bK98IWtKpmcSqe7YJI2zBdrZRrGeHbuUaioGRSfdzbqDg5Ulay0272Xtb0CbA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Dec 07, 2022 at 04:49:21AM +0300, Kirill A. Shutemov wrote: > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 6e60657875d3..6d597e833a73 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -450,6 +450,11 @@ EXPORT_SYMBOL(nr_online_nodes); > > int page_group_by_mobility_disabled __read_mostly; > > +#ifdef CONFIG_UNACCEPTED_MEMORY > +/* Counts number of zones with unaccepted pages. */ > +static DEFINE_STATIC_KEY_FALSE(unaccepted_pages); Then call it what it is: static DEFINE_STATIC_KEY_FALSE(zones_with_unaccepted_pages); so that when reading the code it is self-describing: if (!static_branch_unlikely(&zones_with_unaccepted_pages)) return false; -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette