From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83AA4C4332F for ; Mon, 26 Dec 2022 08:15:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A2A37900003; Mon, 26 Dec 2022 03:15:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9DA31900002; Mon, 26 Dec 2022 03:15:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8A199900003; Mon, 26 Dec 2022 03:15:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 7651E900002 for ; Mon, 26 Dec 2022 03:15:33 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 49E7380603 for ; Mon, 26 Dec 2022 08:15:33 +0000 (UTC) X-FDA: 80283748146.07.35D0A0E Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf13.hostedemail.com (Postfix) with ESMTP id 4FC8F20007 for ; Mon, 26 Dec 2022 08:15:30 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ZQdPMoDX; spf=none (imf13.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672042531; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KEzaiQEjAdz4nbUPM7Aak00E/TFfUXezSTFVBGEzDzc=; b=mbyKtzbpi3z0wexerO+wQTgmfvgRzWyEqRdydfBY8nQ22GEoSDTZ4sTOs0UPs9Y6ENwBmz myGEpGvAe0I/Nedbxx8Dy13b/M+UPQVoLd1YT1+2EBBuu2rytfVcHaUFQRdLowHJdNKL9k pPiJ5eLvrdyYa0Icvuu/OG0oLVXhR5A= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ZQdPMoDX; spf=none (imf13.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672042531; a=rsa-sha256; cv=none; b=mFuo/3BjFvrakVsq4DCiS4mlRIhE7WM8VAuW2PXOag0FitIJOH6lDelK0MriddKDE+ITie twhrJQf7Hg7WlS5EiNb1UwcJTcnjT6YGQMQpiHQemtsbcMbxAm34j3vIShPkckZeiPNbfX vDyekER5e/xKFzBl1YCtZAzksylFOqA= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=KEzaiQEjAdz4nbUPM7Aak00E/TFfUXezSTFVBGEzDzc=; b=ZQdPMoDX0iZzTwb+WbGZ/SoFGd 5TA6PBrL14a5Ga68dPnk9oP2lfgAhokIj+G9gCcY6i1ObwRr8k6AZK2uYuDpPVSjpedKXDhNFJWuE IgbI+FVvfg5JcuniWiWsgK+mrmgVKXOlkFR1kN7A3uDbNQaU1aqEuyfl3FNRQwuCVEjSwRpau99Xm ++UpHd8gJ0RLy0v6lOZvHPVnfeF3fCiXSM7NxgxQUsh6hfhppUGHmqoTm+dtyJcNXpAJ7ioDDAyDZ o/mIKjm4G99PkME/K1NPfjBj+pOXX5PO9dd8em3GGpLbHhEdX0u7aJ73rprTJP5XvuJPlo7W6JRn7 Ml3XiduQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1p9idt-006WMo-RH; Mon, 26 Dec 2022 08:15:29 +0000 Date: Mon, 26 Dec 2022 08:15:29 +0000 From: Matthew Wilcox To: Lorenzo Stoakes Cc: linux-mm@kvack.org, Andrew Morton , linux-kernel@vger.kernel.org, Hugh Dickins , Vlastimil Babka , Liam Howlett , William Kucharski , Christian Brauner , Jonathan Corbet , Mike Rapoport , Joel Fernandes Subject: Re: [PATCH v2 3/4] mm: mlock: update the interface to use folios Message-ID: References: <555c36b91c4b34a5972f2614395e3c3831e8102f.1672038314.git.lstoakes@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <555c36b91c4b34a5972f2614395e3c3831e8102f.1672038314.git.lstoakes@gmail.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 4FC8F20007 X-Rspam-User: X-Stat-Signature: qjgam8qky1kytoyf8f63616ur4szf4tc X-HE-Tag: 1672042530-759415 X-HE-Meta: U2FsdGVkX1/cLDj77dvstDQSg+X6w2ySmpoIahWz3gcDuMTMngNjWKMUUyg4aACi1/T4qfEvL8VZavDOkMXrjy3DohtFw15PaqQZwvbQcCyrnSMDpvVT+lJZ8wNjp1tImTfNDGTbEHpw+46rqBkEyvdfYcz1ZVVm9q5W7Q/XbPcYzXDXeejAK9w+o8tkyoI7bb6FhPaszvdIemT7ibPSQUPFndnaORUO1ge0ZZ4BWPz7QGcJTFMmP1zAquLSmsyt+KEyIvkGbpSrHx+4rCtDJFy9AbIC5mnfaXobI3IUh6fJrUqfZTLzg5B7Sm5ZQazkq1sKg9RxLNgLRK6JNE+LBHv8Dp9j2Uk5uooFTX0Frmf2OGyzvRiPtgr1b2WCdqrGKNdlXe3u2o8hJfnu0AP+jyGfSLIcrKmZOhcW8eU+LknhCfaEN9RAgYutOejUSZNbAWqWpGOAee7d8fj0vjXLXkVaYJlUgWrJOMW9YBUV9DxrHjloKvU2OgAktv360rLxekPHCyVI2NYF905sQXHa6T0IYwFLbCvfwNOqCEIM4ThMvbouAIAonZkrSUAVtouPGFIjzwHRPqGcU9c9XdchNF60mhVgmYvjCba/O7ILTA/lHENpo/BKyGI9Au3lRtNjvtelamczYaJqCxrRLFSsZDI5FkpGU/mJIfOD82XA1/KxFS56ULhPWY6aH36U0fdf98RRbbpBhyoLZS6q7MjKN/4lIcTamKJUY4EYuQ6B/lhvCCXAOybrg9jjwdaokpNg0p7irLXSw+K+8crX4Hbgo/Pvkk/2GgfvvGLJpWsYVrn/bnIRQHOXz12rFeHJfdSJdWEM3v4xWaVIvgVmTL6dWinQHbduC4ECsDO1QeRXsEU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Dec 26, 2022 at 07:08:46AM +0000, Lorenzo Stoakes wrote: > goto out; > - page = pmd_page(*pmd); > + folio = page_folio((struct page *)pmd_page(*pmd)); I do not like this fix. Better to fix m68k to: #define pmd_page(pmd) (struct page *)NULL