From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCDA1C4332F for ; Mon, 26 Dec 2022 08:19:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2AEC6900003; Mon, 26 Dec 2022 03:19:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 25D43900002; Mon, 26 Dec 2022 03:19:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 12557900003; Mon, 26 Dec 2022 03:19:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 034FB900002 for ; Mon, 26 Dec 2022 03:19:10 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id CB17540609 for ; Mon, 26 Dec 2022 08:19:09 +0000 (UTC) X-FDA: 80283757218.03.88F862E Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) by imf12.hostedemail.com (Postfix) with ESMTP id 2CB5E40004 for ; Mon, 26 Dec 2022 08:19:07 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=QAZAofIX; spf=pass (imf12.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.128.44 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672042748; a=rsa-sha256; cv=none; b=ppLroOWe+/dito7RfykkFK/psllDizYxz9fn56wbyLUzzT3bct4860uSYmkHJiciOgLPZN ouZ7L3aaot0V0TsVop6uTRYd+VZJQy5bfTQJJTEV6YxXoF923vy+IlFCM9wgqPFfMTjZt2 Bkzn/0PWhlGKWRVy70zyljSyGACmqpw= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=QAZAofIX; spf=pass (imf12.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.128.44 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672042748; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=g4eGuO+JRo1jyO7gXeRlpcOp8BRbSkAn9HLImegppvE=; b=kdHF3lFawBxgQDJdETUpRKR3i7A3tVaCxClWlA1ZtmYILEfZYXJAdkiI/nRiuTQSCKA8xn 7lq2rtPOBi8xlHDOgsoyuJ402Qdu5RrVGCVJ3+FBIqOjhYn1rHj67UHLns7cYQXPLb889s Js/WUuT+nCh3Nx/dykEeNlNHdkIlAYM= Received: by mail-wm1-f44.google.com with SMTP id bg10so7212646wmb.1 for ; Mon, 26 Dec 2022 00:19:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=g4eGuO+JRo1jyO7gXeRlpcOp8BRbSkAn9HLImegppvE=; b=QAZAofIXfl8YMBQGrTtYNMukjhISYq8OwCMGDZ5c4DUGIPrH7iio874KhxqOXNkeQ5 Uc7soXSSM0JYWyKbUX/7/vVGEYCw2RtjeVzuyqFfQqCrVeOgcLjj7JquGBQ+UCupS0Fg 9K5hZgd9a5qWxwgDqnOEnuRmYfhsVD7woQTEhQ39qRLVFe/OuG9HaE/JE2WjwuRLkNUq 4gqkmt4M9Pa0PsmoS66DaXWmYzfzXzG/XCEMJQLE87FP/txq25P4Gz1pZAuhD0OMcEF4 xB2GCNpuN12mIsiyBgy2K2gDD9Hbdy0MD5kgRCjH5s18gdkPHCEzqcIHee4GUuN7W7AC jBVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=g4eGuO+JRo1jyO7gXeRlpcOp8BRbSkAn9HLImegppvE=; b=R9kh5vsmSs3q9ydY0c/A2vmmNLVxLsOCJesaGWaFEGUg9F0xnciPaw7GaBZoOCUtsa JR2KA1R17lJS86/ANVjUh6MLQ2QsSRkoP2WexK005BMisl4weYcZGmhySPUKII+0yHBW eDXiqwG/YDnk0MhVyhFA6DbRUaPtSO10d1Gg9kEZV+dy3Nq4tBjcDjpZs9CnhIAb0Luu RS5NMO/uQCI7E1TZeN9phDWZ8IuukUU9U6WWPvzcd6Kb8lLEzNRBuoC49MVjmDTBYwXp dFeQi9qcHtVpy6tPGWcVTEau2/bEl+e7cJ0LvR9BdaPjNJSHXlQ2zfLXFth45QYJF+WJ awdA== X-Gm-Message-State: AFqh2kqUfr/4aPvP9imuLANYlL5fKNI3xdEfL5vultUAUfww+X/Hn4g/ t3B03s0VqL0zPhDOnYpltZ8= X-Google-Smtp-Source: AMrXdXsU5qtRgYezUKj3b32U+swfASWrOPQPwrQ6dV2/URG8Pp3iaHdVRPCFf2KF6MCv8gv5ETD9aA== X-Received: by 2002:a05:600c:35d1:b0:3d3:58d1:2588 with SMTP id r17-20020a05600c35d100b003d358d12588mr12609788wmq.41.1672042746607; Mon, 26 Dec 2022 00:19:06 -0800 (PST) Received: from localhost ([2a00:23c5:dc8c:8701:1663:9a35:5a7b:1d76]) by smtp.gmail.com with ESMTPSA id x15-20020a1c7c0f000000b003c6bbe910fdsm22632255wmc.9.2022.12.26.00.19.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Dec 2022 00:19:05 -0800 (PST) Date: Mon, 26 Dec 2022 08:19:05 +0000 From: Lorenzo Stoakes To: Matthew Wilcox Cc: linux-mm@kvack.org, Andrew Morton , linux-kernel@vger.kernel.org, Hugh Dickins , Vlastimil Babka , Liam Howlett , William Kucharski , Christian Brauner , Jonathan Corbet , Mike Rapoport , Joel Fernandes Subject: Re: [PATCH v2 3/4] mm: mlock: update the interface to use folios Message-ID: References: <555c36b91c4b34a5972f2614395e3c3831e8102f.1672038314.git.lstoakes@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 2CB5E40004 X-Stat-Signature: de7rx71tsb3qwfhauwxpna5cez5wnusw X-HE-Tag: 1672042747-301449 X-HE-Meta: U2FsdGVkX1+EIDffMD2cW9wZpMEtaqRMNYbohnNKnB7s47QSWvF6btHUOYcvG9eDFkJF6Yxs8IPoSTLqssLVYndrU2pAFYMt8zvbcF7I9vhkHSaITc2D3rwRfaDUou/GgBu8BVIo2ijpyMDClnVvOhStJw34m/tafHNvexUX5ZNF1oRRHoycKZpNJT6qVZ6XmALT46BySD2Boq/MyEhjgABMIaGe0+xB2GCY1pPzXmpLOOgfqhb7Q5OdJnGPsDFzSgPFF1cH3Q2PBl8umHdJ4QwXJgoK3AwY+JtOuCas/2OxrIB/Y47Sa/m34tU1AeIIGwI75i7KXUxYJpg6xVMLDv/xNRafCQAOE7NUfDPGiW2CYI7F2n+gqEEDZMw4SDUzPc2J9G2gwKCLvwDo2tNxJvmBrWmAUJ9CbUA8AMv55gWmufQ3nQAE1/NNgx2XnSmb2ayWi9IA0cCfTHnvt+rXZnqAm+uOijbp3HV3cYIHzIvH7nCR5Mzm6m0VQ3Owoo1OPYqpaLNLXkiXSPvoWQUVMkac6YDEpQfGf3YeGvsg7DAPqWojsqt6UxIHk0zFOp0JLVnxaD4ovhDj0o6co4ADTiCeRTvgfosGZkePE27T81Ie8w6wznu2tDL+YxyMFun8F3TfOJrD6U7QsWWKDFLu5odHDKHctKJaqzmOLY+DWYNLInUM22Ov7zkQcpzDf9XN5bjeLLgnrruWuKEV4bEhWJqZaWwE4SgAmoIIIHrq4hqCB0EICWUFhtlcXXwgN5BuiF3yBJz6uKgF44lFaeR7Iayl19euRdE1/flsFntJjl2KuWgeVd3uvLwfJFgQtCOeSwv2u8N1Kz90TbCeXR91NyTenvwlda0dKRKN1R0ETc4IOdjmmX/xmmichaQLzrru2N+RI4guGqRKZF8ONZtsKTiddx8er5pCHzFALE5vZ8JqjZ/S8QBf283XIksp4D4DWCAA9rkbtSUwRe43icj mdT6BHvT rwXuQNFwVljuYX5RDz/LPNuCGAliNip2hNME9nLzDsfktXWrSWepNCONTt9JeDRMAOCq9tHnK7FwGpj9sZ9544kzhCQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Dec 26, 2022 at 08:15:29AM +0000, Matthew Wilcox wrote: > On Mon, Dec 26, 2022 at 07:08:46AM +0000, Lorenzo Stoakes wrote: > > goto out; > > - page = pmd_page(*pmd); > > + folio = page_folio((struct page *)pmd_page(*pmd)); > > I do not like this fix. Better to fix m68k to: > > #define pmd_page(pmd) (struct page *)NULL > I actually completely agree with this, and felt it was essentially an issue with the fact m68k aren't doing this cast, but I thought perhaps it'd be out of scope for this series to make the change there. However now you're suggesting the same thing it seems like it isn't out of scope at all :) Will spin a v3 moving the fix there.