From: Lorenzo Stoakes <lstoakes@gmail.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, Hugh Dickins <hughd@google.com>,
Vlastimil Babka <vbabka@suse.cz>,
Liam Howlett <liam.howlett@oracle.com>,
William Kucharski <william.kucharski@oracle.com>,
Christian Brauner <brauner@kernel.org>,
Jonathan Corbet <corbet@lwn.net>, Mike Rapoport <rppt@kernel.org>,
Joel Fernandes <joel@joelfernandes.org>
Subject: Re: [PATCH v2 3/4] mm: mlock: update the interface to use folios
Date: Mon, 26 Dec 2022 08:19:05 +0000 [thread overview]
Message-ID: <Y6lY+RB/LXY6V5tH@lucifer> (raw)
In-Reply-To: <Y6lYIfVAf+EZa/Lb@casper.infradead.org>
On Mon, Dec 26, 2022 at 08:15:29AM +0000, Matthew Wilcox wrote:
> On Mon, Dec 26, 2022 at 07:08:46AM +0000, Lorenzo Stoakes wrote:
> > goto out;
> > - page = pmd_page(*pmd);
> > + folio = page_folio((struct page *)pmd_page(*pmd));
>
> I do not like this fix. Better to fix m68k to:
>
> #define pmd_page(pmd) (struct page *)NULL
>
I actually completely agree with this, and felt it was essentially an issue with
the fact m68k aren't doing this cast, but I thought perhaps it'd be out of scope
for this series to make the change there.
However now you're suggesting the same thing it seems like it isn't out of scope
at all :)
Will spin a v3 moving the fix there.
next prev parent reply other threads:[~2022-12-26 8:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-26 7:08 [PATCH v2 0/4] update mlock " Lorenzo Stoakes
2022-12-26 7:08 ` [PATCH v2 1/4] mm: pagevec: add folio_batch_reinit() Lorenzo Stoakes
2022-12-26 7:08 ` [PATCH v2 2/4] mm: mlock: use folios and a folio batch internally Lorenzo Stoakes
2022-12-26 7:08 ` [PATCH v2 3/4] mm: mlock: update the interface to use folios Lorenzo Stoakes
2022-12-26 8:15 ` Matthew Wilcox
2022-12-26 8:19 ` Lorenzo Stoakes [this message]
2022-12-26 7:08 ` [PATCH v2 4/4] Documentation/mm: Update references to __m[un]lock_page() to *_folio() Lorenzo Stoakes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y6lY+RB/LXY6V5tH@lucifer \
--to=lstoakes@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=corbet@lwn.net \
--cc=hughd@google.com \
--cc=joel@joelfernandes.org \
--cc=liam.howlett@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rppt@kernel.org \
--cc=vbabka@suse.cz \
--cc=william.kucharski@oracle.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox