From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 301F1C4332F for ; Fri, 23 Dec 2022 17:15:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6BEFD900004; Fri, 23 Dec 2022 12:15:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 66E79900002; Fri, 23 Dec 2022 12:15:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 55D3B900004; Fri, 23 Dec 2022 12:15:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 4A625900002 for ; Fri, 23 Dec 2022 12:15:30 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 1D5001C622B for ; Fri, 23 Dec 2022 17:15:30 +0000 (UTC) X-FDA: 80274222420.09.1DD38FD Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf17.hostedemail.com (Postfix) with ESMTP id C7FCA4001C for ; Fri, 23 Dec 2022 17:15:27 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="G7X/ycTh"; spf=none (imf17.hostedemail.com: domain of BATV+a36cbb7ae26730e9169d+7061+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+a36cbb7ae26730e9169d+7061+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671815728; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0cZ0mt91TyzNw0HU5DsG1MlYLdTdSBQN+CWQAWeWbAs=; b=274pZqqDhVko2izl2sMlPJYnVO4T4EUdswgVifzC+GSq5aatm+jrXFSvh/zYmv/5fqQ9hA 4pLlJWyzNuQBCqUUq/fJtebhkM5oPDp1mm/SGhC625MF18wFjiz4OqvlXH+6IQuoUie+H7 8WJYYDFPMFu2KUpmo0av7nYsaW+RZ4Y= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="G7X/ycTh"; spf=none (imf17.hostedemail.com: domain of BATV+a36cbb7ae26730e9169d+7061+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+a36cbb7ae26730e9169d+7061+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671815728; a=rsa-sha256; cv=none; b=FwjHugoxMhabDcSULIXIjTFrLFNCgkCFCW1ekCHheOPzGRXHdnhAZHhvMynRo95yB+0Igo wirsFUnuAHwPl9Z/9EDmOtTKRRZ0p3dJzYl51qUaxMmzTEMUSY/Y/ZomBjeRSs+6eX2TN6 1V3cQO1ZlvDtKXnFu6/MVEWKN6kmALc= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=0cZ0mt91TyzNw0HU5DsG1MlYLdTdSBQN+CWQAWeWbAs=; b=G7X/ycThvePMUp6sX4GXGyf4gf laY9P5zoVQeWo7ULj06Z+TUMqp6dPpstZMJeTHWhP2EsHJE6FJNO+O2+RT0249LNp6jBi+H/+A6Wk d47u3JR71cla1iYa0R0mdrcPXBLIlF7RSA8PGgadPrI9kOsdwMs2VXv7t4NfZNYiKdta3WuBhckiI CSKzzo4A9ymV6Tmzyo+UHKRl7tqpQllT/s0mJA9lmSMhkVrAErZI0qqi+Wr8/Z0nmMFhuwAeV0Zcb rrw0t7vHaWMsg3fu2BPqxi9DC65J6FO1/Jk9PR+QED1vle+v6mhbOFBsVrPseVpaI11FDaeIgSvVY rWQjRLDg==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1p8ldj-00AIpJ-NW; Fri, 23 Dec 2022 17:15:23 +0000 Date: Fri, 23 Dec 2022 09:15:23 -0800 From: Christoph Hellwig To: Tony Battersby Cc: Christoph Hellwig , Keith Busch , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Matthew Wilcox , Kernel Team , Keith Busch Subject: Re: [PATCHv2 11/11] dmapool: link blocks across pages Message-ID: References: <20221216201625.2362737-1-kbusch@meta.com> <20221216201625.2362737-12-kbusch@meta.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: C7FCA4001C X-Stat-Signature: wjahzuic1re1i8yce4eccekxgf3yngh5 X-HE-Tag: 1671815727-740388 X-HE-Meta: U2FsdGVkX18UCW/Sf2ZGFdjxdVWhLi3Jd5SY7Msa2ysR7i14dCGR1814I9Y06B2H/FMnstJJsFTm8ivnsaAzYMeQ6dtWK/ZMwZdht4HyJhg4MIGEkM7zedSmsqJpnltQa1XXtjtnYwKQyNGpuiSbJk/zpIex36EDK/p3CxO68k/sgfrDFZ8CUeel+iljLAzFUYUTu6qbMhhX7XU0BDmr98ZelWG3oZlN1KgzoY9sIfA8ZXObrfqStWYijeyU2lWJUenmmfSnfvCEAyYWzpD6B6T5yn0ARsQUor/CYxzwTJY5TMG5wcZ3cUQA4KPqXm6zgNemag6LXXdlLbF5s6bYnUgVXogKwteFaxJUWLu7fJT/R54C1F1TpMgBJhdT7yoUHY1Dg/dJ/dZbDxzmBKkr5ljSNnuApkYqogn+VfQiftsEIw8NWIJBbuPpeMtzw7qWalUoOI0lnMIyC5wzI+guRRds19k8c6I/c+aOzFCTwlE8YjWUIMMdJKfl/yP7/b0fdSlrsmRC/1cVgqB33tM3Djvs5HWOG6JmnKkazp08/cL6HtdhR6Wi3UKJOi6ofsCbh/eVWGb2R2kGp1tStFzN86JSii2eaAe9X9l4P+yruNh4saN3c46JMxSJz6duwyws4cVuRuphU9m6nawkxpBu4pVGFcPawJFkYU2+QBtqQvCapLwQWY52tM83BIL+MEvlTM2laS9lGYHd1LkEITW+M3fEQNZZ2vTwuLHVCYQW4RIW/vKgZp2aj3ibAuFzGF2BkoPqwQkMGS8QvNrdI942AS3gOff1n6yJGZS6ErSg1CQxcOR/D+67CrtZ6C3SXUTpshvSRv2LEPJquVG87igw9G6SelGwEVXKsoFrMKOMLK0kYlGtJmVfSsnJ9cJMgnHYkupyjiBbPkSY3iP93xOQtSFDwjjgqZxlC8MktI+dLSuTxOl4qaRODfd9mnkrPD8Pf+edb+4a4/v4KPEwz3v gWi7aXpN 6CllAOm6Lz+ObPI5QP8WU6K/i6uOQmGZkGQef5/kiRu9+t8DoTEdUFxV4WYyBljk6lOZ+ZFzPdWipU1NRn5x0LQn+47lyhxE9DFeVTPmMMIcBUQanTVQTBTvPRpm14sBJEWzU X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Dec 23, 2022 at 12:08:54PM -0500, Tony Battersby wrote: > I previously recommended that they should be size_t because they are > counting the number of objects in the entire pool, which can be greater > than 2^32.   See patch 4 "dmapool: cleanup integer types". Oh, ok. >   However the > kernel test robot has complained that some of the printk format > specifiers need to be changed to match the size_t type. Yes, they do.