From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4A0AC4332F for ; Fri, 23 Dec 2022 16:58:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4332E940007; Fri, 23 Dec 2022 11:58:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3BC53900002; Fri, 23 Dec 2022 11:58:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2840F940007; Fri, 23 Dec 2022 11:58:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 152BA900002 for ; Fri, 23 Dec 2022 11:58:22 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id AC88A120907 for ; Fri, 23 Dec 2022 16:58:21 +0000 (UTC) X-FDA: 80274179202.19.B6CCCD2 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf10.hostedemail.com (Postfix) with ESMTP id 27AAAC0018 for ; Fri, 23 Dec 2022 16:58:18 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=eTVnoJr3; spf=none (imf10.hostedemail.com: domain of BATV+a36cbb7ae26730e9169d+7061+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+a36cbb7ae26730e9169d+7061+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671814700; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=n3ckuVjd+kf/Enh4S8aX3LjBb7aTur9Q4f8tyMM3MaY=; b=CokZfEoznQ/MCIE8cOYkC7YZArosfaFnjO8tZbqiz1Lrz00H6u4cqFrNKXUeuj5swIVM4k QqpL/mMCKUD7dQzVXBnGa7G82tQa0LmD6aYdb0Tw6x4+8C5ZUkWxvwMOmf/kto7IfK2abj 9rAqZFPLzI6ouxzR6S/ddeI7uh4uRXo= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=eTVnoJr3; spf=none (imf10.hostedemail.com: domain of BATV+a36cbb7ae26730e9169d+7061+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+a36cbb7ae26730e9169d+7061+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671814700; a=rsa-sha256; cv=none; b=yzvS9n1KueVQwPQOcQTyD6vjzB86Hf9tjk6AiyX1DZCW9FLN0VgBMoIe6/scgrEHeJz2zk AJmiBlwSqdNpC4y7aLfByjz6QXylxP/XcsI54lcvJcbi5w0nQ98EYo8dn9yas99sJQlmHD 6zozA5JNQyDG4HbLZjRdN5XlXKLUWP8= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=n3ckuVjd+kf/Enh4S8aX3LjBb7aTur9Q4f8tyMM3MaY=; b=eTVnoJr3m7/74zcHBx2nqnM6pR vRuXjuU7ECwpnGlWDEcqYQC3lRL7UgO2IuQGPHRODtOXwEkCLQU6Dd7xDImeUksWAW1vHTZFC1CHH YPAcmcMhSHjY5MIWES2IgM1rL1G3JJqwrSDD0qvvfmzI/otKMqTykzeGwtyeCNy/YBPMUGUNmbT1m PdGgR1/o3hlmjre8IJpSphepYlcWcz3/A0XalD7vSdYYRrptThG9OUA90iitf5ymps2GQF2Ko5L7o 6HXKo8y2H7NXnpO4AMZAgB336Mu1wTj6i4942GjTSMr5wMtdm6HxnGZT6SzHeVDveftOxtUCZBncE b2Hi/Fag==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1p8lN9-00AAbn-KE; Fri, 23 Dec 2022 16:58:15 +0000 Date: Fri, 23 Dec 2022 08:58:15 -0800 From: Christoph Hellwig To: Keith Busch Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Matthew Wilcox , Tony Battersby , Kernel Team , Keith Busch Subject: Re: [PATCHv2 11/11] dmapool: link blocks across pages Message-ID: References: <20221216201625.2362737-1-kbusch@meta.com> <20221216201625.2362737-12-kbusch@meta.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221216201625.2362737-12-kbusch@meta.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 27AAAC0018 X-Rspam-User: X-Stat-Signature: yh4sbhp6i3gcf7e7zxwwhqb8pntwfmss X-HE-Tag: 1671814698-704251 X-HE-Meta: U2FsdGVkX18SMJf2hLIcVtJ/umRmDrVEPYrYzaBCMIiNJ24g07HPC3GS9iuBoeqslo8h/OYMF/ZjoXcCBTlKdKOWoe4yIy+yuqvip+fhWQ17Qz2byFQiTVsnLviTFrR+EhYSeXtxgCBkDv0RYQy3RZdyU9R6er71uoZAss39qUhJlzRqZu5VJ66QIpyRY6AM2EUFxV4X3wnbaAk04li4mI1QZmUFdJCGRit2/aM1s9DlrsohrwKLEbaI5uINuq6MV2YV/GfwVUVZfgh70DJ/UIlHgOlvfftv/pCOlIRxAz5VJvBf8V4n7/LCXwISz/BqUrOqSkoJiBId+L8jFTWSQnsy/vK5YXAYVlK28Lyl582uR9qFwhs/5InNKNTH/78JxVmDfayXtbOsvWPrfo+oWgDJlq+XlkkuEyktTzUf39gQWdZRd6U+R/CdInXN6tVP0IrZSQ16xpp4lZLVn/ENZtPW9v8180umUirw6VUqqg1ulunuUPCR7bxcOwZ37rSBIx8f8Cct1DZQnXWRGzc6yyNf5wa2cWkrr6CahV/wOJEr1TAlfdkT72V2pQJCP9bnZir4CuhdeliytfaZ3SV/c2/vwa8RziLnMSJ7/K06bkY5kS0JnLMQtRVfhZaIHKp2/+d5XBNqU3L7stD+/y6ISSsY2MSdgEhMyvJvjMwA4OuKO+aDDHrZ4QLdrAkIU7/0o9mDQ52/48YsT9y/KJ1vSOEWsVU3FtLqVDkK+qzKmuNIHRZj6NcJtV6U0IqsUqM/hVU0HA/2aMKeifEQNAOCLcdh4vIeDO0Zl/LsQ6vWm0uU3XKUN+n58z+muKnImiAjoWHKXvOD7o9ZKzBrnIvv2BnjBdidylp7CjG6wuOoKiPFd1IO8UeJgpILUvyTBirxFyYJQWqiGlqYsmOfsEZ+4MHHCI6GPAran7v7dQu6M5qAtUxNnBGY2zpucT2ywtd0HmOUjJllw9Rv92UTRTA PuE6A86r ac61l8uiWMB6PQEuj5pCiaiTXCsKz4PwurGXSeUDsuLAurF8jYP3zjVDYeBgjNekrofPlYlymLDEsFHWxQjSm0HZH9K2pF7ZgumTI6HYfsaWzB9J1gF0q2PB4ruBPwgqDNbR2 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Dec 16, 2022 at 12:16:25PM -0800, Keith Busch wrote: > unsigned int size; > unsigned int allocation; > unsigned int boundary; > + size_t nr_blocks; > + size_t nr_active; > + size_t nr_pages; Should these be unsigned int like the counters above? > +static inline struct dma_block *pool_block_pop(struct dma_pool *pool) > +{ > + struct dma_block *block = pool->next_block; > + > + if (block) { > + pool->next_block = block->next_block; > + pool->nr_active++; > + } > + return block; > +} > + > +static inline void pool_block_push(struct dma_pool *pool, struct dma_block *block, > + dma_addr_t dma) > +{ > + block->dma = dma; > + block->next_block = pool->next_block; > + pool->next_block = block; > +} Any point in marking these inline vs just letting the ocmpile do it's job? > @@ -162,6 +176,10 @@ struct dma_pool *dma_pool_create(const char *name, struct device *dev, > retval->size = size; > retval->boundary = boundary; > retval->allocation = allocation; > + retval->nr_blocks = 0; > + retval->nr_active = 0; > + retval->nr_pages = 0; > + retval->next_block = NULL; Maybe just switch to kzmalloc so that you don't have to bother initializing invdividual fields. It's not like dma_pool_create is called from anything near a fast path. > static void pool_initialise_page(struct dma_pool *pool, struct dma_page *page) > { > + unsigned int next_boundary = pool->boundary, offset = 0; > + struct dma_block *block; > + > + while (offset + pool->size <= pool->allocation) { > + if (offset + pool->size > next_boundary) { > + offset = next_boundary; > next_boundary += pool->boundary; > + continue; > } > + > + block = page->vaddr + offset; > + pool_block_push(pool, block, page->dma + offset); So I guess with this pool_initialise_page needs to be called under the lock anyway, but just doing it silently in the previous patch seems a bit odd. > +static inline void pool_check_block(struct dma_pool *pool, struct dma_block *block, > + gfp_t mem_flags) I didn't spot this earlier, but inline on a relatively expensive debug helper is a bit silly. Otherwise this looks like a nice improvement by using a better and simpler data structure.