From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A432BC4332F for ; Fri, 23 Dec 2022 16:43:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 46538900003; Fri, 23 Dec 2022 11:43:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3C6AB900002; Fri, 23 Dec 2022 11:43:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2B6A4900003; Fri, 23 Dec 2022 11:43:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 1B5B5900002 for ; Fri, 23 Dec 2022 11:43:54 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E2FCE160934 for ; Fri, 23 Dec 2022 16:43:53 +0000 (UTC) X-FDA: 80274142746.15.A37BB1F Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) by imf28.hostedemail.com (Postfix) with ESMTP id 133C9C000C for ; Fri, 23 Dec 2022 16:43:51 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=YDZ+QC3a; spf=pass (imf28.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.43 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671813832; a=rsa-sha256; cv=none; b=aUti5BFSMII1qx7/QHcTyaOSqa1QWwL6wP1X0tmleOYLESAcLU41kH/5mMDsN7ItqEYCYU dulcKUNovFRVBXLslRsQsR9CA0MzQQHJ/nbxmshrCF2EeIbp0i9RH2SytgSXEX4lMPImL8 +wR0gFfqE3t4x2cFs73NS/6g4+89NCc= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=YDZ+QC3a; spf=pass (imf28.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.43 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671813832; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eTitOekDuo3LDxAbgs9DMgMITmyXa1apsqpqb9tpvA4=; b=aLfGZ8EuLutIN+dWQHAB7/7fwu/sy6V0gugSt0vK8PnU7zj9IrBlJDjmbQp5Ie27wIU1YB WiNcmEVWWXCVZuF+ojJc0noil/wQsp/3jCSJ7fC3cgWsMyU1WrWW0j+nQU0lJuZa5QqxTl 5lgN4+mayA+Tu9t3F/CuVFVZTEXn05E= Received: by mail-lf1-f43.google.com with SMTP id p36so7670790lfa.12 for ; Fri, 23 Dec 2022 08:43:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=eTitOekDuo3LDxAbgs9DMgMITmyXa1apsqpqb9tpvA4=; b=YDZ+QC3ajRi287uTWq7UtytjZqIAAxgr0ZFbMut2vYqCMeL/PiRcAM7BoRDPOK4UCz 7wt5kGmny/krnwgRBlae3Qe342cpzgi9SRzaoMwzDgcgk/pPr2D/bvm4XIZTD3lHNY2m xcGW8W1N5eUFSvdyCtakM/OJzAfJxEDkpntnrchRG2X/6mzhoMA7u1KW8rRm0NkxZHxR ogLSukr3YjJA2JeiUi9D3jjOuLaseqEuqzOpJT/vHDE31A6xXC0jVq0IPmyDhU0el1Nn wlwtw3TsfLJbhjVaGotk4XUsuLd2xauS8JncQ7A/+uru4vS87YKvkZCsdMkKycLi9TkG HpjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=eTitOekDuo3LDxAbgs9DMgMITmyXa1apsqpqb9tpvA4=; b=AUlEnOYy4CFWyjNZSwSGLw7s+mGLrlhxou4TJ4vSVMHxbR9r6iRFbhtcDaN5bnqWW+ jPgFg4c3OI30k9PndnEdq/qU0HG3ZjQPIrRSJl/MywptDE+dw6x/QMrQqhrub4UvTE8r PtmFL7Ca2lCWxkOwyVNHUNYEUKqs/mHWcL6FfQ/tEf94MqmLOUQXDk/A/HiOlGW6afiu rTvt+vgqh+f2+lMS9UkIrc/Wg3xrdk1oqdyTW1cCETHjaPYB4ECZTffzQlsATlTzvUzg +oLNAxuiLwxQvjR+sBUCxJnr43oxhl3+RTMQ8iQEdrmC4+iKOHN9tRExlIk8ooadLRyo eZ/w== X-Gm-Message-State: AFqh2krU4tpdj+UJKbvfd0Gq5FnSRP3HHOcJcA3H0C4OrKPZk9rNyDfR vyS2UCpjDRCQaKTITbnqfIs= X-Google-Smtp-Source: AMrXdXsbCmOcL5tModruIP+ddl5ZOymjj797oP0QUjzCh4udJGnP0p8WNmXeyxpDkbDlWJ+fsTRpmw== X-Received: by 2002:a05:6512:2828:b0:4b9:f5e5:8fbc with SMTP id cf40-20020a056512282800b004b9f5e58fbcmr3666477lfb.30.1671813830674; Fri, 23 Dec 2022 08:43:50 -0800 (PST) Received: from pc636 (host-90-233-218-120.mobileonline.telia.com. [90.233.218.120]) by smtp.gmail.com with ESMTPSA id r9-20020a056512102900b004a05767bc07sm584203lfr.28.2022.12.23.08.43.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Dec 2022 08:43:50 -0800 (PST) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Fri, 23 Dec 2022 17:43:47 +0100 To: Christoph Hellwig Cc: "Uladzislau Rezki (Sony)" , Andrew Morton , linux-mm@kvack.org, LKML , Baoquan He , Lorenzo Stoakes , Matthew Wilcox , Nicholas Piggin , Oleksiy Avramchenko , Roman Gushchin Subject: Re: [PATCH v3 1/3] mm: vmalloc: Avoid calling __find_vmap_area() twice in __vunmap() Message-ID: References: <20221222190022.134380-1-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 133C9C000C X-Stat-Signature: jfdnpaektx4yh76hzkep7wcrgppefkj9 X-HE-Tag: 1671813831-453361 X-HE-Meta: U2FsdGVkX1/1hjrQhien7vtfBfyq0/RytrK/Qu0dCewTNYzhZYnPi4zcvkoRs/1CQElaHO3Eqe17qmK9ef676gARXjNlGnrlb+xEWiCnUsQur4wUez1kY0KD4cQ/ODpxFNNrA1q5OwdZCBfsANwCtCww1I4plIIg1zqXtnnb0TZ1nhgbrfvIQrjhRD3pCh2/ROYQDaj65hbB3/FHBa9EnOXXolBTw2/T7b9t4C0JZuqOaC+jrvclH4R5UdGRTV+xRboDXyQcV9LzIudWASHGbbpphpLljfIeGm2fKhxDE+l/JPN4+wgzsEgUINQ38GyaynciyPArOWLPP76oQWttJgdjiT5IzAVYXU5THlgHOHlQ4pfC6d9kBgzBLE9qdAiOEZ4C+DUJI/+JixdJF+kYl4RZYTiVxZ+oxCMfx08gLHEO+wLiiLRv2FkTCQC0H0oNBpjTZFoB+XzF6bwWntrodDl5iMCxjaWeGsEb6EoO1g58Y/OwhXz7l6K8r7nKnwumn4yFitySyOdgOXoihGn93zzdRSmGUPUac3SO1a2d7TmZdzEXld4xF2rnd6xw7mZLVnzV+7vccHZZ4Zg/CGmha8HiRv6Hmu2HydudSD5B95XJrTfkQ0E4PwVXOFsjGkMRN5odGaWbKo1KNIRNcS7DDkq3xnjxIlJnbwB9c9wYm+L19Y8w4eZ2FtuXM+N8t5sCJW95uUCU37dQ1i9trBa1t2q8j3M8KeoN87u9ZCxJ0A4/2grSeFUaQVKtxFQD85R1aTdb7oN/CxMX683EHqPtlJPLC22+HMnsrR/9OgQ5++xZLiSHfyyaLiay358Dx6fhzSSnRPIu5t2eG/XbfMmE8u+xfxfzY4dr9SHJl7aOZp9bqZTsnBsd+YjVR642d+fDEGgVI06nrtOYmDdXQWdHqEM1J8ezIY4hEAJuE/OQRz8mZuWIhiDdcl+8BoQBizL4ig/AOinwIkJ1vPxRL9O S1638pT5 7pcEuVhLMuTcxVwsmyz/R0+tr0kFiSsufBWju0uPIMEqcpoiHO4lJTU2nrzbViOvfD3zRJNyZzxENz47CRi2LGEJvUY8ZZCY4Ufrx9+HhpKApQbqg5Hh2um5yQzWEw+/MXMgHrK+CnM2ki5k= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Dec 23, 2022 at 12:19:26AM -0800, Christoph Hellwig wrote: > On Thu, Dec 22, 2022 at 08:00:20PM +0100, Uladzislau Rezki (Sony) wrote: > > @@ -1825,9 +1825,8 @@ static void free_vmap_area_noflush(struct vmap_area *va) > > unsigned long va_start = va->va_start; > > unsigned long nr_lazy; > > > > - spin_lock(&vmap_area_lock); > > - unlink_va(va, &vmap_area_root); > > - spin_unlock(&vmap_area_lock); > > + if (WARN_ON_ONCE(!list_empty(&va->list))) > > + return; > > I'd just drop this check as the function is not exported. > > > Otherwise looks good: > > Reviewed-by: Christoph Hellwig > Thanks! -- Uladzislau Rezki