From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 172FCC4332F for ; Fri, 23 Dec 2022 16:35:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7ED88900003; Fri, 23 Dec 2022 11:35:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 79D52900002; Fri, 23 Dec 2022 11:35:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 68C0C900003; Fri, 23 Dec 2022 11:35:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 57696900002 for ; Fri, 23 Dec 2022 11:35:48 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 28DC8A0CA7 for ; Fri, 23 Dec 2022 16:35:48 +0000 (UTC) X-FDA: 80274122376.07.77A555E Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf29.hostedemail.com (Postfix) with ESMTP id 7C78D120007 for ; Fri, 23 Dec 2022 16:35:46 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=UyojPTS2; dmarc=none; spf=none (imf29.hostedemail.com: domain of BATV+a36cbb7ae26730e9169d+7061+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+a36cbb7ae26730e9169d+7061+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671813346; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fD9AvHf31njkZOwZj8fkUsiuu/KvvsOzMtsutwzBTZs=; b=IULG6NI/LF9lUd467MKCU713tNXhpDeRQXyy+L9/Q0cCXEPIwAO90IgbjJxQH82E2Kphb5 VoQ8ffAq8GK9qdtHOhA+goi4UyMTStSpp2g7g00u/baVg4NamUQbX+y0e4kqcq9J1JAyz6 1fRk4Mya0zQEeZT+F5vP0gO+lraiSHA= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=UyojPTS2; dmarc=none; spf=none (imf29.hostedemail.com: domain of BATV+a36cbb7ae26730e9169d+7061+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+a36cbb7ae26730e9169d+7061+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671813346; a=rsa-sha256; cv=none; b=UCtcMYcs3cLctJ5Ftvh4WaEjjsakHLwQcc82yAhPVvXepNBVvYPY8T90huZRMxUp2BddFq RmPiHuFFCGhWNdC8YOK6eCq+Yxjl8jkpAmV7AhKwd2mnPwxZ0ZSf4NnIf9SzTaVtL0dLDU oWIltPxyVJtZP3BbbxrujmDh3t1UgIw= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=fD9AvHf31njkZOwZj8fkUsiuu/KvvsOzMtsutwzBTZs=; b=UyojPTS2gieP27lXnkM/vdNs2Y suglx866vkqT3+jGD3jAXcxNPmq35fYQ70evwb5sdjKftLitVLHFV7Sx9iRJ8pxRqmUhVqpB1vt6A BKcTo5fV17SiGgB65GukEPYCL/nkNZjDO14GYP3R+IwXZOH8TAxQP4cCbIFz7924Z7Icae7LmqXcy pSH56dTANV4RrlnTJsXA+EAnGPbv4qy0vsF/VX6+9LowqDkiIYT+3bAde1MT9eX35hkSnXS1Xvobr o03Ulb7Rm+DIWecUVDdzk0SU6UuTXCxXNw5OJu+5MgHq/eWCr5e/qyYhmEv7/sU6d5M3dxRNV7lfO J0vAUL3A==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1p8l1L-00A1Dq-IM; Fri, 23 Dec 2022 16:35:43 +0000 Date: Fri, 23 Dec 2022 08:35:43 -0800 From: Christoph Hellwig To: Keith Busch Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Matthew Wilcox , Tony Battersby , Kernel Team , Keith Busch Subject: Re: [PATCHv2 08/11] dmapool: consolidate page initialization Message-ID: References: <20221216201625.2362737-1-kbusch@meta.com> <20221216201625.2362737-9-kbusch@meta.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221216201625.2362737-9-kbusch@meta.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: 7C78D120007 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: 5yufd65tb9n616xcmgreddyfzemkpg56 X-HE-Tag: 1671813346-379782 X-HE-Meta: U2FsdGVkX1+aHLmVaLY36s4hF6iCFz1pF3df2mXQnpgyOQf6k9RjtBInDLnIzKs+nDprrPFvT9f5jmzI8iGCS0GHUAlHFrfVluLseqK4g9FLO/HHIIflxqKzf0AIbdqiiy3lyFZD+aCVxSq7r+LpNaBlLLQuu+t7KFQHqsQNKvYJcMGcilG8vACOsc/k/Weo1c5mfD9YsR1+kbEnH4nEdsBBhtPWHCb99GyNh/vYRs0pJwN+9Ql2yk3o4d+GDXjsYTnzVNgctb155C7ctGk+3KBD0Z4TJsS2lnwrsXXEUiPXRXceDWOouVFlYc8X7TkUBWc7OvDN2ikLJNuEEFDJ7BDAXTMFs983AZ/rMzKURHChOHZioAwTdOEjXb/xNWcgjn4q+OSxSU+QWFXdXbsSWbhopNb2ERTloqlXv4mu0LNRC3f2K2sBgyuaooQch43okbMAGy8wvOi01wQmk79VTGil1qKnGBkfv8XiwQReWDNcDAgo5lScZfA+E7tQWV57lkKTaqxRu2IaACE9KgPOdFzMBG2ME79FIrDUizGnU2nRyUfw0jGtzhpL4zXVz5qMNtwko4Srg7MwrQ7JSsakchZALwLGpbcx/nJA7UpOB11fcqWajO9H2sJFCB63FWgOx8qgLyJhmSjX6RGrxSSFTH94GVTaYWk5aIfAqrTOtuysCOZgO1aVv6pTsf69jB4K0qD1mJqt6j8fZd5yLwQFs8Bc2xST34ZyZJjxbbN34hYOBkUQhGMcZdGe7ZQ7Gv9xgDIrkAYBgEq8Y7U+IgntDX6ukYGkSBX+n/Dn65rYAqR5i8J9w55cFIv4PuXuJeFTZlatonJYM08id0GmzgnKVUI0fRe9s9TFSkut0mp4SREndwkDM3pMn3EmwFfFZbuXtNO0PYAlL+86y0kH5qxbI/BEo6eAPpIT7h6n10Obe5IYWXEF5m0HEcKTjbphPPRKcD6cqTdkVsaHwB/FwgI DL/qzdHw aw78eGPOiQtzj3wJ7Y53YF5e347jG9scQImW4OXYzv82XYtg/CVJqvGcJVpW4Yo8O01D3PZDaoTcSHkba0ByaNtBcOWsKLLMFZAMIb0whig8uIZIK2QzlQWrcG9eMVZlUeIrL X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > + page->in_use = 0; > + page->offset = 0; This move makes total sense to me. > return NULL; > > spin_lock_irqsave(&pool->lock, flags); > - > - list_add(&page->page_list, &pool->page_list); > + pool_initialise_page(pool, page); .. but this now moves all of pool_initialise_page inside the pool->lock critical section. Is that really a good idea?