From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B7B7C4332F for ; Fri, 23 Dec 2022 16:31:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D20C2900003; Fri, 23 Dec 2022 11:31:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CD0BE900002; Fri, 23 Dec 2022 11:31:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BE7D5900003; Fri, 23 Dec 2022 11:31:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B132E900002 for ; Fri, 23 Dec 2022 11:31:11 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 919F51A08DB for ; Fri, 23 Dec 2022 16:31:11 +0000 (UTC) X-FDA: 80274110742.28.19A8B5A Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf05.hostedemail.com (Postfix) with ESMTP id 078B3100017 for ; Fri, 23 Dec 2022 16:31:09 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=L4E35C1b; dmarc=none; spf=none (imf05.hostedemail.com: domain of BATV+a36cbb7ae26730e9169d+7061+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+a36cbb7ae26730e9169d+7061+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671813070; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Otc9hVPnb4uEiMojoyOvNAsTxJu3nDfQNUlQmeQ8aE0=; b=VyMMbDbW7Yn1jKU/A4UdNZ7dM74xPczk22kVtrSqklPRq1gXfQCvdqK9KSQwq8JW5nmozG RIvrswsfxyTywrjw0W6XJRfCYv6Gw/kix2v+T3X6t/a/r2907dKme5G1Csk6Nlm4/EwWSF T6moPfOgG/k0FCGiN72j2VqJI0bIJhI= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=L4E35C1b; dmarc=none; spf=none (imf05.hostedemail.com: domain of BATV+a36cbb7ae26730e9169d+7061+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+a36cbb7ae26730e9169d+7061+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671813070; a=rsa-sha256; cv=none; b=iYFSTDDPh7A9aDdsIp/HWvAlXrybOX8+F3mm5I/cavVJe6Lobapg9EeyM8yeyokHFltEAU 3nCQemgwQEP0rs7ASBcXm+sO0m9viLKWonskn6faCxC3JGNSiOyZe51stm2AhcYEHri4AY s/21Y6wo4lDooUlDZoJzJZnRharjjcA= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Otc9hVPnb4uEiMojoyOvNAsTxJu3nDfQNUlQmeQ8aE0=; b=L4E35C1bu1mLdsdwy2A24aW9i0 BlSAurOdUGmUVBZRuV5dLvXjsXHDhmw1dZhnP+Ux+dGYfGTUAdeshJ6BfmsbcJLh+YAq6rro4MOGt bN4ocBY1x3Ebl/ByzMhXiUwXjbQhTa9ghEEi7oPe5zrewdlqbVwQZLLvKt8mDCq7My+FLW886Kxoo XSagG2jM3FJFxlZ7XeaVmTHtj3m1LtWUpq1L6cJAElnMl5XRCYPuQp/g9foPFdlMi4lR6H6dSqDY3 6vVDJB+1tUM7sUvaDs9nLcboX1NnKEqRskCuOxMSRK6nso0WbYY7g0mPGYD3f908lBaOe7oRG6tGv LvYJpN0w==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1p8kwt-009ztr-B2; Fri, 23 Dec 2022 16:31:07 +0000 Date: Fri, 23 Dec 2022 08:31:07 -0800 From: Christoph Hellwig To: Keith Busch Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Matthew Wilcox , Tony Battersby , Kernel Team , Keith Busch Subject: Re: [PATCHv2 06/11] dmapool: move debug code to own functions Message-ID: References: <20221216201625.2362737-1-kbusch@meta.com> <20221216201625.2362737-7-kbusch@meta.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221216201625.2362737-7-kbusch@meta.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 078B3100017 X-Stat-Signature: 9rkh85zbra4mqyjo9zmidk8xxkd8zwe9 X-HE-Tag: 1671813069-932630 X-HE-Meta: U2FsdGVkX19E5J2CKaZUVFeC0GIfVeMzen41Q85jWNbqtL33XMKOVGxZRyqOMwWwGJWuABJQuIxKknMlH74JkpGHfmQdv17NPhJU0laBFkiSw5VWtu1gE8Vn0QnMpEvddRjQH72nJd9TsxgbwbTMRoI15aB7lDqyy168UV1Lvr44sNCsUc37l7nW6cHqq4JNMSi0fBLiJlfeF4m1x6W669xlukiuhncanuszawsBVHZd6Ey3uRFkN+3cn3AaLvekpwjps4rX0txjxcTTcrgh7UDOap0iKkoNVZgA4bBiYx8eTBC/Myd070tHCyHY8fYnAqd17S58WFYCwAFZxNEDimoL4NpjQf4EdELs5837RRpL4w2oiKegfumEpBlhP03pMLzMHCN1CFxZPI8/YqddAYFW9fznLoTmxj68Rfted78Xa863LFbobX1wcH8hV7cG/9eq9Zpk7u5zkelvPN7vzhTy0CJhrK43dOOKVbvdxnKLDCQ9fJVDdFKt9qhgSUVZik82XOvLjPCP9kkZ/npVcFSD/oi4FnY3lxozHuwV39zfmQRSqjpRSEVnuOWFJLvJhZK5iJbDiaPDiTwyatZF9qrvOouRShxRpWTBXKtJMiEjSyeyhvwMsCHOGBme+XbjWGctEFUV92AXYVukPeNLf9YK01tVRZu99vglRFDJ9d2VSA67OE7S0SZdmfiSDxzfyN8KZrzZ4u9TfRWqlNWNhZecP7OIX6z6j9WC9amZp4cddxa8pUOd2B5vLV2PNPPpLJsFshdhMPPHwp8FLRicgKEBQpEoCR+96LOpTwSfIavDV497u6/AB/S4Z52rl3Uyj+P7dMD5dmwob3tEO4hbpfOAO+NgwMs3RTLJBBuIhPXpTTgt2lGqC7okigIZsOQxsT4c2yBmn/8808Ugpp1IBVdi5eUm6H16X/IXCw+LqgFrq0SdnuNDwAJpMRL1MJd/tFEUiu8hL9dIluWhJRn RbwjnuYp 3XXx96kQkC5BCD4iNvgIo9DQUgeUY5RNUBQfrMfK4Dob1493DBt9VddUy1nuqeSwVNXZ/VeprGUCz6z5TjWp31vt+FG01KeAOByyygo9Go1qRhapmXUIwDRzBMknZefDy/x3g X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > +static inline void pool_check_block(struct dma_pool *pool, void *retval, > + unsigned int offset, gfp_t mem_flags) > +{ > +#ifdef DMAPOOL_DEBUG We normally keep the ifdef outside the function and provide stubs. Extra points for keeping all the debug helpers in a single ifdef block.