From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 680BEC4332F for ; Fri, 23 Dec 2022 16:29:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C8676900003; Fri, 23 Dec 2022 11:29:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C36DF900002; Fri, 23 Dec 2022 11:29:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B2690900003; Fri, 23 Dec 2022 11:29:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A223A900002 for ; Fri, 23 Dec 2022 11:29:01 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 5691D808AE for ; Fri, 23 Dec 2022 16:29:01 +0000 (UTC) X-FDA: 80274105282.16.FC4DEC2 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf02.hostedemail.com (Postfix) with ESMTP id D515280008 for ; Fri, 23 Dec 2022 16:28:59 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=SeixTs5F; dmarc=none; spf=none (imf02.hostedemail.com: domain of BATV+a36cbb7ae26730e9169d+7061+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+a36cbb7ae26730e9169d+7061+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671812939; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=l8Xt/3atswUT69U09UNdnUFdOKiDOqd4GvHj/Wr9dKo=; b=cWa8vzrXP5MJA9thRVnMFzViXzTJvhinlAcx3RGElD58cutK6YeaYeQODktjsTVtbwX8uM 5VqubLl5pNmcsWhesanPWlfmwQ6VTeTRQLaLrfATYjANg9XUB6PjX77aGkk9gxiiPrJUyl xooU9nkz+n0GXOzykV833+dugBK5SEw= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=SeixTs5F; dmarc=none; spf=none (imf02.hostedemail.com: domain of BATV+a36cbb7ae26730e9169d+7061+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+a36cbb7ae26730e9169d+7061+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671812939; a=rsa-sha256; cv=none; b=coqbI5pNClUzIRn/4YdDYJUGb8b/nwODZ+l94rr/dcr/y5xibbmZ48I/d6Ag+7z+CqosGJ sH98NE+61LHUgD23Gz7gKdXBTDmfwccBZHamX/Z8pd7jjZJytnzHfA4jMf7FKaieDXd9E7 3aJFa5IZw0h6FAXdDE6aCevQ1a/j3No= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=l8Xt/3atswUT69U09UNdnUFdOKiDOqd4GvHj/Wr9dKo=; b=SeixTs5FTyePf9lvHU0rAXjXcf HlW7R06P3fVJ+Ev1gg0H9Id9Zn/eg6YeF8ZYrpX0JlyLCpibAEspHqg52k+R98fZlxd7tXMWzKrRL ZuPu4H42QxC/YUVoAVGsF8msM2JnoloeGNWRx7ZDpXCUHWIOcwpxBmbkJ5C2Oepl18uBztjtRas1C WxOM9vcf4dPALYEfZSEoB/6nZ1EFRBOEiknYk2dX82HRaV1CjaQjoEgspAbWPtJTLJctbfYamKtnF vilnH2l3f+akVkPa7aTeA6Jn0GKxcOhKtN1kz/fldUQ35PB52KFgdqWPNTXHacsnbFneRgKRBXLUB chcgcdDw==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1p8kum-009z7Z-Cx; Fri, 23 Dec 2022 16:28:56 +0000 Date: Fri, 23 Dec 2022 08:28:56 -0800 From: Christoph Hellwig To: Keith Busch Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Matthew Wilcox , Tony Battersby , Kernel Team , Keith Busch Subject: Re: [PATCHv2 03/11] dmapool: use sysfs_emit() instead of scnprintf() Message-ID: References: <20221216201625.2362737-1-kbusch@meta.com> <20221216201625.2362737-4-kbusch@meta.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221216201625.2362737-4-kbusch@meta.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: D515280008 X-Stat-Signature: adyzj13yrguum9i3iwa49xyxiqs5g99i X-HE-Tag: 1671812939-709347 X-HE-Meta: U2FsdGVkX18ZY10TP8Cs7dCU+VrnSuPHI35wd51M1XD+prvMlqwGEG8+XEufF55VZQgwpcWL+AxorIO3yk9szh2LyGaAG/e7EHj/muxcFOREA4zWkW6APFLoxETLv4H70GR8QoYliF7x4c3MBVJLJ9wJSV3N5vFuLhf287xalCtYzIETMexHnDEcCW5r++VCJiedkgdoiDQM27uxY4MjBV73BHzBn3tL0lZuSsZ2b1TvsOcHqUehE2ytCMMQ1hmOXtoECAsO8T/gyiXy1fg50NaibRKKu+JsV7hwZ4ZvjoXSXxDmMdZM8qrxEXCzGfH/EiMBGCP7pNjsNBBlLp3NWGaR4sQYd3uxMMt2B9HJWvaa3Af2RrMn+MnTOqJqpVdaYpS4bIEhMjDO7LnETibLWJzaANR3iqjw0dhJry/+oV5qh6xcVjSA33PODWSR4FteBLRhQ5+XkvKqvKElOntJ8cu5e04inVUGmkNuywo0VkF/4dDnut9f8Vu/1r9/zgH1pdcGogy6WiYFffESASArSN2NwS7lxSIMRrnqvnmA6YFaaJbbtDh7zJdYrM7ju1ny2e2k4SHQxCVp0tvbbGAMnOaBGnfgAt55aApj4+3S5phaB8MB5xi5BFMtZm6W4g+vMNYFDp2Qq93jHMXdQIva11eV1bjL4Z0GevK/pvVCQYs/AbK5u1qY5RCy4CRvYN4zMN4xGF2BCgwDnnOZ9p/OFJJsE20S5T4Ysck9drIJ61U8jXZ5MQex9MaY7QPyi882RQNuLgh3GvSb7p9nRdkiCGkQbMGYIezkg8GiHXUuPYxG9g3YKTCPRV8YEo92Foj5HYYNXqj01PR/6bwV+iWUCbocVba3I4CxVw6BPKrUmluPE834Qgbu+u4F9cSdwWQMDDoJwMcZWhEZpqMPBgI0x249IZa4RbvFtL8UH+qKSnVnb6bCLhOBQjxkeb6oZqN+1SyMbaeCqh4ecgsISre F6XNbV61 gHJkxohu5XoMSP/ayyQjI93VNwAv8oHfbYINUd6w8C4vOV47GkO5uahQKpxkUEe619L8bJGiBwwc1ZhfJ1l6TkxGvr8sWVGIaWeIAJx1YhqFZcgfcOIprbetuSruhGUO8L44RZyyQcLuUo0QK+sZ7QwzhuGJn62kmpEUdxDSTxxXKfVq+goNBRQMxsA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > + size += sysfs_emit_at(buf, size, "%-16s %4u %4zu %4zu %2u\n", > + pool->name, blocks, > + pages * (pool->allocation / pool->size), > + pool->size, pages); Did I mention that the sysfs_emit_at API sucks and should just take size as a pointer argument an auto-increment? Not really something we can change in this series, though. So: Reviewed-by: Christoph Hellwig