From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43E4EC4167B for ; Fri, 23 Dec 2022 08:08:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B6355900003; Fri, 23 Dec 2022 03:08:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B1253900002; Fri, 23 Dec 2022 03:08:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9DA50900003; Fri, 23 Dec 2022 03:08:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 80F4A900002 for ; Fri, 23 Dec 2022 03:08:07 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 54EF880297 for ; Fri, 23 Dec 2022 08:08:07 +0000 (UTC) X-FDA: 80272843014.14.C837AC7 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf13.hostedemail.com (Postfix) with ESMTP id E61022000C for ; Fri, 23 Dec 2022 08:08:04 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=E51cHrJY; dmarc=none; spf=none (imf13.hostedemail.com: domain of BATV+a36cbb7ae26730e9169d+7061+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+a36cbb7ae26730e9169d+7061+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671782885; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fbFBDoUTr0Hz3vXP45guCPqzXQAzMtYZDFQbW7aV/7M=; b=6ZRNT5e44upZ/EIIF8yAOVXKjOfg3dVwGD6I5RQ6s2Kf0vI8R2KqzolKsNfzMt0DsafM/d rS8nnUl7eFxwNN3//LvHw6OaPvNyRpLTb8McAoWAGqNu4b30NSCWExmf5/M2sNjASvQADB Sqwhs+XoZsqeCI6KRMtbi424pSD860Y= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=E51cHrJY; dmarc=none; spf=none (imf13.hostedemail.com: domain of BATV+a36cbb7ae26730e9169d+7061+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+a36cbb7ae26730e9169d+7061+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671782885; a=rsa-sha256; cv=none; b=1m7ofxnbrBDjMqzThoKo8MVqKfxCKW1AM7L/75fjAVhriHio+QMykIVb+ltJlB9pK3J4M7 NMLmr7sW8y0ryDoNCvLm6gGQfR1J78LQsLMThg76qOxtFrt7lwHavKKtMdCFtVKU4qo8n8 ZVWgOULZPea9YLdDxeFpZy20COhi1+g= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=fbFBDoUTr0Hz3vXP45guCPqzXQAzMtYZDFQbW7aV/7M=; b=E51cHrJYUYXCLQJ6msKO9XaW+8 SzQjBaBALne5fVjvNAvOV5qoAzJhYusiS9APVbPLZRIMgmJ7vHa2pr+LksdjkiUicoqtpUYZXNLFN 9bDjsW51Plzixgfu/1HQwqxSRbvphYEqPWc08mBxLgstgTi4TqffHWvFVor42sHep04aR2QZoiHJ9 cydEsdBmqvFVWSWR3FsMvKU0hkKQBd8bHu6sdY4gbMqcF3OiPiol9TM3x7/sFIBON+zQeq5GNAJry xu016McQd+WlF9525pZjlgYolVF64q6K95fNFFNOvo3JJyco1IHDzd6tNVkz7jyKmnvciMq4Uhlf9 38vhvqTg==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1p8d5y-0054Xp-JZ; Fri, 23 Dec 2022 08:07:58 +0000 Date: Fri, 23 Dec 2022 00:07:58 -0800 From: Christoph Hellwig To: Vishal Moola Cc: Matthew Wilcox , Chao Yu , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mm@kvack.org, fengnanchang@gmail.com, linux-fsdevel@vger.kernel.org Subject: Re: [RFC PATCH] f2fs: Convert f2fs_write_cache_pages() to use filemap_get_folios_tag() Message-ID: References: <0a95ba7b-9335-ce03-0f47-5d9f4cce988f@kernel.org> <20221212191317.9730-1-vishal.moola@gmail.com> <6770f692-490e-34fc-46f8-4f65aa071f58@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: E61022000C X-Stat-Signature: fod39ezq3nm1hpgjjha4udhjfqdcixj8 X-HE-Tag: 1671782884-222038 X-HE-Meta: U2FsdGVkX1/Etl9erqHBSlNx3C8i0rB9i4UjN14TKquZ08ekdm6Vona58DxgG5jKOCWX6EZWz80U2DClcsrr/Jm2bm+FCVYDHHWN9MgdqvwOnANOrKmlSVJl0Vw92AqCgSb01MkpkkgBT2YShYX093tjIAPtSSquOKOGC6grZyrTSmY5PRLhLTDAg2wSs1LEuN4hx8Ub8j9h7HHY+YdOHPRj7ym6IKwzRBbkXmSjkxolIr2nCu4DeDCWO6xunCcK8EHfhb99dhgOzRTPLbC2OHFEPdinLogYa4eFY69Oio1hrr3cQWo1UBILlnM4BRJGsx/jETBrZl9UA/LauDow6f3bqYtkM3Qw05o1GgRtCZl60R7ZUS7+fuTEYfmsaJUAz7Y0GNv1X3Ig36viouCpIXT0GhtB3rJhVPx64f0l4ZuQFA96A1JXv5vjAKkUcMgu0H8E52h2jVrlHkSZKdlJnUOoSR0pi7nMk/KTCdYvtsM3Cz6ueSW+euhw0324z2mJL0gKRKLnskgd/D6kjF2/7Jf9VsPalR3HooJiS0eouzsM63+YAsnQvcN9bz8Gg4GOiqGj7xnDs1xVAlSaQ0XdEsrYRGRjCu2Zpb5wfxEIftsGfF/SluHw4XSou9BmUanMgWGh+21pIMPWwRluI18jJgrGLOqjVfOzAaHYo8uJNepXctxObt0wW2V/gZNw9ueKvAPOIsidzbTfmNK02l5sMcgr9C+nF9HcpOIODpxerm6TvhEw2Q6seu8CTjsM4xbw0bIrB+mgiA7m+e7Ba7QJL0hxkcLyNg9nZIuB3yPsPksuzk80/RR+8ujPGieO49zWDS+/P3MISi8RLcRe/w/L3JS7TzFVImOvEQDa7kO3Vfv3wUosviwNoNjrPtPsozOlqyiCiCTa8HXBRqkYPsL6Cj8sFZNGWGsIM22blysMi4eU3t0t57qRaZQl8+JnqkyBGi2maXvnzFsW5aKa1VW fNgx6y/j O4Ca81VocjRekd/nmWk9GlZgGcHfli159ggnIsXxIjmOSuwfr7dVPDFSHtwElKlM/z1QSmpmsnYJm6sVysriR6avSnvY8OEVO5hFo5ybj6dgOqgVz+FSUJON7bGvGUDSODJz0zq5I1WhROXj1j7bkm8gqWFfcTqallLnkd2LvISdiVEWuqqrO1iO0/P6RI7nf5qHXc827lDlr7VCOsEPSxBqiOTOa5Jxgk8p/VADVW3RP+373GYoB1IxTbQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Dec 21, 2022 at 09:17:30AM -0800, Vishal Moola wrote: > > That said, folio_ref_inct() is very much MM-internal and filesystems > > should be using folio_get(), so please make that modification in the > > next revision, Vishal. > > Ok, I'll go through and fix all of those in the next version. Btw, something a lot more productive in this area would be to figure out how we could convert all these copy and paste versions of write_cache_pages to use common code. This might need changes to the common code, but the amount of duplicate and poorly maintained versions of this loop is a bit alarming: - btree_write_cache_pages - extent_write_cache_pages - f2fs_write_cache_pages - gfs2_write_cache_jdata