From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24288C4332F for ; Thu, 22 Dec 2022 21:28:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 48F6D900003; Thu, 22 Dec 2022 16:28:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 44A18900002; Thu, 22 Dec 2022 16:28:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 306CB900003; Thu, 22 Dec 2022 16:28:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 22FC8900002 for ; Thu, 22 Dec 2022 16:28:19 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id D8F3D1C661D for ; Thu, 22 Dec 2022 21:28:18 +0000 (UTC) X-FDA: 80271230676.23.48B3A88 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf12.hostedemail.com (Postfix) with ESMTP id C501640014 for ; Thu, 22 Dec 2022 21:28:16 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HnwnqTtm; spf=pass (imf12.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671744497; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3m+P6TgC1w6BUj8pVbwI/HR3GgXbzkCBv6mggYtjhfI=; b=sHztX80aKDPm4Rb+ujAocXZRirc51GfcGkpadD4m83ZtbVsDxAA8GTd2Hcv3e8YXjk5z9m fTy8NGKLiYplzPhU38MlPZuBvR2oxixkJyTdihIg2gRZJsCwI85BHyPp6uWao7y6gGBYJy bSsOhSp2Jc+nTGvflyTlh3Rs3/V3nDg= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HnwnqTtm; spf=pass (imf12.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671744497; a=rsa-sha256; cv=none; b=AARRCu8dqQMeMm7itkxcAM3v9fl64COn76K1RIbk1+wWBoUph71Tdjc6prvAITGmv+2+tN w/L0FDk0TTClOQLIWvtKaa79YUB7Sk1F/D9TdG0Baz+XAcJfjcsEfy1q2V/6YfwXFILEuR VFHMqBK0+K7t5iHbQ853qmVdB8e7mm0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1671744496; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3m+P6TgC1w6BUj8pVbwI/HR3GgXbzkCBv6mggYtjhfI=; b=HnwnqTtmMe9keDNm+YoX2z/uBjb3zJ/5rqsj+22DNIIBux+lkQchlZ+MnEy9J1bVlvDglf wPQqO7vJ3YzICZrfah6OPZLFHaocheFxe9ovJfbY0OmMnL8+ySMl5+XaxigJX8J1hoQmfn f72s/jnKGjG0FGQ5BzWxNqRrdGLV5aU= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-389-7SzgT42ZMg22rrjq0QuE1w-1; Thu, 22 Dec 2022 16:28:14 -0500 X-MC-Unique: 7SzgT42ZMg22rrjq0QuE1w-1 Received: by mail-qv1-f69.google.com with SMTP id c10-20020a05621401ea00b004c72d0e92bcso1542575qvu.12 for ; Thu, 22 Dec 2022 13:28:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3m+P6TgC1w6BUj8pVbwI/HR3GgXbzkCBv6mggYtjhfI=; b=CbSP80AN6pUPBJYKvG8MzjvV9aHfb+FUKliyvhL3qh+3MBENBBOYW+bFeRMFjaBtW1 Zp/GBF4hSQIxXakLztv9GMxuEOxfijSu9qKAnOF9TnRau+CkFWdUVTQjN/Qc/jXY0crQ MsVZ8HfNbFp2nbt+B/fAZ0IScL2v/mxE09p+j9Tdb5M8MkXKTUepsmYFmz+A0alvDg54 NqbxvZTS+FhbUpvZMYi4/bbaK9vBdajmGtZ3u7Q5zP4itodrkdB15CK2K2OKYFlHhieS el81cFBXYfSHYM9N+IusU69YCeSOlnF1cys4Q7dt+lo9mEbXF15ZJBBuPun/3K0btCE8 0QsA== X-Gm-Message-State: AFqh2koecEAb3w7GMbFWSmviHbK3tWdIifcrcj+wiop3EvM0B/CU8CRr VKkgAGPK1nrj85MxdadAFno6KrIzsDlH0c4ExoFU4aMkKmxrL8spmgI+Jzw3aiSKFUPcr93gjrs PInWrzb0cW/4= X-Received: by 2002:ad4:4f53:0:b0:4e8:1593:e036 with SMTP id eu19-20020ad44f53000000b004e81593e036mr8639642qvb.32.1671744493985; Thu, 22 Dec 2022 13:28:13 -0800 (PST) X-Google-Smtp-Source: AMrXdXtBswMScGQIuIfbwQ8CgNRsmLkwy7qynihZhGW1bKlHfBb6+LD86F6LxBUHXWuFz14xzUZDuA== X-Received: by 2002:ad4:4f53:0:b0:4e8:1593:e036 with SMTP id eu19-20020ad44f53000000b004e81593e036mr8639621qvb.32.1671744493728; Thu, 22 Dec 2022 13:28:13 -0800 (PST) Received: from x1n (bras-base-aurron9127w-grc-45-70-31-26-132.dsl.bell.ca. [70.31.26.132]) by smtp.gmail.com with ESMTPSA id n78-20020a374051000000b006f9ddaaf01esm932241qka.102.2022.12.22.13.28.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Dec 2022 13:28:12 -0800 (PST) Date: Thu, 22 Dec 2022 16:28:10 -0500 From: Peter Xu To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Mike Kravetz , Muchun Song , Miaohe Lin Subject: Re: [PATCH v1 0/2] mm/hugetlb: uffd-wp fixes for hugetlb_change_protection() Message-ID: References: <20221222205511.675832-1-david@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Stat-Signature: w9uhhqmt5yoriq5co83pokn4qhfqfzpp X-Rspam-User: X-Rspamd-Queue-Id: C501640014 X-Rspamd-Server: rspam06 X-HE-Tag: 1671744496-103475 X-HE-Meta: U2FsdGVkX1/b8L/mhFJiLI82ZveHFLefmPOfP8zOKnZXuSpVYwg2oldcsm7LUHyjikU3yKPZ119zNaRMRTUrtMKzOMezMi5C3n1VogOwAAAprUBpW9J6JTTbD4kMogmZkIXg7kcm9g66jWy47Wpv5RuM/HftsXsd+H7ePZL056cvheVewcF58Ny7ib22tfdv5C0GxDnrOD/pDgjHykEulQjqUAbwJfx0dNinK9NRaVbjNpn1DkngwNw9fJPnOABUmwjZwxjqexrxF0Hw+K40lbxfnpMFSXcUPFztEsHiYlOkejTIBmb1OaTqHeY6wRRLlxMAxGVUEc/t2b4sHX1r+8+F3RmIxdH9ZCb4TqgCfPqDFCRZ6udN8YfcKOyWmmrYIPbUzxvDQBdm6jOg4blSwJsQQSFxKnrpgfNFm+2Vt+CaU8FZBTwA3ThBhoHP3q8xHXuynhihk1UZCP8CBdkhY0vWGDKtjlfhUi3IuXvcQAxcH92+4DHsNxuKGxZNeJr1zbmVkgHfRZ7nrBJvowvkpgn+RUaXppoQgq6CzPhoABINBIQfZB87FWGJVuH0a07JZ/yu7Lip2aR6Ni94SfGPqDHrDiUJCRRji78hGyVj22Lm96D++fLREZQm5DksvdCuPc/LfTKQJwQY1ZHzBt5227SloqXJisRs9h7kVlygAm/3YOy0/DP4FT1YPfZnP5ICxfCErrzjuzPGcmwVqI6RlUOvSZunu5Jj5DS7IsRtN0yj+8+RY4M1QBOiXXVTr9B8GYNRfdYvy/0OspBiSBPOvl4fUPa6rwBXjADDpHP6FUW6UKQNoOcQ3zXueNYz4DIzelsxLn7+MAkx97kexapPEXofZKgpGtXAEbKgk/NjfgKIAnJNu9XRFxRnaPGYzZRHhtRzUbBQfKFPchoXWO+CntQcrPaH2Vk3PAZpOtuDmaE25Zz1hr4TQcviCR4wIL9bYx8MzdnN94i0GnngCVx ADjArKj8 KDduBd+XqmnccVY7nYy7vSZ7RfC23JP4ttj8ThEv40u43jV/zloO1LNRHqUlpPYIPZrA/cIkKc62frBSgnCLEzUOQ4VdsP7c+g4v16zVh5g4KiBy5HR8HFmt4IlRdw1d1zM55Jhdm3oXv4637lN7L2f+/0A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Dec 22, 2022 at 04:17:22PM -0500, Peter Xu wrote: > On Thu, Dec 22, 2022 at 09:55:09PM +0100, David Hildenbrand wrote: > > Playing with virtio-mem and background snapshots (using uffd-wp) on > > hugetlb in QEMU, I managed to trigger a VM_BUG_ON(). Looking into the > > details, hugetlb_change_protection() seems to not handle uffd-wp correctly > > in all cases. > > > > Patch #1 fixes my test case. I don't have reproducers for patch #2, as > > it requires running into migration entries. > > > > I did not yet check in detail yet if !hugetlb code requires similar care. Ah I should have left a message here but I forgot - afaict shmem is all fine. > > > > Cc: Andrew Morton > > Cc: Mike Kravetz > > Cc: Peter Xu > > Cc: Muchun Song > > Cc: Miaohe Lin > > > > David Hildenbrand (2): > > mm/hugetlb: fix PTE marker handling in hugetlb_change_protection() > > mm/hugetlb: fix uffd-wp handling for migration entries in > > hugetlb_change_protection() > > Reviewed-by: Peter Xu > > Thanks, David. > > -- > Peter Xu -- Peter Xu