From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA6A2C4167B for ; Thu, 22 Dec 2022 12:38:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 22A12900003; Thu, 22 Dec 2022 07:38:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1B4FD900002; Thu, 22 Dec 2022 07:38:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 053CE900003; Thu, 22 Dec 2022 07:38:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E7652900002 for ; Thu, 22 Dec 2022 07:38:26 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id B2CB180220 for ; Thu, 22 Dec 2022 12:38:26 +0000 (UTC) X-FDA: 80269895412.05.2047D3F Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) by imf01.hostedemail.com (Postfix) with ESMTP id 1AC4840013 for ; Thu, 22 Dec 2022 12:38:24 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=To9J7CD2; spf=pass (imf01.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.128.51 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671712705; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2rBBnAXnD5Etqe6g9RvZN5ObDKOiH+aoC4TYIyFkoLc=; b=6YwV3kIQAPw2dJ+HNCbnkBhE8aKHgC4vTIuprMARq5Xvk2mjPDrZOemQ0wqTisnHge25pI Bmy0gWlqLPNNEDp8dd/xYkqkuHrGkgA3ZlzN16AcOsZHmFGvvwYjWbJ3PwVvu0bGlozg2x l/NxBsDvVGgiTM+c2zRyJruvqMUTtI0= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=To9J7CD2; spf=pass (imf01.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.128.51 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671712705; a=rsa-sha256; cv=none; b=fqnuBbqtJuKuB2L1dbvEOrw9kxB6IB4ZrIwQlowrf+IidUvnhP1pq3nQ0DNyuAxXUDIVmk H3SiVb3Kaz1/ktQP/tR32dnV73kb3paBbaTKfZWZqWZMmdFZeir8kol3Kwx8zAT2wK2Dw6 7T0BukLgSg2NeWb7u9sdoytDRBjHmo0= Received: by mail-wm1-f51.google.com with SMTP id bi26-20020a05600c3d9a00b003d3404a89faso3854585wmb.1 for ; Thu, 22 Dec 2022 04:38:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=2rBBnAXnD5Etqe6g9RvZN5ObDKOiH+aoC4TYIyFkoLc=; b=To9J7CD2h2YZnIQZIMtowMgTc19f93NgPwCPHbdrYKed4fUtyOdeuuE3JJqVUUfExG UB8IfwKKqM4t/1ZddkQMshKjTLnuNgpNGqFAOrP76DX1GOB1gznF35SDGgISH35NGxLz wtDzEXTta0EK+kLma8jTKRliMQlTqk3VA7hsXDM4aWn9NJt6aueTTZeSok4NubAF1vE4 qq5KhVOQen49MwJRebLi4niFZ0dSSCmgiw2a0x3enEhlaVkkDhrAyLXgTX5lIOhpm01b 7IoyoTUAN+TQ64A9GjtdoweC8xvDRkmz+KKbKXMdxz/syV4S38l9jEWbPWkf8g6sm4FX RCTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2rBBnAXnD5Etqe6g9RvZN5ObDKOiH+aoC4TYIyFkoLc=; b=kY5euq27K9IGpvHmmjXqdubbCDau9WYYOcv0BAC3tH0shOdv8sadMEoNjpUR7ICfoQ FXvGXldBoJBjDbsrMyGMDNMZo/XrzFjXS4yXPG10GeUU9hVJGUzTK2I3+/ItRRv3PiYU smEHHQEwg4Pjh89xhy2OJr2T20AqPNrAPYiSFwR66RT2pZ+ylpOt0WUsQNshkx8mq1DA xW+p+y5Ji6Vr8X6xvaDnuZlE2zmz+ot5t5arTlwmQHCSTDlFYwz2KIr4r+k2aQ6zvh0O iTV0Rlt2LaZexrVVWEjXYHcwaF90tzf3m/kx0tKg5e2AXVsVWLa3ORDyxj4UKLf96bJC E94Q== X-Gm-Message-State: AFqh2ko/lgzPVu0EweggXhnSOqsYKUNJM/OGOoFjoyHsw54l3fAVrzIT cNZcJwgrSWC2p4ys5EHJ8+w= X-Google-Smtp-Source: AMrXdXsSs07k0r7LHjouMpn8zOyWkbiInBY4SbjDO1AxmEmpfiJYqoYGx7JISuYU8uRZJk1i5AHxNg== X-Received: by 2002:a7b:c447:0:b0:3c6:e63d:adaf with SMTP id l7-20020a7bc447000000b003c6e63dadafmr4253840wmi.31.1671712703557; Thu, 22 Dec 2022 04:38:23 -0800 (PST) Received: from localhost ([2a00:23c5:dc8c:8701:fdcf:52c5:7af:c812]) by smtp.gmail.com with ESMTPSA id c10-20020a05600c0a4a00b003c6b70a4d69sm860981wmq.42.2022.12.22.04.38.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Dec 2022 04:38:22 -0800 (PST) Date: Thu, 22 Dec 2022 12:38:22 +0000 From: Lorenzo Stoakes To: Christoph Hellwig Cc: Matthew Wilcox , linux-mm@kvack.org, Andrew Morton , linux-kernel@vger.kernel.org, Andrey Konovalov , Ingo Molnar , Marco Elver , Michal Hocko Subject: Re: [PATCH] mm: remove unused alloc_pages_bulk_list() Message-ID: References: <20221217001554.554913-1-lstoakes@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 1AC4840013 X-Rspam-User: X-Stat-Signature: ozrb5usjdsdu6wnjmhjp6rfee3m5p7ca X-HE-Tag: 1671712704-124048 X-HE-Meta: U2FsdGVkX1+s6GCxmUyuFgJ33LP/EyYbzIg35jzZKTY0Yr9nWVH0DEQaBesPkZDqTYGZxp/zc3cddfC8O6m1XY/JiHFRvbOfs9fGYreWgjaKyOWMfRUWeS3QDIOMw/ef7+/TuMDwBP8MeyhjU6QNlsPBk5F4MpFQ8CVxYmjEdd0sgYU4wOtmZFscK9p3e2uzdvsa0gtncffqXKHravlf2/sMjTjQXyHJ7B/4P7avmUNwohNoKcc8AswwWlK9C87WUMYWOTkRBIr922kUz2Oli/fvJ2BepNMGYYT7CjOYttwrBNl0S81zr83Hj4pgNS8DkwOz/khWtlg1V21UdYCXT4+Tb3+mTvs8ZI+SLwj4Ru0IYlvDlCwU+5KZ6NoOWZLer4p6zhnRCCPQR8fs4kj3IPLWdeWO0NPebKi353Jh5H0fQDhaALfe8jibPjKYEZ+18NBs2HvZXiijCdCGNpgEHTNTWpZp/0deMyS8+oDoU8e3BfH7HJ9diG8XYA+jjp8xE7w7+JodOt1dTwdJAH3JaW/hsM24s0yP72fvkkK/+bC7cPmbC1e3aabc5ZfmaCOMWujnREoXJbjQm/eGgYGhDHer5pbK4Xn+LIMFGph/4JDeI0KTv1b+OxsKNi1ElMang+h0z/ze5S1t6ASU/ifWamFNyPMUgaX9mKbrNvhJvxe3T7/wFkBK/XKE+3VykzJyrlC5KCv/lmwHLfb3tTs3j5qNd4r1MsaGyAOSy9cqlIzaAVgWSnC8jIImcu+BmlikgNUuHyx8iYQiDpNZcHxZNbbtc+PcgC+UAlUrDrd4p4wjfi6TzmzmVQk45BaASaNpe18nP07CeJajJj5c00t2a6aTLyG7/vW7AuxP92TnI2E4dQkCUlMoO90Lihgsec1b1lTPK/2MPd+Msi1lshBF6fWT5WF6F1i4iNKkKeCKMx+TIsvx7QXT5fjUFDvQjA0etyw5yKG29SO2l7LJX9f rLcTRRjr 0XgfcezW2mS3rhZ3BJWksI9IdLoHp+ltS3Pb0BolFvh0NuJd9YWwdk2v7QtHpyZ4/nbfcaDpanqjRAWjXiGEIf2P0RcgmOfZpVkFXhevH5b1GpE6Kz09qyICIRL7eMr6aht2p X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Dec 22, 2022 at 02:03:46AM -0800, Christoph Hellwig wrote: > Is that being snarky? :) We generally don't add dead code at all, and > certaintly don't leave it around for a year and a half. > > If anyone really needs this we can add it back. > Mel has replied elsewhere on this thread and we have a potential user so I think the lowest-impact approach is to go with what he suggested - wait until May and see if we have any takers. I have put a reminder in my calendar for then, I'll check to see if it's being used anywhere, if not I'll respin this patch. So problem solved for everyone :) > > Also, if we do get rid of this, then __alloc_pages_bulk() can lose > > the "list" argument. > > Yepp. Yeah the respin will take this into account, if the function remains unused in May.