From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A01DC001B2 for ; Thu, 22 Dec 2022 12:16:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7BA25900003; Thu, 22 Dec 2022 07:16:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 76854900002; Thu, 22 Dec 2022 07:16:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 62FDF900003; Thu, 22 Dec 2022 07:16:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 528FA900002 for ; Thu, 22 Dec 2022 07:16:43 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 27BC11C62AA for ; Thu, 22 Dec 2022 12:16:43 +0000 (UTC) X-FDA: 80269840686.10.9626D54 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by imf24.hostedemail.com (Postfix) with ESMTP id B17D7180007 for ; Thu, 22 Dec 2022 12:16:33 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=temperror ("DNS error when getting key") header.d=alien8.de header.s=dkim header.b=XjXW5Z8o; spf=temperror (imf24.hostedemail.com: error in processing during lookup of bp@alien8.de: DNS error) smtp.mailfrom=bp@alien8.de; dmarc=temperror reason="query timed out" header.from=alien8.de (policy=temperror) Received: from zn.tnic (p5de8e9fe.dip0.t-ipconnect.de [93.232.233.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 55D831EC0715; Thu, 22 Dec 2022 13:16:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1671711370; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=o/VXYlruW2xooSsXWnWYyMCr5jlbGKrzKBa2cG6Y2Ww=; b=XjXW5Z8oYRDLihGMfhUQO8kyU/QX/4pvN9dV0v1Cbyb493Z8bynjeUG11y+TBLchroJzlt VoGxu2Y+sifUYuL4UyuR2V1uyTCWlmVn5DzYni+p08sQRqsFXqgEsVzXToa9qqwUh5n8rm k8g04qR1xN0LQsSA70L2TEiGH9YC8Fw= Date: Thu, 22 Dec 2022 13:16:04 +0100 From: Borislav Petkov To: Michael Roth Cc: kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, wanpengli@tencent.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, dovmurik@linux.ibm.com, tobin@ibm.com, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, dgilbert@redhat.com, jarkko@kernel.org, ashish.kalra@amd.com, harald@profian.com, Nikunj A Dadhania Subject: Re: [PATCH RFC v7 01/64] KVM: Fix memslot boundary condition for large page Message-ID: References: <20221214194056.161492-1-michael.roth@amd.com> <20221214194056.161492-2-michael.roth@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221214194056.161492-2-michael.roth@amd.com> X-Rspam-User: X-Rspamd-Queue-Id: B17D7180007 X-Rspamd-Server: rspam01 X-Stat-Signature: afth5n6r81funnkfh86dj5jq4hwy6hyd X-HE-Tag: 1671711393-569217 X-HE-Meta: U2FsdGVkX19DFy228E/DKy6YkmKYCk1XDVlIbAWCP5VWSQm1cRoSR4N53YWfA+d8H9IIbDVs5PfUZZIMD9ohmJqYxLoIqW2THIzgv4SaLXvm4v00XheDyKNh6/HsMPBba737Gout8DUpy9tGnjmGHB2JsXPUf/GkKup3bfD1OctFIgecuTZI4im5374kHTQ6leeAa6usAiC1mRikzz/exVLiY65asDAWNqEsYjzDo7DK+L2OtSAjg4UFezo5AaG2HCitnavAL4bxzuX9cFMuJM0bDpAyB/hmcBiPONX3XfFCy6N1GAwGXFcjluMsunRODWMw6BY1DJu4zx3QucdKxsJvdOza7wg9dj+PCAOODLqoJNuYDr5PrZxEXbp2+0+WOANmTCEJheuwRZJ7qqfKURwuBvSSzdDdrZmltWI8J2wktMzznsC7KQRReHkoEMps7fzvPyShW8NUfsWXZi2Q78lsYZedjdxl+OYhNnGX0XuobLBCdytVfoAt4QOjaL15p8f6PbLyRl1bzFbk/S0yp+/nEOvrAyWbo/6Y44N+GC+s91Okfl4gc9mgTEAa/Gt/e88eeKyn/cfAw0Lj7ca4lHHTD1VFflXSVUCZmKnZb8wzGp+aHnVNMxTSKvHw3EnfGBbkkci8gKvZztVa/l/oSNpF2Mce9UHfin+apHmvhOP2+Ki6fKtbrEQLsbG4fcunZah1jNQEDLzb1U01SiSXlhUDVNZ9srNkZxDiM6QHnk0lseiWsV84rbgPD9HZLo+U+KOtV7pUlQj2rXq6Pc52NLLJWew1PHuc0MfsZqsgA0uzLnrfkXOfUdK6qETDLhfCryrJGhRN+GWI9WLCZdbX9gq1og+5GS+6cdLsKny2t9y9bXNZ/pSG8LBt7nmuPvlyN5iUP3YljwLacGtgwuU79ZgW/b3+08W+WnrYKe/USLw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Dec 14, 2022 at 01:39:53PM -0600, Michael Roth wrote: > From: Nikunj A Dadhania > > Aligned end boundary causes a kvm crash, handle the case. > > Signed-off-by: Nikunj A Dadhania > Signed-off-by: Michael Roth > --- > arch/x86/kvm/mmu/mmu.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c > index b1953ebc012e..b3ffc61c668c 100644 > --- a/arch/x86/kvm/mmu/mmu.c > +++ b/arch/x86/kvm/mmu/mmu.c > @@ -7159,6 +7159,9 @@ static void kvm_update_lpage_private_shared_mixed(struct kvm *kvm, > for (gfn = first + pages; gfn < last; gfn += pages) > linfo_set_mixed(gfn, slot, level, false); > > + if (gfn == last) > + goto out; I'm guessing this was supposed to be "return;" here: arch/x86/kvm/mmu/mmu.c: In function ‘kvm_update_lpage_private_shared_mixed’: arch/x86/kvm/mmu/mmu.c:7090:25: error: label ‘out’ used but not defined 7090 | goto out; | ^~~~ /me goes and digs deeper. Aha, it was a "return" but you reordered the patches and the one adding the out label: KVM: x86: Add 'update_mem_attr' x86 op went further down and this became the first but it didn't have the label anymore. Yeah, each patch needs to build successfully for bisection reasons, ofc. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette