From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02A04C3DA79 for ; Thu, 22 Dec 2022 10:03:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3D4D9900003; Thu, 22 Dec 2022 05:03:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3847B900002; Thu, 22 Dec 2022 05:03:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 27BF9900003; Thu, 22 Dec 2022 05:03:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 17A15900002 for ; Thu, 22 Dec 2022 05:03:55 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id DBCBB140E05 for ; Thu, 22 Dec 2022 10:03:54 +0000 (UTC) X-FDA: 80269505988.26.56870E0 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf06.hostedemail.com (Postfix) with ESMTP id C94CC180003 for ; Thu, 22 Dec 2022 10:03:51 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=c8W67kk+; spf=none (imf06.hostedemail.com: domain of BATV+8cdad1493968676a6672+7060+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+8cdad1493968676a6672+7060+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671703432; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AcGWlY/OlcIqRRlXKkZFQDTC1PCQwdSXbxSac1YmIAw=; b=ye32eS9FFl2alKlTRpQ2TsQ6U8vPdZOoWG7eww3fnUzPgbYkAv4QtdMJlJ/tuLBBMRFUQ7 qK7c0TJBS2oJE+2Bcg2it+pCUdt1U3ggg7Yx1/FUPVP7rquRign/baZfBbcE0yNyrL+f67 rvyAOSOg8LdIXwJBHOOA4JMZF3yZNBg= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=c8W67kk+; spf=none (imf06.hostedemail.com: domain of BATV+8cdad1493968676a6672+7060+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+8cdad1493968676a6672+7060+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671703432; a=rsa-sha256; cv=none; b=sZ0MX9OzRPUuin7LMo1RXpAmUbNaQlVDCZ7jDmUo2HrzDeltlR7Rb8X6DbOXC4sjEHQMUk 4EyDZJ/FUpNBsRj82U3EFZfjt6v6FX0daYS34T7LNdRRUUUlxKLPleqdc3iLJf45EIfyG4 vojJt65Fb3deOCt1XdRc6zqv3dH4Jo0= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=AcGWlY/OlcIqRRlXKkZFQDTC1PCQwdSXbxSac1YmIAw=; b=c8W67kk+9LDCTm1Xxhbo56EVSa aYfahx8x0YW37wDaRHIhW9TUmqtTt5AqKt2LPLLIYIxyHTkpk1r1kZ/xuabYK219wLFOE2O7tyfzU JlL7QzUimYjIqy2CkMDuDq/kTrG3BfIoSlb4bVWooO15QzXOTGy7CBVATImtvLfSQUXcXw56cUR71 3ab16bHGqPlA5A8Qso9ugvrkWJzD34456504wV4fYr/5dLa0UlYcHkH7KNn9bVIM8lRB+9AWBdYtX +BNdwkht3S0beiTbHUR4fZNNzJZvFcUnh8kGWqgLwyNMmTAX026aZvsnh8evG8myn0WZzIREZR4xN 477butnQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1p8IQU-00A9X8-UY; Thu, 22 Dec 2022 10:03:46 +0000 Date: Thu, 22 Dec 2022 02:03:46 -0800 From: Christoph Hellwig To: Matthew Wilcox Cc: Lorenzo Stoakes , linux-mm@kvack.org, Andrew Morton , linux-kernel@vger.kernel.org, Andrey Konovalov , Ingo Molnar , Marco Elver , Michal Hocko Subject: Re: [PATCH] mm: remove unused alloc_pages_bulk_list() Message-ID: References: <20221217001554.554913-1-lstoakes@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: C94CC180003 X-Stat-Signature: 81yw3aht9m95mcfnyt57aguuatzjdpbn X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1671703431-373501 X-HE-Meta: U2FsdGVkX1/6lGzoB5VZSxWHEsjm2gCgbWMohgZQRCYr60BfW2+am6OZg6yRkQDjZxaHPCQltibr7jKQRqKA/bCQ8zemtWvnHqGuC+TxQ3I9Tk+W5cdhZT3FO4hEEteK1WCHFhOTDeuGmD0hpOigjSCfsrLM8OqXXcsOReUopkH+YWhwNsgnb6RPmFlqyno+YY8j5JcHGvY+B8+9UEFP+HdpiOMP9yN0WEYyREF0V9uoqkWGbwLmLNd63I7fxw8uAL4hnkdZzezi3YBwLAlQayuZ7CLRGMs5Y6r/2ZkX6DQTaQNxS3OcDdK8bq4USq0FNuYxhEugeekAuEEscO0ndurawqaRzVV1tii4CvcOtAAcTRSgIjzmVtRkN8d2O3A5l30D7+/CJazjbcqwUjMLieb++0mWbOlSZ98zV4OL6ZOwlwcS3uFT0jO8T0ssJ4yoxpW+BGw/go19uUPVoJnPzcUdrti+3S4zLNE+Wqp7hyuWpgNhcnbMt0fcvRMXZHO+OXFo4EGCFxdXzynLHUG9Rm02YfXcaessVu58dRRl1JMGoFVvemBgpsTyv+/xlXBFGEAt3oVft4KL1s1tGECYpDrDO3DtEAReSDZocaGIlwNRrGDa1uGPUkADQ5C4E4QIWNl9/kEDNKhl5QPCzeOHUhSoELNS9enNMiVdkkdyglYeKwyic9GaboauaCVTUqv1CoOeZkZh9ISu3D6CTKxCImyPff/O7j8ZfcUrjbgd1eXdQ4bdiu09GMywuM9+XPs4tCKquH2+XSD0ceH/hogxmFwgJqBDuObd82UyCB7dhC2l2b3DXoGn+SJtqVJB/gszUZgte7W/5FiMh+Qtq4ZsWu8hJ6bR182y33YruGWAADyj639JHeStwbe91ZQ1eNIBMJOt0XzNccq/Ke8wrdNjHIDddpKCK9nh5M8QUE01qmFi7uwp0RC5Y4EgdwJT+AcfLzgH7Mv7+dno4uhRQlX qIVeYgr/ Gb+lYKqaUJWJNficP80Y3I39KBF8OwCJcoN+M+8I4YBR70KMCTcO4u+2ZQOzOpmGXOhS3VlBJ00srBzDsMBB2Npas1Wcf3EBOXiWrVqFfwbSrZ53E9fx26+GXGBYrmWvz2MT3KxeEvweXrV0z3Xu6NlojmNwuzfPHj/n9OBfdMSW0UPiI66Z1pnwTew== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Dec 17, 2022 at 04:56:03AM +0000, Matthew Wilcox wrote: > On Sat, Dec 17, 2022 at 12:15:54AM +0000, Lorenzo Stoakes wrote: > > This function is not referenced anywhere else in the kernel, remove it. > > I think we're waiting to see if any users show up. It's only been 18 > months or so, so perhaps wait a little longer? Is that being snarky? :) We generally don't add dead code at all, and certaintly don't leave it around for a year and a half. If anyone really needs this we can add it back. > Also, if we do get rid of this, then __alloc_pages_bulk() can lose > the "list" argument. Yepp.