From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4566DC4332F for ; Thu, 22 Dec 2022 08:56:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C2262900003; Thu, 22 Dec 2022 03:56:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BD227900002; Thu, 22 Dec 2022 03:56:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AC3BB900003; Thu, 22 Dec 2022 03:56:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 9F2D0900002 for ; Thu, 22 Dec 2022 03:56:35 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 6308F80E09 for ; Thu, 22 Dec 2022 08:56:35 +0000 (UTC) X-FDA: 80269336350.12.CE2455B Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf18.hostedemail.com (Postfix) with ESMTP id D66601C0008 for ; Thu, 22 Dec 2022 08:56:33 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=z5juutT7; spf=none (imf18.hostedemail.com: domain of BATV+8cdad1493968676a6672+7060+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+8cdad1493968676a6672+7060+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671699393; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zifJKiMitrlfByU/WAVetRdSoX9cyLEqZ48bLhSjFoE=; b=0rjm2FZh9BOZs44Mh1bzLWV46E1y/7T1Bu81mQP5lL7kASQBrbxDB850ceSoTYwym7mGSh tHdp0ztUt7OWurER9EaC5K75CD+AyVovpgZ39ZyodjwJlkaCYACkk9f0SNMifF9S2B9ONe XrBdD63tFqOg5j6KEzKW5UVH0NsUeVw= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=z5juutT7; spf=none (imf18.hostedemail.com: domain of BATV+8cdad1493968676a6672+7060+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+8cdad1493968676a6672+7060+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671699393; a=rsa-sha256; cv=none; b=ZAo9iS4OxmoqkO1I0rPNHRchGuWT0nfzTsCHmqdMSyelNmkjuWakz2vGHppvM02vVOOhBK NIOuBx4YYol80R3gYy/JHClqbLmou3KpTBH8ue4sbYeIP+MKj3h3TkCp3GjASjkw26qNgj b5kbkpz2bUGpUUib+cpgbsI8rQ6zzfU= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=zifJKiMitrlfByU/WAVetRdSoX9cyLEqZ48bLhSjFoE=; b=z5juutT7hBzPnwRbRbqEy2ICxR bOwEe/myuE1UiHzUvAaVyYt8mUQ/nFTH869usF8sz1lWo+QnG/A/8WM8JpJNweZMFDzbEMvYNStvs ZqnjOjDWwdKLWL3UvkkhplOcEgNLOxsMV0W1OjMJ9q8vFZeyMsC2X1vEOpldBpH/hqeDJcRwSQ8wG X5ckuMnUIc50sBZ6XLh5zqkfCswR3LpCPBzd7Jjo1fBbLo0boXMMWqPWKksm/0bLPdNyvzHDpwtkE Ppsp24OTkxzlhMSVWnoat0izfAw8s0z/O15BtCmavvbXthst32mXP8hOiq57dYn1uunn6TpfRvpHI O7Ms1ARg==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1p8HNN-009NHh-IB; Thu, 22 Dec 2022 08:56:29 +0000 Date: Thu, 22 Dec 2022 00:56:29 -0800 From: Christoph Hellwig To: "Uladzislau Rezki (Sony)" Cc: Andrew Morton , linux-mm@kvack.org, LKML , Baoquan He , Lorenzo Stoakes , Christoph Hellwig , Matthew Wilcox , Nicholas Piggin , Oleksiy Avramchenko , Roman Gushchin Subject: Re: [PATCH v2 1/3] mm: vmalloc: Avoid of calling __find_vmap_area() twise in __vunmap() Message-ID: References: <20221221174454.1085130-1-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221221174454.1085130-1-urezki@gmail.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: D66601C0008 X-Stat-Signature: a533asqg918i8h7uppca6hfcajsmkzm7 X-HE-Tag: 1671699393-117158 X-HE-Meta: U2FsdGVkX18dpPZVE8AqloeUPiDualdj3xcaTaIOIjJMEp/a9AaW3fwLx8qxoZnV1juzBPHVx90i/vuxkNX2av/gP/EJnlXZwdDgXFZFswOjnAmj7qKLsdq2pSV1KFIkaBWHQ1qpIzbDNBeSeeAYlYtWDD6Ndr1KUSjitrSix6yUob3Qf7CQIrT3vNe/PRX0IUr2ZvHkOWlN5ExQqWsa69roOOvUalGS+kj55J5K4BgyzP7RJLiK1Pm1Oyo4iSM8dzdMO1w4Ci/GrlmV8uFTSNbPHeASbphrbUmfvQMcDzzUi7zhMo+bIvBR2agoY4Pw9WbG3CY6fUvIZxPBFESY7pfsXK1J+GE9IYB2hchpYzlh3+LazCDOOxNjUv1g0dcQlUEojIQOtJHN+gqXNvWkFwcBeE6fohkCcAs7ExtmLHhlrYYiWemthTtOimXTjbAHDa6Ox4ImBxUB/2wnJ8w2oNxlhbuIPVwnpCOIBvaIuEs9jBsTzaif7AmqDm0qtSU0iqzFiIlN4VRjR8B5S1zTA8ZH2T0w7JwvHoD6tr/OsR2sBkLAXJtj4IT3mkesR0QSKZbKt6sSu4SU/zg3hV2AF2ZtdnmJ5r/kg1bGvlvjgmRKLNhwW0s3kmqmjEUE+5rfvbbPOX7m1Sn1l6eL8iu1G8shUScZDwTwZtgK89jcAvcv+rYIy1EaJ7esl29V03MQHtyKeluDj/u6o1ncomrzHdKQmnTKavTjySkfOqHTQJuNuO+gjEY7aYuDlcsDWhhIyfKVz2+KLdtVTiDQj+xGc6Hn6Q20/1QP+jhEqNwh5em+59iTWn6JzlblwwrbOJGlARZNgdx9A0IoiXyaoY5ceLoDX7lRuorL7a38UZNS9WUyjZ96g0jl2tWrsGszzKmil0NuuFLSxT0Z3lO0zVpTBcRg3n10jtOs6nWhgQ57RBS3jCApqObHU++CYhdFYTAfKyvFM876xWi9D00nhnq xJ5fG5Q0 E7URp116jzbNc1jO95xU5ApSCwgdPwpQ1yvfWvdUT3+kWCUriO/AIwpW7OSIFgder9/h4Vg2rhOgJWQFmGkcA/XJ6azrBRHCGfkqrc0tX2P0ZqDNhudeAHNn0ulSUVQnXUD0475UqvKQK7vCEtXRVTdfug8DGkYkSWr8KevBBofiMN6ljoHoGWJNMpA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: A sorry. I need more coffee, this is not the cover letter, but the patch that introduceѕ find_unlink_vmap_area. > - spin_lock(&vmap_area_lock); > - unlink_va(va, &vmap_area_root); > - spin_unlock(&vmap_area_lock); > + if (!list_empty(&va->list)) { > + spin_lock(&vmap_area_lock); > + unlink_va(va, &vmap_area_root); > + spin_unlock(&vmap_area_lock); > + } As mentioned before, I'd much rather move this into the callers. > + va = find_unlink_vmap_area((unsigned long) addr); > + return __remove_vm_area(va); This can drop the va local variable now.