From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE843C4167B for ; Thu, 22 Dec 2022 01:21:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4DED68E0002; Wed, 21 Dec 2022 20:21:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 48EF68E0001; Wed, 21 Dec 2022 20:21:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 309768E0002; Wed, 21 Dec 2022 20:21:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 237DD8E0001 for ; Wed, 21 Dec 2022 20:21:39 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id E0D2480DEB for ; Thu, 22 Dec 2022 01:21:38 +0000 (UTC) X-FDA: 80268189876.23.5210E6F Received: from mail-qv1-f53.google.com (mail-qv1-f53.google.com [209.85.219.53]) by imf04.hostedemail.com (Postfix) with ESMTP id D797140012 for ; Thu, 22 Dec 2022 01:21:36 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=l2fa+q+F; spf=pass (imf04.hostedemail.com: domain of boqun.feng@gmail.com designates 209.85.219.53 as permitted sender) smtp.mailfrom=boqun.feng@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671672096; a=rsa-sha256; cv=none; b=kuE39SsYnwmhVqhPq2FT9bZyTF2rnbjSJMmiM18RT9daYRcJQopkoPxqNL0uP6kj+3hXGq rjZXcm9lv3Uy/g+f8P6Oxwh2mumqHsYxfMl4JFANatWaNeNkoCcWmwPou3sSucUxh7a3Ac 3MNubvXIr2nCTbak4auGHEJOSvZshrg= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=l2fa+q+F; spf=pass (imf04.hostedemail.com: domain of boqun.feng@gmail.com designates 209.85.219.53 as permitted sender) smtp.mailfrom=boqun.feng@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671672096; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1vQ+zYR3T/MLmRvx1y4HrhYHCm/YFhPZhfUkcUcESfM=; b=K3JGL0Y7JGoQB7YQP1y2khWyBUQNOZMkFFY+Wvws4kd3Lkfe/Lqd/chNvhqdxc0bWr7Ehb vLN+YejVek0Y32XfIehYCOVhqGuaTMLe1bWLtuCvr8RFRbfgIzEfmmzSwhLKK7FI3HuhI1 QQjdDmYy7TTkA+f5Yq5io42ZP0N4ijk= Received: by mail-qv1-f53.google.com with SMTP id a17so340338qvt.9 for ; Wed, 21 Dec 2022 17:21:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:feedback-id:from:to:cc:subject:date :message-id:reply-to; bh=1vQ+zYR3T/MLmRvx1y4HrhYHCm/YFhPZhfUkcUcESfM=; b=l2fa+q+FEd2XVftJdKunAWsH1HG7S8dBsHb+pyQnkCSX1TXkuXti8JKHEfARmsSWRT xQebS6MZkDhnAZE1A3MSyIEK1eUPZUe1gprb22RcFQ//PuymRzd8BLNOtFAGp/a61FTx 57JSoFp9tNTtN1QcKe76hmTtf/9LzGx+KUuDqVsOlyBa3P8Z9dneruz+vGAafZacrKIF 5D4qdPPjWSMkoveXI7RPaxRIbWKtRPn50A747wMHhLLoo8U+VfMCok3edYL+wnhGBTCJ v8NDSlV/3lrChQ+UVwl5AoSSDCCE4tVU9WZAvbYyVr00y/GTw1B5kOj7gmspi/N26quY /XKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:feedback-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1vQ+zYR3T/MLmRvx1y4HrhYHCm/YFhPZhfUkcUcESfM=; b=kQEU520fdFgBCMEqb5jD74e4BFX3SiA4t+oztPidBaTcZsuB2Y22aUJnKC8pl6ep5H SEx/o5ytNJoRm5gc9w3SusMPCmXqHNQjrN6iMtKewh+yJpwOxnf+Wo23XlQON8TQ4juP jxw3U7vHm6C8HgYq0ivRRvLweyjlcvtlJza7zc6tGgPzR5vkRPFVhos9W2AALEYgglZ9 1yJqOgvNIQWJIidJiqBIB0tCz5UyxYkuSKEsHuzgIZ9tiqw0TxeVGUmb2KizNrjVApUB xHHLtVT3+msJieatamQF/UbwMpdKiKis5LYy0xGwob8e9MmM95KxGN31pQj80/WJfSWl txOw== X-Gm-Message-State: AFqh2kpo0vtITCrXDJAHz4LiIshAjS+YPH6wm9D2ZWJopWjClAKQRfRP LnJ0cQw5ftjOqfygu5v1SPA= X-Google-Smtp-Source: AMrXdXsShUh4L0yNGW8xONTed3Jku8Vj2tplYIwpahvEr5EHAURbNPUd/5CxhDGXUPZFyuLmJTm1qQ== X-Received: by 2002:a05:6214:1bcd:b0:4c7:595c:993b with SMTP id m13-20020a0562141bcd00b004c7595c993bmr7380408qvc.40.1671672095984; Wed, 21 Dec 2022 17:21:35 -0800 (PST) Received: from auth2-smtp.messagingengine.com (auth2-smtp.messagingengine.com. [66.111.4.228]) by smtp.gmail.com with ESMTPSA id x18-20020a05620a259200b006fc2b672950sm11762886qko.37.2022.12.21.17.21.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Dec 2022 17:21:35 -0800 (PST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailauth.nyi.internal (Postfix) with ESMTP id 53E7F27C0054; Wed, 21 Dec 2022 20:21:34 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Wed, 21 Dec 2022 20:21:34 -0500 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgeelgdefhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpeeuohhquhhn ucfhvghnghcuoegsohhquhhnrdhfvghnghesghhmrghilhdrtghomheqnecuggftrfgrth htvghrnhephfetvdfgtdeukedvkeeiteeiteejieehvdetheduudejvdektdekfeegvddv hedtnecuffhomhgrihhnpehkvghrnhgvlhdrohhrghenucevlhhushhtvghrufhiiigvpe dtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegsohhquhhnodhmvghsmhhtphgruhhthhhp vghrshhonhgrlhhithihqdeiledvgeehtdeigedqudejjeekheehhedvqdgsohhquhhnrd hfvghngheppehgmhgrihhlrdgtohhmsehfihigmhgvrdhnrghmvg X-ME-Proxy: Feedback-ID: iad51458e:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 21 Dec 2022 20:21:31 -0500 (EST) Date: Wed, 21 Dec 2022 17:21:09 -0800 From: Boqun Feng To: Peter Zijlstra Cc: torvalds@linux-foundation.org, corbet@lwn.net, will@kernel.org, mark.rutland@arm.com, catalin.marinas@arm.com, dennis@kernel.org, tj@kernel.org, cl@linux.com, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, Herbert Xu , davem@davemloft.net, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, joro@8bytes.org, suravee.suthikulpanit@amd.com, robin.murphy@arm.com, dwmw2@infradead.org, baolu.lu@linux.intel.com, Arnd Bergmann , penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, Andrew Morton , vbabka@suse.cz, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, linux-crypto@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org Subject: Re: [RFC][PATCH 00/12] Introduce cmpxchg128() -- aka. the demise of cmpxchg_double() Message-ID: References: <20221219153525.632521981@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221219153525.632521981@infradead.org> X-Rspam-User: X-Rspamd-Queue-Id: D797140012 X-Rspamd-Server: rspam01 X-Stat-Signature: bgw35sogwaj7he5p4dssdd5cosiw8z8p X-HE-Tag: 1671672096-962084 X-HE-Meta: U2FsdGVkX1+cOp1eLoSE4+HAcRevjEkRY0E5+gsgs0usJgga6zRwAZbHIE5nQ92czLW1oCUBmblcRyAtYF/3rSNhG6EbDl7WGmngh21JK5p4i536Jx7wpOI96jviNvGnHyBlP9oeCNzNRBOWvwMCng+MkpJbQdZ4XbGWQQU8uqOjR4KtjKWaydKAIRVW5WgOuHkgOqJpkn9pder+1u0IkZz/5ylwYDOMZ8YEB0a6dLYeiFubDLNSfJzx3W324jHSJw7xbQgc71tvrUsbFmilujOO3nx0Nnc7ubM5IOZEXRSd7bPOFVFP7nSSD/KyEDcD4XxhC3R8XoEB1mRwOY8XhdW4TXHohoHvRg1UVZjqHBEDX2JxBjeQzVy81XOrD/pPpAy/T+lVTMXx2LvPUiqkaiujmxNel+m3ZfMlOpaISC05MDCnkLJ34QjtRXlCjIjukWDrcSQ1S0ixNT4DrVEPByXPBNImJlgq2IUQmaZfGRZbMswZqM7+4inj4siY+Nq6HuM6FWLhl7Qk24G/o3XTJtA6e/CqZucc/pktcDXb1B2T0+eAje6Nc8jXQ2mC1VzXZA56TcgUTcyzjcWk5tQltWamAbRYR0D44qt6QA4jf3SyNPludxMzljDy0vBtlVKYJB9hrPzk45Fl9QUU6zX4o+MukpZG0P9QLFudRsXryrd3dVowQRlkH8/1Phw2ZG8vNsKZ5an4g5XB6LNhFkeLYBNl2bWiq4mBQFT8P6Ali2dk/YVaNSPhEWSvnHj35ASN3GMKcYHOaKbxv42J0pCeX3OpuNbmq2VnFSQZmSJ3edemdkRUJbzPgxk5ihsB7FQwhN6K38LDC/iWUcR6TdtweYNJs/HrBGVu94egSXHTnsgcsN+Y1hFWGJVbgTfZdVCSLvK2H4py2FLiFZwMQ7lX92uATEjFuB2Ew4TA8PU4pPA0/NkIwNmTcmppc41fflICBTd7Be7mBiCriwmooV9 TbNSO9t3 T4U4TuhbEjUzTcPlC9u7VglgEqc95wxwKsmCxzSutaAFxZSsqjBzopkoKzKVQS8NpF/75PppoKOj68NYnIWajBc0vdT18fiD9Idw6RGe/HeXgm8kTqu4xMMr6vNLXzXidzZDMhIfmkTOG6hO05kANGsMIwf46Ss7bmlQEnQz8FG9QmO3JttOJsZPq5NXKgZpuPHCa8phDK3p7RuRE3oj+8UNjH5wDvtGFKJzs9Tqek1AIijA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Peter, On Mon, Dec 19, 2022 at 04:35:25PM +0100, Peter Zijlstra wrote: > Hi, > > Since Linus hated on cmpxchg_double(), a few patches to get rid of it, as proposed here: > > https://lkml.kernel.org/r/Y2U3WdU61FvYlpUh@hirez.programming.kicks-ass.net > > based on tip/master because Linus' tree is moving a wee bit fast at the moment. > > 0day robot is all green for building, very limited testing on arm64/s390 > for obvious raisins -- I tried to get the asm right, but please, double > check. > I added some test cases for cmpxcgh128 APIs, and found two issues. I will reply separately in the patches. The test cases themselves are at the end, let me know if you want to me to send a proper patch. Regards, Boqun ------------------------------------------------------------>8 Subject: [PATCH] atomic: Add test cases for cmpxchg128 family Besides for 32bit and 64bit cmpxchg, we only test via atomic_cmpxchg_* APIs, add tests via cmpxchg* APIs while we are at it. Signed-off-by: Boqun Feng --- lib/atomic64_test.c | 41 ++++++++++++++++++++++++++++++++++++++++- 1 file changed, 40 insertions(+), 1 deletion(-) diff --git a/lib/atomic64_test.c b/lib/atomic64_test.c index d9d170238165..7f79d0704ba8 100644 --- a/lib/atomic64_test.c +++ b/lib/atomic64_test.c @@ -76,12 +76,19 @@ do { \ BUG_ON(atomic##bit##_read(&v) != expect); \ } while (0) +#define TEST_ARGS_PLAIN(_, op, init, ret, expect, args...) \ +do { \ + __WRITE_ONCE(n, init); \ + BUG_ON(op(&n, ##args) != ret); \ + BUG_ON(__READ_ONCE(n) != expect); \ +} while (0) + #define XCHG_FAMILY_TEST(bit, init, new) \ do { \ FAMILY_TEST(TEST_ARGS, bit, xchg, init, init, new, new); \ } while (0) -#define CMPXCHG_FAMILY_TEST(bit, init, new, wrong) \ +#define ATOMIC_CMPXCHG_FAMILY_TEST(bit, init, new, wrong) \ do { \ FAMILY_TEST(TEST_ARGS, bit, cmpxchg, \ init, init, new, init, new); \ @@ -89,6 +96,14 @@ do { \ init, init, init, wrong, new); \ } while (0) +#define CMPXCHG_FAMILY_TEST(bit, init, new, wrong) \ +do { \ + FAMILY_TEST(TEST_ARGS_PLAIN, _, cmpxchg##bit, \ + init, init, new, init, new); \ + FAMILY_TEST(TEST_ARGS_PLAIN, _, cmpxchg##bit, \ + init, init, init, wrong, new); \ +} while (0) + #define INC_RETURN_FAMILY_TEST(bit, i) \ do { \ FAMILY_TEST(TEST_ARGS, bit, inc_return, \ @@ -109,6 +124,7 @@ static __init void test_atomic(void) int one = 1; atomic_t v; + int n; int r; TEST(, add, +=, onestwos); @@ -139,6 +155,7 @@ static __init void test_atomic(void) DEC_RETURN_FAMILY_TEST(, v0); XCHG_FAMILY_TEST(, v0, v1); + ATOMIC_CMPXCHG_FAMILY_TEST(, v0, v1, onestwos); CMPXCHG_FAMILY_TEST(, v0, v1, onestwos); } @@ -155,6 +172,7 @@ static __init void test_atomic64(void) int r_int; atomic64_t v = ATOMIC64_INIT(v0); + long long n = 0; long long r = v0; BUG_ON(v.counter != r); @@ -201,6 +219,7 @@ static __init void test_atomic64(void) DEC_RETURN_FAMILY_TEST(64, v0); XCHG_FAMILY_TEST(64, v0, v1); + ATOMIC_CMPXCHG_FAMILY_TEST(64, v0, v1, v2); CMPXCHG_FAMILY_TEST(64, v0, v1, v2); INIT(v0); @@ -245,10 +264,30 @@ static __init void test_atomic64(void) BUG_ON(!r_int); } +#ifdef system_has_cmpxchg128 +static __init void test_atomic128(void) +{ + long long v0 = 0xaaa31337c001d00dLL; + long long v1 = 0xdeadbeefdeafcafeLL; + long long v2 = 0xfaceabadf00df001LL; + long long v3 = 0x8000000000000000LL; + + s128 init = ((s128)v0 << 64) + v1; + s128 new = ((s128)v1 << 64) + v0; + s128 wrong = ((s128)v2 << 64) + v3; + s128 n = 1; + + CMPXCHG_FAMILY_TEST(128, init, new, wrong); +} +#else +static __init void test_atomic128(void) {} +#endif + static __init int test_atomics_init(void) { test_atomic(); test_atomic64(); + test_atomic128(); #ifdef CONFIG_X86 pr_info("passed for %s platform %s CX8 and %s SSE\n", -- 2.38.1