From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83092C4332F for ; Wed, 21 Dec 2022 05:18:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F23A98E0002; Wed, 21 Dec 2022 00:18:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id ED3898E0001; Wed, 21 Dec 2022 00:18:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D9B5C8E0002; Wed, 21 Dec 2022 00:18:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id CB5D68E0001 for ; Wed, 21 Dec 2022 00:18:25 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 7FE3DA06F3 for ; Wed, 21 Dec 2022 05:18:25 +0000 (UTC) X-FDA: 80265157770.29.5E77B68 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by imf22.hostedemail.com (Postfix) with ESMTP id C4227C0008 for ; Wed, 21 Dec 2022 05:18:23 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=XmMwTMS8; spf=pass (imf22.hostedemail.com: domain of vernon2gm@gmail.com designates 209.85.216.49 as permitted sender) smtp.mailfrom=vernon2gm@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671599903; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SjjAILO76gwFJzalKA7C4W/3VdOviisk5FdZMxKgrAI=; b=lr3o9jUkEMAvSxsS//wswAhGwMampLW28o6SHoILkErQbe/roM3N1c4LbHX87xl8Z805yu 9+tmv3fGoRopWQ39N92gxu3b2e0iyhsJuK3AZYHasoCsOero+ylrMJsuFeGSe7k5Pi/3AM kcBAiBKxywocQjRARC5Ci6yrfDtKwYM= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=XmMwTMS8; spf=pass (imf22.hostedemail.com: domain of vernon2gm@gmail.com designates 209.85.216.49 as permitted sender) smtp.mailfrom=vernon2gm@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671599903; a=rsa-sha256; cv=none; b=J6ZHwYVuaZhoSzZDJcmIZWTWtju5GYkV7BlFptGs1EnI1hgR3TtWYKFmk1iwPgAoh2r2pX b4KXDip9UB10xeJRU4JxNsrN5e/udMK4InjOzJKwAgU/FlaRj3xAXUFt9ggYgQoGqn6oW7 hkLWwh6vhQCi/Ruoch0mkgr/I/T3IeA= Received: by mail-pj1-f49.google.com with SMTP id t11-20020a17090a024b00b0021932afece4so1027548pje.5 for ; Tue, 20 Dec 2022 21:18:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=SjjAILO76gwFJzalKA7C4W/3VdOviisk5FdZMxKgrAI=; b=XmMwTMS89CWS2BNg+zuT2zxeKpu+7qb/BqAozrzZ68VD1g+fX0BH77Z1bLBJdCFbEc mjrpxnMSp0tFAXcMASrKlqoiNLEiK8I90f4W4/a2PREBpBPFDrFyx8sFsW9BdcM4MuvN GEkXUYV+6oTd5RqPyPMwzVPLZJTxWrdloOYUaLiY0ZR7eeMKHblrA5ROnE1npa8MOido fTMmH39C0POyFDoV5hof4DgLk8zRt/sgh6JlM8Di+ui2x80M3uwPohfETAPKeVFUIYR8 h6yRHxm1yL+fYvE47flJ3ceCcN5Is94heacsl4ssCpnd2booZAqntG3zCK0UahP4V3+2 lyCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SjjAILO76gwFJzalKA7C4W/3VdOviisk5FdZMxKgrAI=; b=tSexFD9dS+WkgSNRRMVeER7dqdSDjHomcb2kciUPzQ8fmoRmeH1FGT1X5TEKTdH3XU +/YllUU0PPk+RI5R4X0h5brrv5Sf45IbPMJ1l6mDMfuOhvr91uzQHcW8+u9hLPwKAqkU TszeTR4Pv8t2Ozr9KQg0krSEzk0MGQDTyFbRUvFzIpiDivnWnKTpB1Ik93iGTjB1mxg3 nQcXmxs8LEi7/dpSmB3rjs3rXDmDuSplIMDLhpZ6VS6jRMroU/pebmB6wq1/rjInzitb SMgZnrlJRTImp4F8LDt7LcVuiYJLBZ/bChXgIULv4ObnTWEHT/4Z5hqXWpWZgUuIxBSd wPDA== X-Gm-Message-State: AFqh2kpTX5xJELDafaleMN+QY8Ve2DH+T5ceR0ypktvP56RXjTovMCB4 15xjPp2wriAq5Bsie63xsmo= X-Google-Smtp-Source: AMrXdXu2dESGcqpW7Q2T6BQy1ZlnHjdCa5+s4KGihXxODCx7UmJTKyb7w34ncGfoL1xYeiP85R/q7w== X-Received: by 2002:a17:903:3307:b0:191:1fc4:5c19 with SMTP id jk7-20020a170903330700b001911fc45c19mr645584plb.48.1671599902621; Tue, 20 Dec 2022 21:18:22 -0800 (PST) Received: from vernon-pc ([114.231.52.81]) by smtp.gmail.com with ESMTPSA id bc13-20020a656d8d000000b0043c732e1536sm8973300pgb.45.2022.12.20.21.18.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Dec 2022 21:18:21 -0800 (PST) Date: Wed, 21 Dec 2022 13:18:10 +0800 From: Vernon Yang To: Liam Howlett Cc: "akpm@linux-foundation.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 8/8] maple_tree: refine mab_calc_split function Message-ID: References: <20221220142606.1698836-2-vernon2gm@gmail.com> <20221220142606.1698836-9-vernon2gm@gmail.com> <20221220150550.y5kknqwjc7q5bv75@revolver> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221220150550.y5kknqwjc7q5bv75@revolver> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: C4227C0008 X-Stat-Signature: 33e8wzwmd7jj888jufor1cqmp15sjthk X-HE-Tag: 1671599903-279056 X-HE-Meta: U2FsdGVkX18dFzD5CoZRWoUUkH1mWJgT7FRN0Q0PzY2LL0smTf91DlGVpTBlCY63C+EQe4+0WNyKWbN4k9Kl+QUk3iAuaLJXXm25Mew5AZEEqEgfSwYc/1/c0Ed0EL3olXXN13i1Cd9Fk2rM3zjIQ5kvWrrrAzSYI7o5rA3qz3QIanUT+rNaJ2AJd775U3zOImOzSu9ct9ltQzP1bG5LtzldsIBWIvZxMo3kcP8uAjcKnokOeYmU/c6URoArtffalM+FioYEURQaBNCH8QWrBJo9H3NCzCg9c1Gd7tWhDOdKqTBK6PctbWEf0zSV78qBAvfxaEMl1WM0W0wxBcpyIVrR/1XgKxAQE6mS6kXZ59zalPeJlw/nMEZDZbYRJ/BElbidasFBvMc/hr204gIL3ZCK6zlnsv13VYCCJnnMQSTD7hAdrf4KF6c70zXh41yaDP3EYbSserSRlUF1AjLT9v7tivPFRF01j4U/AZDgxarijvdacz51x8E5kN6qylOFOzeBYweWbry6sUbbKvmczmibsECkTRNbVig4gCS2rfPwBE9pyICNauLDyMdpDPkrIDOeDfRLFuFOOgQxgpWsxsOgCHlRHcabWRglMeb0ozNdgKSzUlfYwi6rZkdr/+ga0MSRjUpP+HiPu/mi6ZVR8XvcVpiGyLLMRJncqjwN+NEHaHQatX2wZxMimIoSNvtI073+KySWlsamL9BopH6mpaYjOvvrmLCExgWgpVGR94xRZAt838bUwmHgQIRiJ1fyhJD2zMA34Io9mji0pZkl8Mv3NZBw8fsY8oqvMpY5Y8kiYAtghYLZwNY8a/bwdoNQY7uNtQnLk6P9RIWbhOzqE6QvjwxK3GgbUZKFhdEp0MJ0OMPairENMZG5m+m+9x6zkGmAKDBlrofQE8vEH8mIbIbnXGlPk47SnG4M1iTif5seEaCltCakQHZms1xqHDME2PL1hczT1hCzXecolXs q6izl31P HFCgyZ01clQGb619rskrTZPF7tlZM+ERtOj6R5nnBgBuAzGvX7CmMXUlrfyCw66FH0ah1861g4b+mh7+B2XgLNmzha4rY0Bd5JfPBX+/heQO8fYdxm/pwGwcaM++4rCV1BSdtHwIRHwjxBVkxlV8RtOiK3R/FBFT6xWmNhD7J151A400= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Dec 20, 2022 at 03:05:52PM +0000, Liam Howlett wrote: > * Vernon Yang [221220 09:26]: > > Invert the conditional judgment of the mid_split, to focus > > the return statement in the last statement, which is easier > > to understand and for better readability. > > > > Signed-off-by: Vernon Yang > > --- > > lib/maple_tree.c | 5 ++--- > > 1 file changed, 2 insertions(+), 3 deletions(-) > > > > diff --git a/lib/maple_tree.c b/lib/maple_tree.c > > index 16cdcf309e97..d147669fb99c 100644 > > --- a/lib/maple_tree.c > > +++ b/lib/maple_tree.c > > @@ -1882,10 +1882,9 @@ static inline int mab_calc_split(struct ma_state *mas, > > > > /* Avoid ending a node on a NULL entry */ > > split = mab_no_null_split(bn, split, slot_count); > > - if (!(*mid_split)) > > - return split; > > > > - *mid_split = mab_no_null_split(bn, *mid_split, slot_count); > > + if (*mid_split) > > + *mid_split = mab_no_null_split(bn, *mid_split, slot_count); > > The function is written this way because mid_split is almost always > zero. If you want to change this, then we should add an unlikely() to > the if statement. Okay，thank you very much for the suggestion, I will add an unlikely() to the if statement. > > > > > return split; > > } > > -- > > 2.34.1 > > > >