From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42463C4332F for ; Wed, 21 Dec 2022 05:04:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 766818E0003; Wed, 21 Dec 2022 00:04:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6EF578E0001; Wed, 21 Dec 2022 00:04:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5696E8E0003; Wed, 21 Dec 2022 00:04:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4818C8E0001 for ; Wed, 21 Dec 2022 00:04:11 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 22B6E40330 for ; Wed, 21 Dec 2022 05:04:11 +0000 (UTC) X-FDA: 80265121902.19.DB49D7A Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by imf05.hostedemail.com (Postfix) with ESMTP id 6F90A100018 for ; Wed, 21 Dec 2022 05:04:09 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=LNaBAAC6; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf05.hostedemail.com: domain of vernon2gm@gmail.com designates 209.85.214.182 as permitted sender) smtp.mailfrom=vernon2gm@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671599049; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Cw1a4Wmo8BZ9BUfaTviwAEXLBLj33fpIC4MwtpW0seE=; b=RoHOzRkZAi9eO/v6prSuz/F29Py7WEc2yjbu6j6HU5juBC0XkEW/iTY48c9h2aFLlHJTeE 2pK1D6OY2iUTJUmakDk7eaHz28E/SSj3SesMkxjNrkys1GwNAkbcQm2LeEELQACISVYU8c 2/976XN9C03mDX6wzuoL5Ogfyb2JqWU= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=LNaBAAC6; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf05.hostedemail.com: domain of vernon2gm@gmail.com designates 209.85.214.182 as permitted sender) smtp.mailfrom=vernon2gm@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671599049; a=rsa-sha256; cv=none; b=qOg4UrhovSlXUGnAEhdQE+LjVBPX9BKO4/mBOVk4vN+IxfW3SGX3L6azimiDdGZKwUqOXE bNb3VI0BF9j3o0H8quG355Zl4Tr3NxiX9z6omXQ8uxdQ+dFXFyQfufxjnVk39vaofAiYDp umkEgza7EzXccKKDHI9u74b6/zb7CcU= Received: by mail-pl1-f182.google.com with SMTP id w20so7849124ply.12 for ; Tue, 20 Dec 2022 21:04:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=Cw1a4Wmo8BZ9BUfaTviwAEXLBLj33fpIC4MwtpW0seE=; b=LNaBAAC6+pwEiBRx2mrTBXEL876WLXEIlhSbUZ5ha6eYJzLiJHbeXHumcjEXLUQQTS 3hcchLWWK3Dn6C5dKbCxxDS5ANK9BJO+QdlS9Yx6nGU0vbsPFJ1XOdmQWk/I4zUO6pmD 8v4UnpZlL1Vck3ErXxIF+vyOUTeVHO9+CEMRwaouE1SupjcwHSAwTXDdX6ljWuOe/fX4 1l+XvqsUW7p0sX4etht5LFMuPA2Tf1y2sz8cexFMWavcBm0XLxFm3s7GINhDpD0urTHe o2DyIeufXK9uc+pbWX44B6H4R3xutEZUhSO5QPx+bnNURKfAt0Kwc6rjHwpQ8lNcA8dm 7zog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Cw1a4Wmo8BZ9BUfaTviwAEXLBLj33fpIC4MwtpW0seE=; b=0YivHSr7zM8fp2aE+9NENjeybP0z/EM/t6ieGHSd0XccGId/QwTZiJScIxj66gpZp4 O5r2OSyJn7N7LiBtxDOs1Tn8ImyrEVyi9fpysnioLnQJWG+NPRMWfEWgzO4fKA2jcPM2 sde6g9/ntQUNCHkuV/MY0D9+oPXrUM03Zj5og5J/dNCeoGfk7W4UxEv6wTsAl3Sbclid ax2TPqF2uyLBMiiXeiwR1uCTRRy8o5Vp8n0CgQxzx2Tygfq9+YLwdvnTvHWvklfgJz7h DMZrOns+prNaRqzDmdXu4CCpF5kTtADAFPT28GD/8O1ehmHVHMO+RIywAwNxXUtVtT+m q93Q== X-Gm-Message-State: AFqh2krtHxQ1WmBUppoGEU/8QenWE7koTDmbfd5bm6xdV9J2wAGq/429 qkoyOCyGmnoxC8RLEtH4oS4= X-Google-Smtp-Source: AMrXdXub8MHfwEvI8OLapx+ZlwQ5mIsavqqa3gIAuZ8Th3jIUscPTTy7MNPs+xjsHQeVQxvXpfWYjw== X-Received: by 2002:a17:902:d905:b0:18d:6244:4676 with SMTP id c5-20020a170902d90500b0018d62444676mr714625plz.18.1671599048163; Tue, 20 Dec 2022 21:04:08 -0800 (PST) Received: from vernon-pc ([114.231.52.81]) by smtp.gmail.com with ESMTPSA id v7-20020a170902b7c700b00186e2123506sm10250000plz.300.2022.12.20.21.04.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Dec 2022 21:04:07 -0800 (PST) Date: Wed, 21 Dec 2022 13:03:47 +0800 From: Vernon Yang To: Liam Howlett Cc: "akpm@linux-foundation.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "maple-tree@lists.infradead.org" Subject: Re: [PATCH 0/8] Clean up and refinement for maple tree Message-ID: References: <20221220140829.1665432-1-vernon2gm@gmail.com> <20221220151858.c3bj33jzwjxa3wct@revolver> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221220151858.c3bj33jzwjxa3wct@revolver> X-Rspamd-Queue-Id: 6F90A100018 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: a46ny9jte148jc7qwweuiu4734yimggb X-HE-Tag: 1671599049-694268 X-HE-Meta: U2FsdGVkX19ccthhVBKyC2VSOaaVveFt7RkGvadwnFKesH8xYyr4jk8IbAtr+b1HNuJY4tuUDhCanR6uEffvhuq9tB60g62S3H4XfXmEh00LuKtG6wfjI/eiNmfT+7fX3wXYPWN6hmVXVsBEvs63UuhF/QoRSUiiZVgAn96oGgoGiVo/AaBnngUSrk//OuQAqRV7sr1kUaDOlW8T1XiXrqqkKBKUd64vbfwhbN8Ym9QYIVh4LFnWReYR24G9KHcuC0QhorzcNjhKT7eKetL07IWMLWnRPCXg07Ca4QSRIQ2SZr44SevjpP3lcex8ka9zm5ARORt9cFXRRDr0sAbTzi5+pKpbsqZnPWbL57BJHjsSA/wQZcFk31xsAVBsW8J8HyM/Q1mhb6tQ/KhFfRX0umdNeJCdG7V/n+AmfGNjjrx2DRZklJzKnuE0EgJsyscMyUlbbJHfrlRh1CHpZ8QhhR9sxSa3jZIluAv+tlwAxVIZSLDOZ7oARpeI3s62IqbVzmJWfGGlzgbkC7MMFbKJzSPpQi6hICFHPKOYvlKcrrjEw9tWmkVpDAdISwxZYXBsBWGX+6J9GL9yFhPwfLjMoOajDI9lQkypiRNxYANcoDvYHcfS9oXvb6JzvzK7sherRpqpSU8e4t0+JmeWaIbO8sSbPGYD++KS/hcqekR87uHCCO3mJ8oXf7nNZ/+5k1Cj0TamcRgoCUAiKwe53s3zK5QA+whcyLpCJAsDw8AwdZZFgXxslZnCXpO+1ZOEjrGFsqopDz25KXw/lwbPuSdsvIz2xqi94f0PiW7EYKiRn/WGZHLPth1dBAO/40wK8K3bdMT3dHyB0HGHs+AkS3+M9ziMlPMACCvh3c4mNWDfULC5p1CLk35Cm/4zvLP5ISsumncZIE0a5PfF6bWSTur+oRETov5ZhZ6fwtkQpQbVptBduGymvAMc/uHA5zn0W/RZuiVAlU5wBPSy05hVs5P Tyj+lzCv 81EI93BBYyQGFAMLY1dh+houRPv3fGDEVJpaTBQ2y73UCXN3F0nZplpBk+T9sa4MuW8m166pduhk2dU+PSjkwZEATaMo1LG21tNyO5ziqvM8Gem5h7NK3S9JBn5Yd/MjrKyY3 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Dec 20, 2022 at 03:19:08PM +0000, Liam Howlett wrote: > * Vernon Yang [221220 09:09]: > > Hello, > > > > This patchset clean up and refinement some maple tree code, a few small > > changes make the code easier to understand and for better readability. > > Thanks for looking at the maple tree. It seems somehow this cover > letter is detached from the series found here [1]. When sending the patch, my network disconnected a bit and then resent it again, maybe, perhaps... becomes like this. > > All of these look good except 6 and 8, which I have responded to the > actual patch. I've indicated below which is 6/8 and 8/8. > > > 1. https://lore.kernel.org/linux-mm/20221220142606.1698836-2-vernon2gm@gmail.com/ > > Please add my reviewed-by to all patches besides 6 & 8. > Reviewed-by: Liam R. Howlett Okay，thank you reviewed this patchset. > > > > > Vernon Yang (8): > > maple_tree: remove extra space and blank line > > maple_tree: remove extra return statement > > maple_tree: use mt_node_max() instead of direct operations mt_max[] > > maple_tree: use macro MA_ROOT_PARENT instead of number > > maple_tree: remove the redundant code > ^--- 6 > > > maple_tree: change return type of mas_commit_b_node() > > maple_tree: refine ma_state init from mas_start() > > maple_tree: refine mab_calc_split function > ^--- 8 > > > > include/linux/maple_tree.h | 6 ------ > > lib/maple_tree.c | 41 ++++++++++++++------------------------ > > 2 files changed, 15 insertions(+), 32 deletions(-) > > > > -- > > 2.34.1 > >