From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73FA8C4332F for ; Tue, 20 Dec 2022 21:15:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D0A6F8E0002; Tue, 20 Dec 2022 16:15:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CBA4E8E0001; Tue, 20 Dec 2022 16:15:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B81F18E0002; Tue, 20 Dec 2022 16:15:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A709E8E0001 for ; Tue, 20 Dec 2022 16:15:25 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 6D8611C65BC for ; Tue, 20 Dec 2022 21:15:25 +0000 (UTC) X-FDA: 80263940610.15.1035B22 Received: from out2.migadu.com (out2.migadu.com [188.165.223.204]) by imf19.hostedemail.com (Postfix) with ESMTP id B1BAE1A000D for ; Tue, 20 Dec 2022 21:15:23 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=cBJO2EIe; spf=pass (imf19.hostedemail.com: domain of roman.gushchin@linux.dev designates 188.165.223.204 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671570924; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YR2G1tfnt1QeRb9BvoQh2xZ0Hit39TayrVYxM23Ti5o=; b=o1/Rrv2zkRXfZg7SBDqzaovs7MW3vQ9kk0v4LbRlmcPt7smNrZHReIvW/a+WRSfdBczbsB ql4GdpjwjApmI1YnBxCiPer+RA8/s2qiJ81rxaNuyqLNrVdTHtke8acmxbVU+1Tzo6K8ep GfyELZPO9iIyTLgeWoVOzcbOKzVDwN0= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=cBJO2EIe; spf=pass (imf19.hostedemail.com: domain of roman.gushchin@linux.dev designates 188.165.223.204 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671570924; a=rsa-sha256; cv=none; b=cPJtTGt7qI/RbcI8SmA9N5AxP+ZIYDfIYmPe7tkYNuPgxElYOz32tNNPWEynQF6QhsqOJV Z4ggjrSd1SWrz80CYJ81v9JTFksoM97I8AAkiQqXBjdGtWtagj/uirq0ZSaZOeJBUOauSq r7Q77RaqMaIBMEKnEaNsHDw8Fty77EQ= Date: Tue, 20 Dec 2022 13:15:16 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1671570922; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YR2G1tfnt1QeRb9BvoQh2xZ0Hit39TayrVYxM23Ti5o=; b=cBJO2EIe6oiGh2ENr1dP4PUWluxLFCOQnl1rnqFwsqvzqef+3Rd/UJmBPLbq5IL4/dcQEn gN4B8V37nJGryYOHvpTd23Gf5nrA6ZTRW9dEdQKd/He/k9s9kK8CV0Agq/XwjtfIEVbjoQ ujr36SB+a8Yw8C6daF2iwukLgcHSDDY= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Shakeel Butt Cc: linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Johannes Weiner , Michal Hocko , Muchun Song , Andrew Morton Subject: Re: [PATCH RFC 1/2] mm: kmem: optimize get_obj_cgroup_from_current() Message-ID: References: <20221220182745.1903540-1-roman.gushchin@linux.dev> <20221220182745.1903540-2-roman.gushchin@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: B1BAE1A000D X-Stat-Signature: axoexcz7ntpat41978im61pt1zqtc4a4 X-Rspam-User: X-HE-Tag: 1671570923-307738 X-HE-Meta: U2FsdGVkX1+lM4JYffDbYfYRhC3H15Q8f5n+j26RvnZpMM+IYvXvNaVGYUAmh//9dl2+qTQ7oifT+VkbBzIawsuhkWBaV1UWWuCMJ2OPL2x8n+4Fj71+yChr4OLp3NuMhTV1c2b4fMpdJkuPq3V+dYGaCZYTBXFO7fxrH7WCA5qhYRvCtMW9+6JG7gZM+guIKE5DflIABZG6rdKBSyXtFfuyzmWRdmHJ/tijqnn+/8BVsVUAr58I9Y9jHzXrvnjTLcnF/9vwhWtHcL71Lk/k8O1+6YON9zC1az3eSr+CC4drisxWsriSF2mM925ZFVLe33MBR/byw0B7GiHvs6eSaor//3cUnclcYdI4wRbGXmo/5ZWpjC/kzxoTf0mCjFm9lMCepYCJz3BfgukjS+jVsQuDTzkkjLBfOMBzW0sjxaybXzCC4pOwZUgz0XeELR01+Tzwm3tLeJ7FI6sXg4ceUAvCgetlhg2Snq62Fu80a9d4ZHj8hQYEZC3/OQaqV4kqJhzaJOiyCwRwgtu86jId07TwDH5YPs6x599aGQn+oFem5ffIc69J/mlbISWhTNyafZlurdjgpA5ghksGkVnwJ2WnxTnj4b2gAPaf4aYVCsQ97beSyKn0TsYSrbjkI2xphbpTj5LjI1AaHegQuxIyPR+D1kiZRTDp6dIGZ1GCH3rEiI4EC+pYO8eT49sH905FUKq5r7Z/voQ3x99A3oJfOh3/lQhbkhPf/gwalCz9sxnLjJjKgE78/ud3OQo37r6e5JqNCoFH8gmdStQQqRB7XcDntPEsqsTj9gIe4rM+6gQhmC7hc7FMtBHq7mDNgphCass8gHLrg0bWbDo+iU1xk1NLO1d/XqDwi6us+Elo3PbYARJJtOs5yirngGRGJctaq2FcgfhOqvTwHRtFo2Wd+k0VhleT/Llf X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Dec 20, 2022 at 11:55:34AM -0800, Shakeel Butt wrote: > On Tue, Dec 20, 2022 at 10:28 AM Roman Gushchin > wrote: > > > > Manually inline memcg_kmem_bypass() and active_memcg() to speed up > > get_obj_cgroup_from_current() by avoiding duplicate in_task() checks > > and active_memcg() readings. > > > > Also add a likely() macro to __get_obj_cgroup_from_memcg(): > > obj_cgroup_tryget() should succeed at almost all times except > > a very unlikely race with the memcg deletion path. > > > > Signed-off-by: Roman Gushchin > > Can you please add your performance experiment setup and result of > this patch in the commit description of this patch as well? Sure. I used a small hack to just do a bunch of allocations in a raw and measured the time. Will include it into the commit message. Also will fix the #ifdef thing from the second patch, thanks for spotting it. > > Acked-by: Shakeel Butt Thank you for taking a look!