From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CABBC4332F for ; Tue, 20 Dec 2022 18:46:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7CF638E0003; Tue, 20 Dec 2022 13:46:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 77EEB8E0001; Tue, 20 Dec 2022 13:46:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 61FF88E0003; Tue, 20 Dec 2022 13:46:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5419B8E0001 for ; Tue, 20 Dec 2022 13:46:01 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 323804022B for ; Tue, 20 Dec 2022 18:46:01 +0000 (UTC) X-FDA: 80263564122.19.FF2267B Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) by imf01.hostedemail.com (Postfix) with ESMTP id 5D1DB40016 for ; Tue, 20 Dec 2022 18:45:59 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=l5Xuhabw; spf=pass (imf01.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.51 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671561959; a=rsa-sha256; cv=none; b=bApsvDwNsKjLXTv4PqUBW7asFK9c0I7+PM7RJgofvuZJqzdZ7vzEX8HQpdm9I9mPEodNrT mwujvCpbWnRUwLU6YpMbQ/UrBDQPg/9IQVyESJZmK6BGgazcYUQa9jneBzfTRjh0zcSrjp LTEwTPa58Fo+tBRIH227Esui2jVeJSw= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=l5Xuhabw; spf=pass (imf01.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.51 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671561959; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=P0pOPORY+qRKc7qIBI9apT/+V75LgK69tvfX3g/aAOk=; b=guNk81lF3kaegKEey9WGR0lz6qS3LyzYIRhwMtH0Ml2kjuIndtJh1WbMrO8f17rbqDg4Lh CZavX9aKxl0a808hYlkTCNshJEec3nrwrNynG5/M87L2jTcJTabSN1ZzvjcXgXecLBJ0lv o+qarJ7htAlQ2vXqtlnOYP+/JYtd83E= Received: by mail-lf1-f51.google.com with SMTP id g13so3270157lfv.7 for ; Tue, 20 Dec 2022 10:45:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=P0pOPORY+qRKc7qIBI9apT/+V75LgK69tvfX3g/aAOk=; b=l5Xuhabwxl+ax7j7oOZm2urN5TX9XdKhTjFnMa1QYSWpmt0H5LTmJr4fl8jwFzlZJc w+5yg5cpBZ6lHLyXj8Xg+6AYnQmjwdFe9Tf5Zn4SUP2M2s8n7F52fi+bx70W4NIoFSbQ vwkW5MKGWI/v8zN3G1YIvN+2luCBaieNsFgonLXBWm7uACrJpoUsBIs0u/+1kEG1FBp5 p+fd48olRi8wubGM5vHxj9pIq4o/j0UQNI6iM8FnIoNk8OSfckSzZELl9m6uKqCa+7Mx lrFjcarPZjCg2JzF3pjhstAgNyr5C49jMSVIp7of2DEUQ2UqL/eA2Yf4KYDfMPFOknCD I5uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=P0pOPORY+qRKc7qIBI9apT/+V75LgK69tvfX3g/aAOk=; b=huR/15j/0Wftv5bRvBKMVWaFrDS5xySaJAdSm2waBxALPCe2WTn84TToEi70zcUPGX jYnTDMxw/cGVaIb6uUh1sxSz1NWQVyvW/oEGavMWPxo2+J8I2boD/mNukHd8JOIodT03 LSTAxCFXld5WfQAo2i8o5/tB7wTXqqNFsSIDxveC0xlvKBJWg6DencYYKYvIPn4PEAPA t4cW+VXIt2IodRlb5xx1mgd7ZcC7P/SBrePNrDUbwW1N0MdXtEY2y1XGQJX7XjzJMxua mDU/N3Hfd/z0Sf5ifAT+iEXEyPHcvuQ361/zpC965AYFSKYhrjd9yx3LEFqQHCoPbR7P O0wg== X-Gm-Message-State: ANoB5plkvCzG8LClH2act44a5IyNce0DHUJMz/J8BF1Cba6cCPZcmW1F 7LX2Im73CsUVIdFIODj5QEY= X-Google-Smtp-Source: AA0mqf7T5mTJQw4vTmOR34eNSjEsanhw41FpDkl95TDje2TE2qmbZf/bwHEbXSM0IiKfpq0TqYm78Q== X-Received: by 2002:a05:6512:2256:b0:4b6:f1b4:b845 with SMTP id i22-20020a056512225600b004b6f1b4b845mr13515696lfu.65.1671561957921; Tue, 20 Dec 2022 10:45:57 -0800 (PST) Received: from pc636 (host-90-233-218-120.mobileonline.telia.com. [90.233.218.120]) by smtp.gmail.com with ESMTPSA id a12-20020a056512200c00b004b580a526c3sm1547828lfb.295.2022.12.20.10.45.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Dec 2022 10:45:57 -0800 (PST) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Tue, 20 Dec 2022 19:45:55 +0100 To: Andrew Morton Cc: Andrew Morton , linux-mm@kvack.org, LKML , Baoquan He , Christoph Hellwig , Matthew Wilcox , Nicholas Piggin , Oleksiy Avramchenko Subject: Re: [PATCH 2/2] mm: vmalloc: Replace BUG_ON() by WARN_ON_ONCE() Message-ID: References: <20221220182704.181657-1-urezki@gmail.com> <20221220182704.181657-2-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221220182704.181657-2-urezki@gmail.com> X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 5D1DB40016 X-Stat-Signature: 5ukrh4odt9knnp3uyk9q3w5yq4tqwch6 X-HE-Tag: 1671561959-46808 X-HE-Meta: U2FsdGVkX19ZjYIyYmv4s9Fa2JUVNDOg6LOWZmGjo9wykB2rHgP6nnxpIilaKzw3wakpUi7UURGvdm8CKLuZa5llLiED0phAIGEOU6miX/BH9JFDJ6n0f48SQYxHf82yLfmNukoiBmiInotBHD8oJexaT00Z5HwHsH3sAVfZ3cXreMS3qgCCIbzYiSOCILq4H41pO8CeYBppk4TMN6JqMAxonLsD41+ZAtl2AVqc1d5vfLYVKmy2hrF0r7B9xl1VK68UoSDAeSRjOFc8wYCujyaKkkfh/Rjk57f7rykks/ePq/vTJh/mf0U6OD9HxJipQqa7cIzNFJmWDZJprz5uxLvx5IPgEgkmWyDAfPdphqfJI3hxwQRwZCHmczOL6obTXqfZUO7LUcZt/44VfVBCj00cahIDxD6KNYsnEYDkWTGUrP/QuZPBK7KXC/+ePcRoIu/p1P29OhzPemy2BSo1X/87env4E5B7DSrZWFdKL2BLNXTWfB7qalxeI5mFVF8P8XFJYZaWVtfnH7zxIWmdIZ+ZDKNcydbvgwwGEImaM2TtkQARHEF/LQSX3WT//4o8rmAHEafhgnezQLjv3eW0R+vvRF7iTfO5xTyeJkTAsJSRRUYP0MRJ3brmy8OByasIFiMY23fScYhMnhUgQ2sp5JZgaT5i4BYXKGuDiPQbSG5EvGrU43L4N0C4pAxi+eoBl+ZS8dy3DqCr8TKjSqfjdllLJp1XzBZwEDshLDYPUj5jRJjakIogAq0nKxZ5cBDkAqdYORhukMKoWJggm2VrMeW8u2y3QQ9ClOD9yrH+iqUUoELYyoUshnAjs4WDW2/ayio/V5Y/F67UlL51XhbkTbgyVDau0IQuGTJ9oTqJWxVhqgKVuszJB/3m9Yr9i/4meqJJWTu2GEdyDh1gWfsAJH1wVNsyUJdIDrIl74VWHlpRbZrkviJmf0STZLIazsIlr7wooo4EVFvfkKrTEIH 1d5q/UqO iWXuc5loNmjSszikvVedm5H7V3dij1j9I14uOVJ/mhHT2vTl9PjHlRIoUeaVv9UPt05yku9pChwULxROP4dsuKFVi7Ij/+pRTcBlLDTrRd/U5BmySFEC+D055TW0pERNUGUE+svelNlcYPHo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Dec 20, 2022 at 07:27:04PM +0100, Uladzislau Rezki (Sony) wrote: > Currently a vm_unmap_ram() functions triggers a BUG() if an area > is not found. Replace it by the WARN_ON_ONCE() error message and > keep machine alive instead of stopping it. > > The worst case is a memory leaking. > > Signed-off-by: Uladzislau Rezki (Sony) > --- > mm/vmalloc.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 0fc38c36e0df..e05a0dc79ac5 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -2255,10 +2255,12 @@ void vm_unmap_ram(const void *mem, unsigned int count) > } > > va = find_unlink_vmap_area(addr); > - BUG_ON(!va); > - debug_check_no_locks_freed((void *)va->va_start, > - (va->va_end - va->va_start)); > - free_unmap_vmap_area(va); > + > + if (!WARN_ON_ONCE(!va)) { > + debug_check_no_locks_freed((void *)va->va_start, > + (va->va_end - va->va_start)); > + free_unmap_vmap_area(va); > + } > } > EXPORT_SYMBOL(vm_unmap_ram); > > -- > 2.30.2 > Will send a v2. -- Uladzislau Rezki