From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6E32C4332F for ; Tue, 20 Dec 2022 17:38:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1278F8E0002; Tue, 20 Dec 2022 12:38:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0D9D28E0001; Tue, 20 Dec 2022 12:38:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EBA588E0002; Tue, 20 Dec 2022 12:38:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id DAA618E0001 for ; Tue, 20 Dec 2022 12:38:46 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id AB7E2120D03 for ; Tue, 20 Dec 2022 17:38:46 +0000 (UTC) X-FDA: 80263394652.10.21CA278 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf03.hostedemail.com (Postfix) with ESMTP id 401E720017 for ; Tue, 20 Dec 2022 17:38:43 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=TlKfpjpe; spf=pass (imf03.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671557923; a=rsa-sha256; cv=none; b=te+DkssRckCuZwgIpFPZW/d1EDfQYOVqLuJctzUTOOiSLikMM55jvIzfsawoNk6mPygqAl EGIgqbAc6pKfGKy7G/Y7GnIhqWwrvQ41otrw2gkWlonAVK4UqFwMSl6pJ9TvUT6Q5b06w5 YKVDQ00W5rCqAyU/BF1C1Gbjj66/yi4= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=TlKfpjpe; spf=pass (imf03.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671557923; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fEfc8sJnHm7K9aruHy33BZirM4UCmBd1CuSTlZNxnWo=; b=3E4PwfUDaFlqzXP4WcS+iW5T0Tsa+eJtCEjDtSEtLGlFXfu5RbN85zpfgFj7v7X6dVsSqF dBPRiIyvjQcpjzl5G99BgPH24nyvtys61wqoBowg7ChsqZc7XJ1BSvOwhSmn3y2mwaa0Tp LRTQLPvxO+cNgI3ybhZo4nrPuY4LJU8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1671557922; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fEfc8sJnHm7K9aruHy33BZirM4UCmBd1CuSTlZNxnWo=; b=TlKfpjpeI9BOmFcSxMnnknb8cpsPI8v2X+dQA/DAt7euGQXtIt23kB4jPCa5R0IiDMHS47 Fl5Mp9fJPYbOU7yHlkJb5Zf0xz1kDIQvEEtHR2KAgt9oAyHMCth1II6USkWhZmWRat6C+o +EpFo2LRasm8tORzdzPqkgM8099t6JE= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-558-3BvdmoA_NmyaJ-nbmG1caw-1; Tue, 20 Dec 2022 12:38:39 -0500 X-MC-Unique: 3BvdmoA_NmyaJ-nbmG1caw-1 Received: by mail-qt1-f197.google.com with SMTP id a13-20020ac8610d000000b003a8151cadebso5827441qtm.10 for ; Tue, 20 Dec 2022 09:38:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=fEfc8sJnHm7K9aruHy33BZirM4UCmBd1CuSTlZNxnWo=; b=cKA6HqTE8+i6CQyJyE4tCy2z0Aybrd1XUlVP7FYHEqfMT833CJ4lnQ5ujULyiJXfca g6g9LUt9g+NoUntOUs+i1qio5Og7r4qmGkcP/QgsuPRoMIiNGivhAazuqNpkPgguO2Sr rqjJh6Ch+AJqHVtStbrU6itWHN5jAewFuPKcAccpQGCN5CRBgtCX213oo8y+i7qkuWhi pqoglXATEj92NnY4gyQxlQverjj7Cq3iH/qdugLf/VfL8PaLr29eKrSxwOhL3oe+31vt 2kroK1+V82ISb+TD9q46CELC+jcaDGAMQSCv6HXtik/XWJCbBOFySxxgZ7ko6SzxxMIM +iVA== X-Gm-Message-State: AFqh2krvccTG33GNZMdYtRrwFoW389iwx/X5NEdRnoHhb9KK0bx5XchP qWCDkxsWWlBv+8gFnTM6YoP2q4EcYrUFvPPbRCtplKGeh6Oi8nlPShtnAxrIvGIqehixcnVM8AJ 6pFOmScOrlXg= X-Received: by 2002:ac8:7404:0:b0:3a9:8610:f9af with SMTP id p4-20020ac87404000000b003a98610f9afmr4892457qtq.14.1671557918843; Tue, 20 Dec 2022 09:38:38 -0800 (PST) X-Google-Smtp-Source: AMrXdXtg5R2YbTU53YK6jcMnW9vCQk+xxP9JBp96j27cdKzorbZMYmsqPt75wVleU8oFZr+Onr1Sjg== X-Received: by 2002:ac8:7404:0:b0:3a9:8610:f9af with SMTP id p4-20020ac87404000000b003a98610f9afmr4892421qtq.14.1671557918568; Tue, 20 Dec 2022 09:38:38 -0800 (PST) Received: from x1n (bras-base-aurron9127w-grc-45-70-31-26-132.dsl.bell.ca. [70.31.26.132]) by smtp.gmail.com with ESMTPSA id r17-20020a05620a299100b006fb8239db65sm9360534qkp.43.2022.12.20.09.38.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Dec 2022 09:38:37 -0800 (PST) Date: Tue, 20 Dec 2022 12:38:36 -0500 From: Peter Xu To: Mike Kravetz Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, netdev@vger.kernel.org, David Hildenbrand , Michal Hocko , Nadav Amit , Matthew Wilcox , Vlastimil Babka , Rik van Riel , Will Deacon , Michael Ellerman , Palmer Dabbelt , Christian Borntraeger , Dave Hansen , Christian Brauner , Eric Dumazet , Andrew Morton Subject: Re: [RFC PATCH] mm: remove zap_page_range and change callers to use zap_vma_page_range Message-ID: References: <20221216192012.13562-1-mike.kravetz@oracle.com> MIME-Version: 1.0 In-Reply-To: <20221216192012.13562-1-mike.kravetz@oracle.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspam-User: X-Rspamd-Queue-Id: 401E720017 X-Rspamd-Server: rspam01 X-Stat-Signature: 8xhf9w3symd6cdca7m199y5amk3m6ybs X-HE-Tag: 1671557923-501882 X-HE-Meta: U2FsdGVkX1/DI90N0XQuUB+OUgz77ekyLhXLka1dLc8AtOK95YG5bGqmpeuwo1hmjzOn/2lHHEZvKXwZUvPV5z9Plej/tQk7gzxHThLOP9nZFnfMZLIXezBeVZAT8mUjq7i6gSdiVnsP6UAuv6V4CJx9SQHcPT9eoA098/n+xCs9yrgtFOlfgv9tzyEAO+nGhQ17uQTShyLyQ5NA8gqG7qnCqRfZK6/dxNkXEKvyQhQwJhStDOsmFDrGwBKH0qvW3bupgH9UddMGf4ll4wxUZhGKvzRtr0yxB8W6I+i4iZF0hm2MmkESIP7ZJf4v3PP3aONehBioMGbGRYd+DEm+7RVKzb7thD03PAexdSygLE9ggSkJZLN980V7QQ++95rbZbimAw3gwZqOJy0ba+b6/SG9NgvWbAUfmXBsbmRQTzBlJ81+35GsCviIe0VoK+HpN2dApEPwhJmIyTzjPxkJsTdZzIY9uoTJCB1uaNCI37kRWgruw75OPdZNNA2BZhuiuTDigMjudLnN7ajQgRMscuQ2AP3K7pd6eoZ9j0ylal+2ifP7slWn+gDnpvy4Zq/WFAokE4nKc9Sl85SsM4XfUlpOFdqGeXKLMbe0JPPSi5CZWohmGKAa5LqChDspHucE5LyYox+HkcsyQ4lwEOn1RAFwDh1wnYfpAimVaSznJr8COtt/u1iHBh485W2ROJMlSLjV+iBwz31FLAUhm9awoPQlZmVktcUiQJpOPwbPPmOQ/hS34G2U6kX/2USC/uJ9cxVnmuY/Zi8hkr7+NkNObLuKztcnUSqy71/pu6fjqnEpQTdpeic12A79BpDMy/tmLnh7do7xTvdUtNhYx5FgFwUf1BYHbt1OI7HduraafxCd24O3Ek6cwpFG5Kr07HZGj6GHYHPrabTSs0qRJcnnTmhAop9SKeFsawz+vMTuSFLfKNpgzwEzglJPOcyc8LdhReiatcexDJzG2gl0oyb U4U6Zprq IuA6S+OVhR6Odk9piGb1jdaQxyXfNmJtD/lJuKuEwpka4uBUdP6Y4a4cgiiGLta6jhJTLXeV5vxpybBd4E0E52TBJlkq7yhA1/dEA8wSZHaanFo1Xi1kAlo5XD/pKP159GjqdHkmuFwqxuBNzBxkYXr4aF6cP8O7dUJNQuUb1JRjTi2Owgq33rb/Nc6IlYR8Oca19oyM2oc0h95DgQ62FdgM7dv6kIXzwB+9I X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Dec 16, 2022 at 11:20:12AM -0800, Mike Kravetz wrote: > zap_page_range was originally designed to unmap pages within an address > range that could span multiple vmas. While working on [1], it was > discovered that all callers of zap_page_range pass a range entirely within > a single vma. In addition, the mmu notification call within zap_page > range does not correctly handle ranges that span multiple vmas as calls > should be vma specific. > > Instead of fixing zap_page_range, change all callers to use the new > routine zap_vma_page_range. zap_vma_page_range is just a wrapper around > zap_page_range_single passing in NULL zap details. The name is also > more in line with other exported routines that operate within a vma. > We can then remove zap_page_range. > > Also, change madvise_dontneed_single_vma to use this new routine. > > [1] https://lore.kernel.org/linux-mm/20221114235507.294320-2-mike.kravetz@oracle.com/ > Suggested-by: Peter Xu > Signed-off-by: Mike Kravetz Acked-by: Peter Xu Thanks! -- Peter Xu