From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D857C4332F for ; Tue, 20 Dec 2022 11:33:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6CC208E0002; Tue, 20 Dec 2022 06:33:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 67C738E0001; Tue, 20 Dec 2022 06:33:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 544B28E0002; Tue, 20 Dec 2022 06:33:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 431998E0001 for ; Tue, 20 Dec 2022 06:33:03 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 1E557A0BF5 for ; Tue, 20 Dec 2022 11:33:03 +0000 (UTC) X-FDA: 80262473046.05.53699FF Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by imf02.hostedemail.com (Postfix) with ESMTP id 85D4B80014 for ; Tue, 20 Dec 2022 11:32:54 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=temperror ("DNS error when getting key") header.d=alien8.de header.s=dkim header.b=MUUCsxZa; dmarc=temperror reason="server fail" header.from=alien8.de (policy=temperror); spf=pass (imf02.hostedemail.com: domain of bp@alien8.de designates 5.9.137.197 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671535981; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wyzmMh12AaSVV79EeqKy/Z7fsafEU9gQ+LmCE+KG+KU=; b=wuARZUTnOK0IvtYNmbDBYxjS8oHl8M4g4B9S6a8cpKcMyUhfUqm9g43JAList2r+y/EoBe fLph6LwsoH7Iecgtbnh/EiKBX1ODj2jq1mqBQ/u+NdJd89LAvaJTmROi1Teonn7ruf+Tak XAKe6idgBMPzrrkJTN/M/wUwleZeaEs= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=temperror ("DNS error when getting key") header.d=alien8.de header.s=dkim header.b=MUUCsxZa; dmarc=temperror reason="server fail" header.from=alien8.de (policy=temperror); spf=pass (imf02.hostedemail.com: domain of bp@alien8.de designates 5.9.137.197 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671535981; a=rsa-sha256; cv=none; b=3sAPk/wBd1ALrLJm9KPc3DB4Tcl/7EsrrZw56UJH1FValTMAMF+RYyrjki5j8KdM8BWJ/O IUMp6HmAs9rahQMAOPfhHSOFoLjuHjjJLMqf4bVv8QEET7C/AtjKXWRwSvs43OG2kMT+UC DoH5vzgorIODsbv717Wxg8dQgwvTjRY= Received: from zn.tnic (p5de8e9fe.dip0.t-ipconnect.de [93.232.233.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 668B91EC01A9; Tue, 20 Dec 2022 12:32:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1671535972; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=wyzmMh12AaSVV79EeqKy/Z7fsafEU9gQ+LmCE+KG+KU=; b=MUUCsxZak/9lH5l9wDluLn9SmGkROwMkDwX3t4XZYsW4yGHs7sY5xxcLNaBSR/QO6CKBys 1m3UJXRwOfgyfkAFC9fu+/kMPByCRcw84M1Tpp2/aiDzEsEcHMmC2lYe6KO7hDMBFHmVc0 jWNp3LKRIz3whhea1YxwNJ96pGT5f+0= Date: Tue, 20 Dec 2022 12:32:46 +0100 From: Borislav Petkov To: Rick Edgecombe Cc: x86@kernel.org, "H . Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H . J . Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , Weijiang Yang , "Kirill A . Shutemov" , John Allen , kcc@google.com, eranian@google.com, rppt@kernel.org, jamorris@linux.microsoft.com, dethoma@microsoft.com, akpm@linux-foundation.org, Andrew.Cooper3@citrix.com, christina.schimpe@intel.com, Yu-cheng Yu Subject: Re: [PATCH v4 05/39] x86/fpu/xstate: Introduce CET MSR and XSAVES supervisor states Message-ID: References: <20221203003606.6838-1-rick.p.edgecombe@intel.com> <20221203003606.6838-6-rick.p.edgecombe@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20221203003606.6838-6-rick.p.edgecombe@intel.com> X-Rspamd-Queue-Id: 85D4B80014 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: 51k93otmo5npg3cayyceu6c463qzqjtt X-HE-Tag: 1671535974-265059 X-HE-Meta: U2FsdGVkX1+s2E6xZw3S6ZSiWx+S7b5XZn/JGYb2yxFWFK59OpJU0y+0oUKQ+A1Lg4L/a9k4mOnLcALGeypPewQ1tgCwVuH8uQGH316tydfwqHTyDvvPZReh4r8aVfmpqMpX+6/T/5kznY3vYnbksDpnSVLW6FRRVyHlwm6aXi8ekO3C4zwtYrwAiv2c90Sz7uvXtHNYIRq6stSweQAHJ8Hj5yW236YWEBcX/I/EVL0Jx2ErBiFtiEXRu90wuoQQCcWnpJStw+8EXD91IUsjT+iWhk774Hri4EVPrAcgYXin84n/ENasphi7gMKQGy+1gVhLEhOcWqTgP1hoWaxxK965YOn6uZd3e7dUm17nKVLE7awrFhTD1Ure3PNWpgpxuSDbAEGxKRprXbqHld7mXIfvU3eOOqK9Rp2hBO4dt9uVWIT4uifU3rYpZOl2E7fRYJYyrsR/CsvVDOL8Wfr+FODmBoWjQtx61BQyJd6RYtxGoWUVCTfBThDJZquyRwXuknITtEDScD+RyjC1BeQeaizOJLxivkdF3tx/uvIodKMvEreBbkUAGO3BUqbsiAXRRgBnKYRHHqa1QMLJFfVwVz7F7Kf3ub6fAVhTXfhpR5biYCbA0vPYHvYbgZzf8xKR29kKrtPsqFAi+oNuq1EzgqV7/JBLCzpRrP3Yr6177jYvKX1WnSuyaCnXzoy2wYWS+ans5C5opVhkP+cYjXMh6rh8jRSqRYlfvv8rJClDct54J1xZS/sXUAzW3nzLiDKiFQGzROudh0n5YKY3N/a3P91EooytbvbotPOFXcvbQQWbDk/tSxq6E/WcF9QBy7Z4i1dIXtfaiFtzl6OlJURzlR9LwVP6skKS71JlvvrNPIrlD6fPgOv53pdvIIdUnyuuzAEMUdwyFMRG/yyuawX8lHPK9QqQbVIZDT+W5OjWHGogbtXZzBwAWA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Dec 02, 2022 at 04:35:32PM -0800, Rick Edgecombe wrote: > @@ -252,6 +254,14 @@ struct pkru_state { > u32 pad; > } __packed; > > +/* > + * State component 11 is Control-flow Enforcement user states > + */ > +struct cet_user_state { > + u64 user_cet; /* user control-flow settings */ > + u64 user_ssp; /* user shadow stack pointer */ Please put those side comments over the members, like struct fpstate does it in that same file. Rest looks good. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette