From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C5DDC4332F for ; Tue, 20 Dec 2022 10:59:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5370C8E0002; Tue, 20 Dec 2022 05:59:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4E73C8E0001; Tue, 20 Dec 2022 05:59:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3AF008E0002; Tue, 20 Dec 2022 05:59:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 2C91B8E0001 for ; Tue, 20 Dec 2022 05:59:10 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id E6DA6AB21B for ; Tue, 20 Dec 2022 10:59:09 +0000 (UTC) X-FDA: 80262387618.17.9096BD6 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by imf03.hostedemail.com (Postfix) with ESMTP id 7D5AB20014 for ; Tue, 20 Dec 2022 10:59:06 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=hmJJZKDp; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf03.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 134.134.136.100) smtp.mailfrom=andriy.shevchenko@linux.intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671533947; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lytDD1M/lhnCDDDFVrV/A9PNKgzswbBhCxL2CpCOKvs=; b=eZcSbjQPdWPv/FS5GYZ+zDSwajzLGLllieCmYLcKuBbcrWMAaleIOE1D1PGCzJRFVFB2rR jrJrlTsWOmdOO4hYIOyXciqMichhtDz3ABf8D8RqGDb2llNuFt+xIyn2wUoGVl6tVe/rQs ZhC/bEL6YJRqEuW5EdbuO0ur75eQjYc= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=hmJJZKDp; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf03.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 134.134.136.100) smtp.mailfrom=andriy.shevchenko@linux.intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671533947; a=rsa-sha256; cv=none; b=XZFFP3qHUtdEC/Ztnxhxa/fG4mT+vpgoYHxv6jain7OMnTmHaIhwBoiCNLw9ENAOjNhS5b B6a6MJ8J3ARZPUvLkumR9343jJg490F0F9k53N6I1PBXseGdEPE45xWpgHnH/oUbIf9sGc 0uqO+HwByVXyAoRTWY/mbp3to8CAfN4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671533947; x=1703069947; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=NEelLQDmgnv5MCyyCw3Z0H5qP7W6fG9yaOAKTHeKJ3E=; b=hmJJZKDpzxKH9Hoqe+8W4huyk4ZBcUNR+bSg9JwoSOi1SbUk/XRf9+sB hdn6rg4DCRVOOVqxLzgIW7pNbprUH1CXxjPP/zBAjfD9Xg57ttsA857OB ajvtMLRxe8Q0ppbJwj9oJAtlF/Yg/ygPEnYuP+4nmM4Mq6OoD5VLASVdM si21VVPPxdZnRm7nYzUetk3mS6pSfeFqz3DwBjwrq/oKsH9oGNjf8FaZZ x28v32yCMInPZHZQg/tXHYqtpl8R1A/mtlK9CvzA/KxMJGSg/3yrsHFRR DII+6Vf4YR0BGuojYKcax5B8kkD2zmm5VoFb0BToLmnBWhRUdHpqd+2av A==; X-IronPort-AV: E=McAfee;i="6500,9779,10566"; a="383931982" X-IronPort-AV: E=Sophos;i="5.96,259,1665471600"; d="scan'208";a="383931982" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Dec 2022 02:59:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10566"; a="653059539" X-IronPort-AV: E=Sophos;i="5.96,259,1665471600"; d="scan'208";a="653059539" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga007.fm.intel.com with ESMTP; 20 Dec 2022 02:58:56 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1p7aKj-00CpiB-2v; Tue, 20 Dec 2022 12:58:53 +0200 Date: Tue, 20 Dec 2022 12:58:53 +0200 From: Andy Shevchenko To: Randy Dunlap Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com>, Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , HORIGUCHI =?utf-8?B?TkFPWUEo5aCA5Y+jIOebtOS5nyk=?= , Joe Perches , Petr Mladek , Matthew WilCox , David Hildenbrand , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC v3 3/4] mm, printk: introduce new format %pGt for page_type Message-ID: References: <20221218101901.373450-1-42.hyeyoo@gmail.com> <20221218101901.373450-4-42.hyeyoo@gmail.com> <82feabee-0446-b913-adbb-0e96ecb10c94@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <82feabee-0446-b913-adbb-0e96ecb10c94@infradead.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 7D5AB20014 X-Stat-Signature: shkqf11xkdbgz71ojjyqbkj8doe8fix6 X-HE-Tag: 1671533946-359184 X-HE-Meta: U2FsdGVkX1+mj2Y4UYmgctw6g2WFVBfV6TDWN23SpRUsf/v3hussUx5TDVbALS2xKTbeAEMTg1gWL25dIONkdTQmDf+Jqgj9XqX9PeAwdq0Aijuz7jAo/vNoHiXNcf9XHp3Ay+mQZxNygL/Tdxwaji2BZJMNoKIz5K9ZdtgDioRV0uCQjZrxc45QVw/sROnIyiKarDp6B4vEpqW80yg21CtdQzVpKKZyKWypULeYuBOTkQPoDyzr+KRtpk6puNyJ3/l3iRjM9mLqmhLDUtN9wmBCQol1hjoUHPtlAQ2ZFHow2sTpsB2ombDeHKw45i4fM5+4uqP6k9DqV94LkIecvThyK0bAyGcqaaXVPXgRX2ASuy/FJ9Nfzx0IJt1JBvxxG26SFMlsnlyuk/fhZSWJmRA+wD+mcbx2Il6JTRR0aUOW1x10Ts7uFA6c4/w++kNkm7/h1qcGHw9OwEkZtPHFo1qU9C2Y5HhAa18kVriF7N71GRcaA4cNNB3dOoVP01cCfGDz7SbHQ2rvFSakY9bszx8m8ydktZT5IZTvap0ZWi7/DRnFdaSjY3FlnK1lZbtKc8vX76vGBOXLf5FypZc2Yc+NuqKEfGAjYAcjUxXIM+jv/Dw1TU4vAaJOLVzNKvXsp0jld+oUrsnUDj/Al4qLQhCO0eo0tDN0KYUT7BS+R9YJS7BjuthSGhOF6tYopO399K4CoC767shGW91cJwYuLLdUmlDdn7R/ehqFjOOLXMfvlQq9KSIR5OGaP7R8qvqvemsH1N97USBjEFE9CAPWL2uiVz/6umQY3WCOIM6R4oYttZIK0ViQWZyn+O8XuEpoepxXAEPVFjx1eXhl0U8oUWzHEHWTgnS++YTrv7yFQyq1SxRnZ9gmQvNj/s9EyoQ3S6FGwsRFE3Cb6+Sl0VgmDeC7cw8S40DFF6EMxUvnaIjzf1Veb9e0w5OmPUwOP+Gzm3PHyInp0gJOA3nD0dj EiutSL13 aTWlR/3WM1Piu66DKLvIYiGhjqiGN8xIOcw6h X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Dec 19, 2022 at 11:35:38AM -0800, Randy Dunlap wrote: > On 12/19/22 01:44, Andy Shevchenko wrote: > > On Sun, Dec 18, 2022 at 07:19:00PM +0900, Hyeonggon Yoo wrote: ... > > #define DEF_PAGETYPE_NAME(_name) { PG_##_name, __stringify(_name) } > > ... > > #undef DEF_PAGETYPE_MASK > > > > In this case it decreases the chances of typo in the strings and flags. > > I'd say Yes. (and #undef DEF_PAGETYPE_NAME methinks; or change both to _MASK) Ah, it's me who used two different names for the same macro :-) -- With Best Regards, Andy Shevchenko