From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 329D1C4332F for ; Tue, 20 Dec 2022 05:45:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C0EF58E0005; Tue, 20 Dec 2022 00:45:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BBEB08E0001; Tue, 20 Dec 2022 00:45:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A864B8E0005; Tue, 20 Dec 2022 00:45:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 9AE508E0001 for ; Tue, 20 Dec 2022 00:45:40 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id E1C4CAB188 for ; Tue, 20 Dec 2022 05:45:39 +0000 (UTC) X-FDA: 80261597598.18.0ACC4AD Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf18.hostedemail.com (Postfix) with ESMTP id 596F11C000E for ; Tue, 20 Dec 2022 05:45:38 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=F8xxaZB9; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf18.hostedemail.com: domain of ebiggers@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=ebiggers@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671515138; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GgbRzi80NoUPFwYrujeKCI1XVaxy0NN0t2gLcD3YgV4=; b=HUtQFl5G6laW8UoShjPXBKFkoamBn+RQsW8VY8y5+SQe+2ljZQ4lF/XUWdmnPEEJeF/4vj Fn0lYzmnKAMxxeTOgc9udthI9QMsolRcTLKNwceEP+Ai5/GdduoUrS62rjMQlvIJ9rsAAS tVGncfly+CMEzixuGl3xsuQJJ82f9gc= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=F8xxaZB9; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf18.hostedemail.com: domain of ebiggers@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=ebiggers@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671515138; a=rsa-sha256; cv=none; b=Orqb0jxkhton9oX3BFJGULRz9axZXWz+hmXhG8Dp+5bTkFdKIMwOIuEztIt6mfuALURALS ezbr/Ozgh+CrUZjqhSxohvkyO96CneI559BWMXm+SqDjao2fv5my0fo3GZj1ykxdlOTfDx WyimuTlKLQcu0wNYaQXC+RuNeHu7shU= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6590860110; Tue, 20 Dec 2022 05:45:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 817CEC433D2; Tue, 20 Dec 2022 05:45:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1671515136; bh=QcK/x+eqx8iacc7s1AbUsKNKBvDGfjfcoe194ABwpQM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=F8xxaZB9wVAaw8858zsn8j1mrqTrJVesFUAdVe1W83ufJ9sHcvCYkV2q2anEmukUN m1NdhGXzBH6dnyOgVPP1qWonQ5KDZOv4oGgd66a1HDiUHo8tyaR6C3rklA4HaPex8T 6El86mTLGFyzwTBHvO1T6TKqSr1Gluavng5x1qicELSXHhUHzLp5Yt6NrtuNXWla+z OwhmF2NtdbiZ6g7uwEgtX/hs9JZptcnA9ToGBHbwN5w+6ddS8cho+unrKLXqMcqQHL /99nwU6CNZMNgTkrx9zgJkD/Ng5bgFcZ4+HjTqlpCIoQQLeK2jct+t2dfB0xpzdzD4 51h2h+3/WkC/g== Date: Mon, 19 Dec 2022 21:45:33 -0800 From: Eric Biggers To: Peter Zijlstra Cc: torvalds@linux-foundation.org, corbet@lwn.net, will@kernel.org, boqun.feng@gmail.com, mark.rutland@arm.com, catalin.marinas@arm.com, dennis@kernel.org, tj@kernel.org, cl@linux.com, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, Herbert Xu , davem@davemloft.net, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, joro@8bytes.org, suravee.suthikulpanit@amd.com, robin.murphy@arm.com, dwmw2@infradead.org, baolu.lu@linux.intel.com, Arnd Bergmann , penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, Andrew Morton , vbabka@suse.cz, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, linux-crypto@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org Subject: Re: [RFC][PATCH 02/12] crypto/ghash-clmulni: Use (struct) be128 Message-ID: References: <20221219153525.632521981@infradead.org> <20221219154118.955831880@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221219154118.955831880@infradead.org> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 596F11C000E X-Stat-Signature: dsme8id7giuwy3bpx7ixjupnjhoa7wxa X-HE-Tag: 1671515138-282944 X-HE-Meta: U2FsdGVkX1+mvlon/ydRFcN0FcjouSGbBq6s1JkmpA3GdshbFN1YqG+tuU7MfvgWrpNEHnFtUtcwhhJXh4DHuYuoAeVWrbh2oPhP35ErtukFpeIDTN2m+bd1hJSxS1x0aLtuM1m417bDuCo1MsZkPGKfXhjdlxOtJxgFZ9jKZP0aw6KTRTom9vxUVzfYisVFiqShYa2KktNQBPL0z+UUCgnoaluoyGRGCZ/oUQP81x/O1aSuUIvKc/9Mgw+az2GalfBOyNbKbk1WWul5LLbceR0QuePTWio6CatUWGm7cR1xDIujGZwgx8wLLOgDX3nEZ9XShUw6JV80wiZ3TSzWjGFgT2GWbDZknyqczAbazYe2klWt9jMshi6NIeJzX2b/GuV6Wcs7gF0Dj9QJnlQrBVWI25AV11qDKqe26sdiXaugELiliTnYclvx3nXT4jM8oCIztBiHmec+nAlNd55OnZ/+oppRnSqE/zfjmkF+YwsDFo2SAnr5MgY03/m9FkSOTeDZGSHvC26KWFWeW0ncBuTmu7sMLD3Ky0/OPKoW9g901QsHWGze7jvwdRo3Z94Lr40Y0FwwCOWBHTzOp7wZ77SajMk+H0nUZgLn/BSMS8rtPoHCUyALJq15ZqNRSFvL9UlZlD4cL7BZKIVZC/F8CmdnUj8kv9UQvnvwRRJK9uxUnk9qGYGpkQfTEhy7K0Kz9nUdCi1a7FVWTg8fuWuLHDOWNFulrudxbOAvH8+t3YKVS3FJ5MGWhhnjt5dxrNJiExyT6ISwp75SMiscln2Te4u2Ygg2l6O8CxWHPSOQqxtovWHMAx0zMiuaPNSFXTRzKTxDOIh0O0KQpz7A7leWhfku5tm/RuwUSPjclD28Q9Lc5tip2mfLddHLhDYwq1aDow1FTNBLPSiiv3xj3CquqCSJ/AxlQVH5/MLaMXspcmCBLxqPd5WjmHOtamaNSKgACqXmneAe+Af1GX21KRl q6hDtiAr PIRx7Ang+nTaVt/kEJD7K3LT/7EXY7KpGLl0pdaBL6OaxGjTze92mMQQtnUMCq8CVaT6R X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Dec 19, 2022 at 04:35:27PM +0100, Peter Zijlstra wrote: > Even though x86 is firmly little endian, use be128 because le128 is in > fact the wrong way around :/ The actual code is already using be128 in > ghash_setkey() so this shouldn't be more confusing. > > This frees up the u128 name for a real u128 type. > > Signed-off-by: Peter Zijlstra (Intel) This patch doesn't make sense. The x86 ghash code is definitely storing the key as a little endian value, not big endian. The reason be128 shows up in ghash_setkey() is because the code is doing a byteswap from the original key bytes. Also, this patch causes 'sparse' warnings. Can you consider https://lore.kernel.org/linux-crypto/20221220054042.188537-1-ebiggers@kernel.org/T/#u instead? - Eric