From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D31FC4167B for ; Mon, 19 Dec 2022 15:56:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9CD188E0002; Mon, 19 Dec 2022 10:56:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 97D1A8E0001; Mon, 19 Dec 2022 10:56:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8453B8E0002; Mon, 19 Dec 2022 10:56:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 76EDE8E0001 for ; Mon, 19 Dec 2022 10:56:50 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 1BD07120BC0 for ; Mon, 19 Dec 2022 15:56:50 +0000 (UTC) X-FDA: 80259508980.20.FE91DA2 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf11.hostedemail.com (Postfix) with ESMTP id 6029C40017 for ; Mon, 19 Dec 2022 15:56:47 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=zx2c4.com header.s=20210105 header.b=QAL5Ft+C; dmarc=pass (policy=quarantine) header.from=zx2c4.com; spf=pass (imf11.hostedemail.com: domain of "SRS0=Gbhz=4R=zx2c4.com=Jason@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=Gbhz=4R=zx2c4.com=Jason@kernel.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671465407; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=81vP/WZfkabtKBEFH0+IkYNddzD7C35Ot4O6pKjKCUI=; b=IrD7C+7eSqUgIN+1VpCPg+W9HvrEegvSY07mQq+1+5NzxY9wvRSG/huylQgJiwDNR5hCRc MJlawqYDq7rTvcxsPjjgQpODzSd1JTs60OrJh5PPUngfydhra54udG8sRwYwnUOjNRZEhb /W7z4+Z31Mb5NZC0Brx0o6hnzi31LQM= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=zx2c4.com header.s=20210105 header.b=QAL5Ft+C; dmarc=pass (policy=quarantine) header.from=zx2c4.com; spf=pass (imf11.hostedemail.com: domain of "SRS0=Gbhz=4R=zx2c4.com=Jason@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=Gbhz=4R=zx2c4.com=Jason@kernel.org" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671465407; a=rsa-sha256; cv=none; b=dPtotqpkzpOF7xe3NNmKs9oCJeLXYoq1owMkPtvZ1LoFBRjgD08L/lrUhWIAbgOCLUCPyI JeSk3tmv12b/L7Oi1MSDsJlz/zr/p9thXxJ5OXTZ+G9LIMZkLfQn/4AG7C9Ses/izGzjJT t3fviuQMKIf8okdLToV0jrz7BdgVsFI= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 425E661037; Mon, 19 Dec 2022 15:56:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 83A4CC433F0; Mon, 19 Dec 2022 15:56:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1671465399; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=81vP/WZfkabtKBEFH0+IkYNddzD7C35Ot4O6pKjKCUI=; b=QAL5Ft+CRVjgFazjSaWQke+om0MPkMazc/xZcVmBYAxpw5EucxYhwoG/jqyorloH07JPIh 2Co8/IsFgaYX3B26tsS1uLsDb+oqNgS2m4jTopzXzp2LXtEDmXqpF16eNAmTppVsKLepWa UX8TRJrd/Jvnf1V6FSWgDbH69/XNoow= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 4929dc98 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 19 Dec 2022 15:56:39 +0000 (UTC) Date: Mon, 19 Dec 2022 16:56:33 +0100 From: "Jason A. Donenfeld" To: Peter Zijlstra Cc: torvalds@linux-foundation.org, corbet@lwn.net, will@kernel.org, boqun.feng@gmail.com, mark.rutland@arm.com, catalin.marinas@arm.com, dennis@kernel.org, tj@kernel.org, cl@linux.com, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, Herbert Xu , davem@davemloft.net, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, joro@8bytes.org, suravee.suthikulpanit@amd.com, robin.murphy@arm.com, dwmw2@infradead.org, baolu.lu@linux.intel.com, Arnd Bergmann , penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, Andrew Morton , vbabka@suse.cz, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, linux-crypto@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org Subject: Re: [RFC][PATCH 01/12] crypto: Remove u128 usage Message-ID: References: <20221219153525.632521981@infradead.org> <20221219154118.889543494@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20221219154118.889543494@infradead.org> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 6029C40017 X-Stat-Signature: 8bjfrzfzee59fqfmjy4t77y1fwhqn59u X-HE-Tag: 1671465407-194407 X-HE-Meta: U2FsdGVkX19Mk7ytVtcErAKHRwEaTm64ISPGBDwavBQQiRdgKJL6YrnJAka4e/ZBnP6LhXocp4TgRGHG5vrDYaRp1XSVztUBK7v+AsrV8qT1F3MOoG5i2x/ZfgRl/n8YeFPhSPU6uqVjanqavZLiSukk22/oksLWU9/uUfSuHRmIqMOoW6S3kB47TJnrrcUIrMfCppL5r4itZ0LpVtkejjGoDON5YKSlXAOybX4jNpgur5UmoJ65MNxTi2SEJ6Z6JblmBY5LPcd6Wx8+I+KeNEDAv9BdvWGQMi1vjaqy4vB5naMi1T6/8TyLJ7+mZhUBVrjhkWDrzaz0cvA0G3BpYiOaGiwq8hcIQStHO4GoKvbDc6Tu160WzRqxOE8vamR32aFpR2erPR93clPVVjwbS7Fm7z6up9dMyJtOXuwZOLMUqgppPfxpxwE7AEJ+Q7w85/i1XChzNO/847oolNGGS1Aem8A0mmDCRTkhEwWUvoTcxpjwqXrgp5wOYJah7bbJLRnvhDeiAZ/W7i9uDIcRewiu60bxQeCKF2x7GAw7IlZE0Eb1OuOUiLNwuMTfATh/2UK8QToME7KEZnClBpb4i2T8C0iHReH3v29LQf9oWAd49Pcwtk4XMl16Vk3vbQKreJVKP/Kk9eDgRErx8plh4tFhhSJmRgF+IJkdTBcWqD2hCGuRl53vu1ZzOfXTL1FSokiXPjEbVSPSfJdKNwO54+XFvvESFX7KZq/mZOI8UEHlXNPDF76mfbQ5I60z+0CIHfemDHMpWX+2lGZV0yNT1R4RdO/rK/Zi58Pr++DBWjPHhFbxumZ/S6JlCrk08I/gMBZnSWAliu/OXhEK4aRqzbR1n4h4WNhIKrC+gziYSLXo0vKy+WgN5RNX84AyFhBCEZMtRLYt6QHIONJ+1Z7KjdIPIUbaHkWnFkzN89WOnZq0Kj3ess4H0i7xMS/iJAX7ToblbpvTjXpGDJQ2EaB NBvGEWaJ IjD/YutOsNGXlKXU7ClQ7UkzMb4uLnOVPxz0n10G1ETBEqo73BmxOCBKgC16xVAq1KFhU7vSDd00XgFfEP5Kp8Fe6qaKqZHiUZpNUH4QW0TZyzkWtJys+A4J1bM5B29Dv162nM9O5PluH7BP32TYWcQHNWasItCotPhLBYxm5To4U8bz+PCS8Y5nFxO38GboAIaBJMGUvDF0jfemCbR5pV0qY2oXSY4jtp00Mor1sP3YmrrlFA4hdac97ehMbFiAK7af4IME/KM/8IfPF9FokinWRyVsh2sAiBjUn X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Dec 19, 2022 at 04:35:26PM +0100, Peter Zijlstra wrote: > As seems to be the common (majority) usage in crypto, use __uint128_t > instead of u128. > > This frees up u128 for definition in linux/types.h. > > Signed-off-by: Peter Zijlstra (Intel) > --- > lib/crypto/curve25519-hacl64.c | 142 ++++++++++++++++++++--------------------- > lib/crypto/poly1305-donna64.c | 22 ++---- > 2 files changed, 80 insertions(+), 84 deletions(-) > > --- a/lib/crypto/curve25519-hacl64.c > +++ b/lib/crypto/curve25519-hacl64.c > @@ -14,8 +14,6 @@ > #include > #include > > -typedef __uint128_t u128; > - > static __always_inline u64 u64_eq_mask(u64 a, u64 b) > { > u64 x = a ^ b; > @@ -50,77 +48,77 @@ static __always_inline void modulo_carry > b[0] = b0_; > } > > -static __always_inline void fproduct_copy_from_wide_(u64 *output, u128 *input) > +static __always_inline void fproduct_copy_from_wide_(u64 *output, __uint128_t *input) > { > { > - u128 xi = input[0]; > + __uint128_t xi = input[0]; Why not just use `u128` from types.h in this file? Jason