From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CFCAC4332F for ; Mon, 19 Dec 2022 13:45:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8D20D8E0002; Mon, 19 Dec 2022 08:45:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8819E8E0001; Mon, 19 Dec 2022 08:45:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 771038E0002; Mon, 19 Dec 2022 08:45:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 685048E0001 for ; Mon, 19 Dec 2022 08:45:21 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 05FAA80361 for ; Mon, 19 Dec 2022 13:45:21 +0000 (UTC) X-FDA: 80259177642.28.BF3A92E Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) by imf02.hostedemail.com (Postfix) with ESMTP id 482768000F for ; Mon, 19 Dec 2022 13:45:18 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=DCX4oCln; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf02.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.174 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671457518; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jWwojFcgvooRzwcY3kRRXotYy0Om3fIUII0d+MNiGwk=; b=dDNF289g4N+12tGs5g9JI37qk5MhByLaOwX1HrO5ydelwwHh/KuG2dWo4d1uln8ofSQpIL jy8gJMkuYxOwPRQ3ZCulHcRqNaspk9O+tVr7J6U7+ZbSSv6VqbDNYbME1DfdDMLoA+fz98 fEcFFSFdPGf/LJdP+b1VjcCOrDBDESE= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=DCX4oCln; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf02.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.174 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671457518; a=rsa-sha256; cv=none; b=4SOzQ5wMJJ0dsqNZJu6jNBqExaAuUlt/Y3QOvG5UpwUtVEzw4JZ7K71Iv/6GLKKaKllVWz ovKvulxoX43gtv+VsV7kyCgQw0HXzGEMx/wA4Ofx34ZnJcdLt//XwJMhDMA3LFJQzPOeAV JzaWULL5CAEj0XD/hZfsESEohHZZQP0= Received: by mail-lj1-f174.google.com with SMTP id n1so9140870ljg.3 for ; Mon, 19 Dec 2022 05:45:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=jWwojFcgvooRzwcY3kRRXotYy0Om3fIUII0d+MNiGwk=; b=DCX4oClnCIgAyv3gYJysFwGq+V35MxGf31bS2oPI+Qlj6V+ShxpjLS+fsVZGUJRIGB ePr5ErZB25VyS5xSovUXRmeinqXroS7xO0RPkn8q/4LjXjN2HMBNSZ+Tv/xI+t4wYe7F 4ezcRe4auKulMdTwyLkDTG9i7X9UCqf0JJQqv9R2pgbzy1IRhaBSFnTkrXK7zGJ+RGUZ /RNfIaSJq65/UmxNw5IDqYswDIsPII8u5v8P1u7CKWN7PYjiyr5912bvTdMX2+9remoP 0ZYn8CweqvMn8nep95lYI7tsfBxe9WpvYJIrKdGMfoS2E2tiiy/Ibcv7wdLeBOcCDZg/ XViQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=jWwojFcgvooRzwcY3kRRXotYy0Om3fIUII0d+MNiGwk=; b=bw/X7r8tMd3JMyZoBNYspi9v6OVwPv9nTBPEb5gN7K9wKeY32FmJcLi6av0OBXe0sI uUw2vHO78KPTPTBF11xbP5QnLCqT4pmqODqGF3LGN3X8nt8WTqklf/ChSqHaL3lCW/ho 7GmBgetq1aZiq4bpjoUUPH9TqojKUPnjLPen28WF6/lBYgliYvTpVepEpW4bPMZf0M0F SiD5iYJ5O+lNk2eG9IvK7YEz0SyGEma2GmH/rfxg0veGV7i6W/6EqWvJLlASEs83bYdG gVRX3Pz4TpA4x0UpT/9QXekr5Ta5XEBZolJAtWfYhg4xgz+opV0iCincau4mZPKXvFpU RG1w== X-Gm-Message-State: ANoB5pm1bFN560MPoCM6Ve/68Z6vfolr8Kr2EN/ooAt5PXNEz/okJxFz dTZpUBsbPw2ge103NBVqDGU= X-Google-Smtp-Source: AA0mqf7+uq1OpLbr8wQHGFpw85OrlLg27KxT7NatFAHD95oOGfxFSNWgBz05V71hYkPc54ZhaW6EwA== X-Received: by 2002:a05:651c:98e:b0:277:351f:8cf5 with SMTP id b14-20020a05651c098e00b00277351f8cf5mr10873377ljq.3.1671457516389; Mon, 19 Dec 2022 05:45:16 -0800 (PST) Received: from pc636 (host-90-233-218-120.mobileonline.telia.com. [90.233.218.120]) by smtp.gmail.com with ESMTPSA id g24-20020a2eb5d8000000b0027776efa48csm760923ljn.91.2022.12.19.05.45.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Dec 2022 05:45:16 -0800 (PST) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Mon, 19 Dec 2022 14:45:13 +0100 To: Lorenzo Stoakes Cc: linux-mm@kvack.org, Andrew Morton , Uladzislau Rezki , Christoph Hellwig , linux-kernel@vger.kernel.org, Matthew Wilcox , Nicholas Piggin , Baoquan He Subject: Re: [PATCH v2] mm: vmalloc: correct use of __GFP_NOWARN mask in __vmalloc_area_node() Message-ID: References: <20221219123659.90614-1-lstoakes@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221219123659.90614-1-lstoakes@gmail.com> X-Rspamd-Queue-Id: 482768000F X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: b81nhb7gpjpia3m9m3jmf8tz83p1qy6m X-HE-Tag: 1671457518-81042 X-HE-Meta: U2FsdGVkX19kF/fuhGiSKH/u4NLonQlw/1D+CkUjHgYGDB4SRDXohR5NlGVRgLpg2TMw3sEBlDZOGzO1hwR2VTXo33lVvSTvmmtTI41YlOc4bJzRthvchXKSiNsuq6BaPLagvkvIx7mYAjB8iqlRLqhmaxsMc+SttfenwXkmDZgo9vZuSQZPZ/J6RADEOM3MUifND/pdl3dDklYxhcGIRSAl0kG979BYlbcE8+MCRa2FeE0xrAEnMJ16PImSWi9818McnvUiXwEB/T1KlxrOqSAy5oZJ3NHKdp+mUbt2U9PC+1MUG3kYANMzDL1ZELxy68BqYKscan5kcgw9QV/tk5ilQkCz7lQ1mWYrrPPye0Uwxh/qG1gwQWS3YP/TxU4PprNZy7Be/XIPpGqOSwyrERjY+gdwJYDQu9vx82x8LmVbPMwmMfnV4tjX8nkXa9cu8RyooTpnCWuXTZMdErvkLR2RMq4rWXskg1aw6UJWnSOSy3C7aswuxa/SQdIwrq3AwBGFdBhVlh7P/eBVaRRy4IWm852u+EWCd23HAyhFQEBKdDAKmqJ4cIhPEiQeqsR8yfT+lxuSnYrz39vkSR29DX/0yTFwyM36RX8PuhqBJcxG7iwlZ9lgJmYa6DDtci7t5OfqHpr+kg5IqGzcdZ/M0l2TIEZiHQSSWsnMFDWSLfBMXPc8w0X4afzcN4yqcJWwaPjr5Hg8Sj7iu+AMQnFiEEeiCyVbNT4nC5XmWEI+YH/8uKi73XNJG8IWAomD6mo9G5XoWtNykjM8W5qZTgIDJ7YJnlD861iTN0XqNa53sqt4wMECwv6U1IOTlE6cbdwvoSkuCKGEDHby+UNhggvqtWGR+vmBDMnWnwYX6b2agIwlo+4cYfHGt3p+NlcIpMyo9bDNYh7ogkt1HvNgB/WDGzFjaCQmpxKRBF8OsIP8KNykyvW/Pr0IKf6k7ErzpDw3dYKkjQket/W5tPa6giG vRIXkg2C P5Sb05r65lZcjWySEMVHcCUHdiTipBq8eyQsDqkmtVFaOXfDfR3639FewoLJV8dUgTYppbOEAYAwnySF5hQGt3R4FeJ08npMl/yOJWnZSJHVwTeZRGeIXkQ+cxUSaTmmG52ISgdh8na9whyE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Dec 19, 2022 at 12:36:59PM +0000, Lorenzo Stoakes wrote: > This function sets __GFP_NOWARN in the gfp_mask rendering the warn_alloc() > invocations no-ops. Remove this and instead rely on this flag being set > only for the vm_area_alloc_pages() function, ensuring it is cleared for > each of the warn_alloc() calls. > > Signed-off-by: Lorenzo Stoakes > --- > mm/vmalloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index ca71de7c9d77..10fe83c24436 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -3031,7 +3031,7 @@ static void *__vmalloc_area_node(struct vm_struct *area, gfp_t gfp_mask, > int ret; > > array_size = (unsigned long)nr_small_pages * sizeof(struct page *); > - gfp_mask |= __GFP_NOWARN; > + > if (!(gfp_mask & (GFP_DMA | GFP_DMA32))) > gfp_mask |= __GFP_HIGHMEM; > > -- > 2.39.0 Reviewed-by: Uladzislau Rezki (Sony) -- Uladzislau Rezki