From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F2C7C4332F for ; Mon, 19 Dec 2022 12:25:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 897238E0006; Mon, 19 Dec 2022 07:25:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8477F8E0001; Mon, 19 Dec 2022 07:25:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 70FF18E0006; Mon, 19 Dec 2022 07:25:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 60B7E8E0001 for ; Mon, 19 Dec 2022 07:25:45 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 372451604DB for ; Mon, 19 Dec 2022 12:25:45 +0000 (UTC) X-FDA: 80258977050.14.9E75F4F Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) by imf06.hostedemail.com (Postfix) with ESMTP id 7E9C1180012 for ; Mon, 19 Dec 2022 12:25:43 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Ffa7ivEp; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf06.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.128.52 as permitted sender) smtp.mailfrom=lstoakes@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671452743; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6xtO909pl0UcIRvFN9l1f5KN/TIemT+O1LrAgXX9vkU=; b=irR/PVOuv1mf1PuCP9HKS6MlD1ZhPk9fddixNku36+BJ7yDdc4uKKevKvfVjihGFdSxX07 h4vtdyRSPM0ioowMsnbOgSsVjD5vwXO23d5Bv0soL3ptGCL7PB9i+Bn6B4lY8wh8Q2FPVT ekaMEMYoIWcnC8AuZJuRI9i4gu1zOqc= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Ffa7ivEp; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf06.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.128.52 as permitted sender) smtp.mailfrom=lstoakes@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671452743; a=rsa-sha256; cv=none; b=w4Fb8d39+ACnbJ2w/6W4vwjyM7L+dmDyxQav0PG3v6NmDGwiyy9m/f7BMXREXeOQqh4weX YKnQEdC3H3yDW3BD5o0lD+qUL34sczDUSXIB9JfbCBgyc09rCW9cppHRA90G7jTJe/HQEf jvkY/pVffXRIqZ2KJVhBWTCJvwIga4M= Received: by mail-wm1-f52.google.com with SMTP id v7so6324162wmn.0 for ; Mon, 19 Dec 2022 04:25:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=6xtO909pl0UcIRvFN9l1f5KN/TIemT+O1LrAgXX9vkU=; b=Ffa7ivEpXIQxyuhbHNnuIhTTaUiL9Qm3+HHnhXbhrFXeKPK5eFZschrDSKZ0xGVwFN 9hLdF28WWz+WJh0rT3PXLBQuRIXx/MunX2vPlZfZRXM0C9FPfvgIl6FZfZJKzypnhJD6 e3Cm9ezccmpKNSPjZA+ZkU9k84TS0tA835cmlQMijCSvJ/dA2q/jlo16sRnIAuB5fNs9 z2NrorlBblpuGiomjS+cnI2/g6SMIXTwwRVKkcwEq/GDpvCpqls/FpP6e6U/9L5z34FM HMEfFHtrzzHoB6Uexgzcvfkfo6Ms70k8h/ei2l1m4PBwUiBjyfMXKpFAUGF1fdz9FhU0 VYvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6xtO909pl0UcIRvFN9l1f5KN/TIemT+O1LrAgXX9vkU=; b=Al25+/4kCmLuMwecS83LeQvchlYsA71OOhGQjQPgyFiv+DpBt945kIl+NwSHujT82J 60q137ZACexah73n6MSj4a04a45XuG9S08+j9Hs5HqB7bViLpfhov4LHi5+S/o0oAYt6 nZim1sWmzI9dxwnOHDnaGyWpdTpOzbdlBogSDGkKksRkXFY8h7/9jSDMq9e7WXMlXCRi IZY8gQj6FO8D4AT4XjDuIddOWMF4FXIQn5lCZx6h4g1qhDZF67ie+Y6XMHwgzkJ4sjK7 nXYTk42/zj2y+wAYYp/QJWR/rkKpYZJcAxr/FWP37YgHAMG8tYnfYIVDBzlO0DaU3hzO qwtw== X-Gm-Message-State: AFqh2krw+UqTlkOLssz2GSnF5TFA3LzxqVUMOZqKdrDY+6vV7oN0q70P qJPVyqFBTHqJ1J9VKMLP2s4= X-Google-Smtp-Source: AMrXdXvMz7fHiAQBvJj1E2uBu3Iwl/b1kWUnGXJKxWkItdRJIZIZ6KmVIO+inEq8eoNz5V4R8qzZmA== X-Received: by 2002:a05:600c:3d85:b0:3d3:59a8:252d with SMTP id bi5-20020a05600c3d8500b003d359a8252dmr2390600wmb.9.1671452742017; Mon, 19 Dec 2022 04:25:42 -0800 (PST) Received: from localhost ([2a00:23c5:dc8c:8701:1663:9a35:5a7b:1d76]) by smtp.gmail.com with ESMTPSA id l20-20020a05600c2cd400b003c70191f267sm19325099wmc.39.2022.12.19.04.25.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Dec 2022 04:25:40 -0800 (PST) Date: Mon, 19 Dec 2022 12:25:40 +0000 From: Lorenzo Stoakes To: Uladzislau Rezki Cc: linux-mm@kvack.org, Andrew Morton , Christoph Hellwig , linux-kernel@vger.kernel.org, Matthew Wilcox , Nicholas Piggin , Baoquan He Subject: Re: [PATCH] mm: vmalloc: correct use of __GFP_NOWARN mask in __vmalloc_area_node() Message-ID: References: <20221216234659.493794-1-lstoakes@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 7E9C1180012 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: 3a8mrxtfbdtkhn1no8gpuzsbgpi9u47d X-HE-Tag: 1671452743-443557 X-HE-Meta: U2FsdGVkX19ENY2nZeGbzXogYicSN4Z8j2kPPTQJB6V3NPesKM+4MDNjMhu373fxrUlBwoQXuQhdcCMCfNiDeTtVBycXmdTmAnug3NF7vsRcaFauifY2miJkhaeeO9gCvaVlrzTeJHETI7tkbQW0W3t5HuBPml0LDBRnJMMyw0WHmjORFlNrvmwzSAN+f7XcxiehuBJx17ZSdxPIz+5jCqKblzZMAHfIuCutAMwpmGU6kBUAjiFUAUjccygPc7vgZhgd+5xImuig30wcbGDoV7U0BL0GgLpx4nkwR1Mb+GSRYIXOXTk9LA7RaS0JTzkJ0u7dizZ1oQhSfZZRRpsYWU+H2/U8jRbjzyYuraiiKseIfBQ5l2L68ay9GzjO8DPM8Sh2K9G0+jsVtlpqqp53p5BGn8palVYg0+RVHJiE/ESQpEOrt9yOwaZdVQNHTQviMJrhMHSpC/0QummR6MXEU3jBKPZFrMXOIRtW8gHI84PxmQePNkBGCD/7nvcKqsvDHvLWecoylbkhKxGIxCnuW3FnOWTU68UsCnMsPbTYvOnXtcB9rR/uYXIIbjJTAgYsbesiNP8ealxV8REwMHsgkNk4qF+qUTL1JgVIInIbBS/He1xfY1X8HwCgpodXbld2uf/qqfjudhMpbIgXAeiExT1LOjrGtJSQfu2CDfvUbngMA3ef2ymyJvUGFNE4d/dKc1o/AII63bmGsXGiNIgrtl8ayF8X+a+L3IY2AD5RHJwgW+gQuuuArkfmaZkYN2coqrlrbSgc6c63UU6DFqDFhaDqH51jwALQBKw6jtIiskEAMNO3EDIa/ko/bRYHgAtOsKTh7e9VPVonKff6OS9c7gHHv2L/Xvzhh9khTzQiXrzXp7+1dqP7plE8Zjg512MKCgtbu4+sznNngA121VajwR9EnrqBgzgBLMN5S4kL/pHEo0Uq4/zXxfS7eSDnD1I+2fu+9krb6LWDai2UdS5 5giprUSY 36GrWa6PjfD4lL6WchIhVcMpeWTVayB54r6Q4xjiSPeE+nChQdeQhl2sT5a725P1PVLt+vOQwt0FQr/76S7x9KE8wKYoYqwk/3ec/cXWYJUI1snIPivjwz5YmVCRfeHBbIQQ2oXH8/YyizUo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000214, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Dec 19, 2022 at 01:09:41PM +0100, Uladzislau Rezki wrote: > There are three more warn_alloc()s below. Those are explicitly disabled. > Could you please rework the patch and make it working also? Ah yes, sorry missed those, I think then the simplest solution then would be to simply yank the __GFP_NOWARN specifier at the top of the function and restore the explicit flag being passed to vm_area_alloc_pages() you added in c3d77172dfc0. This whole thing does make me wonder if this function is due a more general refactor. Will spin up a v2!