From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B227AC4332F for ; Mon, 19 Dec 2022 12:09:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4851B8E0003; Mon, 19 Dec 2022 07:09:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 434DC8E0001; Mon, 19 Dec 2022 07:09:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2FD128E0003; Mon, 19 Dec 2022 07:09:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 210B48E0001 for ; Mon, 19 Dec 2022 07:09:48 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D743616090B for ; Mon, 19 Dec 2022 12:09:47 +0000 (UTC) X-FDA: 80258936814.27.34766DB Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com [209.85.208.171]) by imf18.hostedemail.com (Postfix) with ESMTP id 04E091C0019 for ; Mon, 19 Dec 2022 12:09:45 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=e2KfN0rx; spf=pass (imf18.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.171 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671451786; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cFpsTThPmorTzxNRzB4rfnvG2I3ODpNOkx2axpQ+YZM=; b=OJsJCpeXnahISQjas03zjmGgSh50BKew14e+1uItTjIf835PpIjRfLRn5eQazLYJmK7wRj MlBPC6RcigZRVYi97QpyKkvuTWhnWqPwOdFQ6T1LcJekWGjH+OqAQESQDUwjpKRfXGVkNp mexPg7ZH3gmLIf8YLjP4o7Bnk9H0ux0= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=e2KfN0rx; spf=pass (imf18.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.171 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671451786; a=rsa-sha256; cv=none; b=Rxia4+MMTpQZIk1qLyGsQmU/jeexiaBG61V7tGR/yDAelOD6dqddGX127Y8bMF/lLSsnSP 4RxD3OlCE3bVtib0RGMOLNmMf68v3Gnq+YsI617WVlbinRbxvoMhoNE4UlZfPv2KlPOev0 e/h1VeM0g6hwFKY0FooNhdzrFJwoaVI= Received: by mail-lj1-f171.google.com with SMTP id z4so8848426ljq.6 for ; Mon, 19 Dec 2022 04:09:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=cFpsTThPmorTzxNRzB4rfnvG2I3ODpNOkx2axpQ+YZM=; b=e2KfN0rxqpiI7hyUA6YPq+O+AZf2L2DGqPAuoga+hbJGFNHHBxNslh+gg/8nV0V07T FFkkVQG/FZrtELqoj6hIicjz3From4MRb9kHqv+sFV6AkOwNEdD32IwBOdhDCdC71QWc f8T9o3Wwj5ZP4zjUQGAe4RiJ8KUBJR7k4Hl6cZP1E7gDwiZ/hVbsZnNwh95sB9oLcM2c //gw8oY1UbvOZyFv3PHDUSWeNN9qV5DS6rULdgK3j1NIDdKCPdZEbiR3Vl/zm+5ByIkF 2WXAFgNgJ7w1k6kGGFJVc2xvHfauR7AKzt3LgDf/z+WFWPtq2eN8D5wuEG+X2kHYcA3o Wk+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=cFpsTThPmorTzxNRzB4rfnvG2I3ODpNOkx2axpQ+YZM=; b=CAfePfzufkhBMDYC19J3GvLC4kkBMxvHcuJkfJmVeOban/BcPUHXs45QXiCmm9N0OI zlAXeaIqi1+aDQcza9BvYQOsE0ZcOkhFJAQf4Xlhew7tMz4zeVsn46L+6fugdG1qE0mG 3zC2ae7oLoiNBVeS6tB+AWJBV1Eim4XwC2Z7k1VYlbb/31zYx9SffFHeKDgYY5+b7mBO YbTjgZ116I5nVFJ+iott0DMIt+lXNqWEJJCg6A2sBtXUeJrwa1nNNUMbXKpyJr7rv9a2 tKVU69junRRtCTNvRy7Rkcw3FbtEu9hJdArVYOMcwGfqfVDwqN1PWWd2gtFR2FVco+3l c97Q== X-Gm-Message-State: ANoB5pnpQKbwtYJfupWk2F0oETBiwQsW/7bs5TnIQJMy/wCcg4Cf1afk EUGpK4BbnNkv2trdsXdsk/E= X-Google-Smtp-Source: AA0mqf5TpqUc9wLalJvJYIOBc8Z2O6Cujk7fCi/aquD/84yzL6J77NMJKsfpL5OWuhTUVtCXwTsZLQ== X-Received: by 2002:a05:651c:1591:b0:277:413:7da3 with SMTP id h17-20020a05651c159100b0027704137da3mr16498313ljq.49.1671451784246; Mon, 19 Dec 2022 04:09:44 -0800 (PST) Received: from pc636 (host-90-233-218-120.mobileonline.telia.com. [90.233.218.120]) by smtp.gmail.com with ESMTPSA id z3-20020a056512370300b004949f7cbb6esm1080718lfr.79.2022.12.19.04.09.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Dec 2022 04:09:43 -0800 (PST) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Mon, 19 Dec 2022 13:09:41 +0100 To: Lorenzo Stoakes Cc: linux-mm@kvack.org, Andrew Morton , Uladzislau Rezki , Christoph Hellwig , linux-kernel@vger.kernel.org, Matthew Wilcox , Nicholas Piggin , Baoquan He Subject: Re: [PATCH] mm: vmalloc: correct use of __GFP_NOWARN mask in __vmalloc_area_node() Message-ID: References: <20221216234659.493794-1-lstoakes@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221216234659.493794-1-lstoakes@gmail.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 04E091C0019 X-Rspam-User: X-Stat-Signature: 48pup7q398oy8ryzuumn375cwa7pjiwc X-HE-Tag: 1671451785-964159 X-HE-Meta: U2FsdGVkX18A+e69/dbpv1IW93X1cI3l/5Ef6TSb4zp/PhSREVzO3tmbSq5H+fGTH9+8qvf5h1tZJooaxk+WgZChFPNU2DN2OOXF9QG9iHNquZK6eWf71FJlCR0WNxt3GPaofGwzYqyaxX/KZR9U3xvWQsK1P4b63Zm1e9LYGX3B1LFDBAykY0MHwj6ZYaa7fgUqYBIn12js5iMkLdzgIzDCMMmgkqtfOGKZ+J5yzNBrlXv1QyrL6MfZY3nY2zTcpvL/6oMqsrMKg1obWPN6Da9aOetrX1mBBromI5fzRmkClkk5uh9fgF4oUUASREjh7oBEsAHjuL5dp15k/+iIzG68epJ24nD3vrxu8jwuVJYxJOZfs8/6GfK8iVjO+3YJK1D8RWNUO7s8WJqXPmzzvo4hSo941ic7OyxoDIQTI5y18tOj3TmX95g/qMNPA/yRxPcScXK4cUxGG+RykaOl9D8D76d8TolaU+0UERxrZqOwvFkAYxHv0D2gL00IVMIAvNMzCVh5WsMMjXrgHCenq6zM32W4vbXDVyynfPnfcn89oIYNBR+MZgCT7SyHNvAQalpQCQxbwvtjWOi8vdCxx57fzhHZDF/oYIKeQBqzBbzjM3UU+13tgnkE1jQszi0la9HTgByXr4csE+MECEQ6BjFYHBY0KJD1Xq4+zAS5KiVU5pwGm54wHWoE3lSD39YvcBUE37ZydrMgwrcLDGql2b6RJ4H2T0B4nvONDNvX+RIp3+bzSeCD0IGT56ZuuA3yiTqPdIkhHPtogTvE0APwYGhjURisj+++JICbK+e1aCd9JVhqNM+5srMoX6jjNc7Yf+9IWRYA9VAYnw0OA4upL+x1QakuPBX/xi2XnCyr4naCnLtBKqH5AnHDXNrBOubyVV3Ln/4tzNNGw1vUT8bTCp0gODaCy6AAaiwa1mj8GAt2NYCqFF9DJnOSkZfMfEYAljkW01NT4Ry8naLRPLr V1T5UsHO PllGEaNG4sYd0skZJsm/r/KxFDSaossP5xjpARM6uONcwt0O+eQArdQaWXnZF3j2lfFUrMPDWUubyTlYLUFlnpkQ5mrhA9y2fxpP8+hkAuoPDre8cjbbrtwj9S7qCPVLRbU8CFcbxs2mZvuw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Dec 16, 2022 at 11:46:59PM +0000, Lorenzo Stoakes wrote: > This function invokes warn_alloc() with __GFP_NOWARN set which is a > no-op. Set this flag _after_ this call so it is actually invoked, and > additionally remove a duplicate application of __GFP_NOWARN afterwards. > > Signed-off-by: Lorenzo Stoakes > --- > mm/vmalloc.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index ca71de7c9d77..9e30f0b39203 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -3031,7 +3031,7 @@ static void *__vmalloc_area_node(struct vm_struct *area, gfp_t gfp_mask, > int ret; > > array_size = (unsigned long)nr_small_pages * sizeof(struct page *); > - gfp_mask |= __GFP_NOWARN; > + > if (!(gfp_mask & (GFP_DMA | GFP_DMA32))) > gfp_mask |= __GFP_HIGHMEM; > > @@ -3051,10 +3051,12 @@ static void *__vmalloc_area_node(struct vm_struct *area, gfp_t gfp_mask, > return NULL; > } > > + gfp_mask |= __GFP_NOWARN; > + > There are three more warn_alloc()s below. Those are explicitly disabled. Could you please rework the patch and make it working also? -- Uladzislau Rezki