From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6BE9C4332F for ; Mon, 19 Dec 2022 09:44:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1BCA38E0002; Mon, 19 Dec 2022 04:44:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 16CC88E0001; Mon, 19 Dec 2022 04:44:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 00D5D8E0002; Mon, 19 Dec 2022 04:44:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id E13718E0001 for ; Mon, 19 Dec 2022 04:44:27 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id B39781C5EFF for ; Mon, 19 Dec 2022 09:44:27 +0000 (UTC) X-FDA: 80258570574.25.872ECB3 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by imf04.hostedemail.com (Postfix) with ESMTP id 2E0B340018 for ; Mon, 19 Dec 2022 09:44:24 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=DM0fzdlS; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf04.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 134.134.136.126) smtp.mailfrom=andriy.shevchenko@linux.intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671443065; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0cwVbxefDY27byFIlijGZm+fNC0t/wF6ObvC9BldySw=; b=vkXV0QtwQVqeqBHXS5+H3wsHn2JJ95vpxuwjOhHA1gVoQfWroJ9AFqVOnt5Rr2VniZ2Ojk xXLO+bisDXDEkoQ4YzbwOHeRD4tVKDrPInQxaRMgq1hU8l8rXbxYiPMBeIhMo3AXPMAqjx RnnUksMAFvy2qad6vBl3XODIbr7CcSU= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=DM0fzdlS; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf04.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 134.134.136.126) smtp.mailfrom=andriy.shevchenko@linux.intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671443065; a=rsa-sha256; cv=none; b=umPfuIOLAEQercLPovQLucyto98HsKlROqUK5QstdKPLN4dWx5yT8+EwNggsE9iMOFzfR+ Fb8/Je7e3bLMXUcIKpcnhTv2nfU4wKgnPN0XO2XP5c87bwERPRhs53x8ARYQovHOz1biUJ O3nKKM74TN8kH2X5K3ucQ0eq4pk+GH4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671443065; x=1702979065; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ZPIbaI8Fo25hM21zchenFK+gSCjoAt+0YV2aFj835DI=; b=DM0fzdlS1/rDMvIRErSTFogopBsQIzKl2plgUlirpCJGEsw2FQrMhQnI 5+YLazpUUamqtreNC6bplS3qBXOWeJzQat7XEWeco36Pq1xoHfPKUOVhI 2XZo9iF7mzeKgh+n5JkYUyTX2K1F0chgLjMiw2JXxaD24GGxutlpPVpUI UlP0W8BehjMfBaJteQWQx/U6ZY1I/SmHcWiJKUmmcvsB1teyKqf8pP3Mm rQKAV5jgdMYf/GxHLbZ31n0zazph3m1Z5mlfxl0+81L/KBsrZWQU/ezHc d2ZX8y+oW/2ACKLS7l5E3aowGqLHDRKmIv6ZauAzKwHTiwldm/dC4v9I9 A==; X-IronPort-AV: E=McAfee;i="6500,9779,10565"; a="302735797" X-IronPort-AV: E=Sophos;i="5.96,255,1665471600"; d="scan'208";a="302735797" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Dec 2022 01:44:22 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10565"; a="643937254" X-IronPort-AV: E=Sophos;i="5.96,255,1665471600"; d="scan'208";a="643937254" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga007.jf.intel.com with ESMTP; 19 Dec 2022 01:44:19 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1p7Cgy-00CDxm-0q; Mon, 19 Dec 2022 11:44:16 +0200 Date: Mon, 19 Dec 2022 11:44:16 +0200 From: Andy Shevchenko To: Hyeonggon Yoo <42.hyeyoo@gmail.com> Cc: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , HORIGUCHI =?utf-8?B?TkFPWUEo5aCA5Y+j44CA55u05LmfKQ==?= , Joe Perches , Petr Mladek , Matthew WilCox , David Hildenbrand , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC v3 3/4] mm, printk: introduce new format %pGt for page_type Message-ID: References: <20221218101901.373450-1-42.hyeyoo@gmail.com> <20221218101901.373450-4-42.hyeyoo@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221218101901.373450-4-42.hyeyoo@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Rspamd-Queue-Id: 2E0B340018 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: 9awq3hrwuqwhtmdtafnj55sqqwmbygzi X-HE-Tag: 1671443064-961926 X-HE-Meta: U2FsdGVkX19JiK7TXzM47V3wB6ddFpE0+mR6GPsyssuPaOJSTUJQSZA0bm0jp4wKA34O7nIzo6Tom2QA4r7BNKER9pcObrTm4w2dmE8qMtYamAIeBhuDIA6X4VtWKyq0djNGGPRkObMwKWFx1yEit4bZImrV2pGal48XBIUsasa+WDrb/3OyGcUjb7IYlfVWmHWa0lkO46VowXU9IcPPPAl1/3HRbNYDFvHOtXX60FkQ8n5WDFZvy7kCnzNb/5OuDU7sHQNcHPvBNnn6y3ZHQElYFLi0kN8X4j42HB6wDT8vIKuoevkQ2/UrncHW1y5d9c7NUmhK16+itMJiHcfNz1ZAraQ5f6F7rIKML9iS0B8pEcrp5LLMrZpRaKe2Ahr8y7DPLjViqGaPbumpTVHUW418VfXbb1LvkaR6uBK2vSmgDDTaxBP+9d7v6x1Vv/KmxlIy9zoHSt4Ulme3uPD68PyC5vfVI3Yd0IlxoQZdmE11exxSx/HjZlF14qsyhdabDzsrQcCBugqvKeVxJsS/Uc6YMw2XSNjzpgXJeJV787jsKJB0u8MC0SVFuStaNVvm8YM+phv1erpuJYtjw79+jny3Tc+aw2hkcl2SojLrngTZH8VWd67wzuWynJ35bHL44iy1+8GaJsCFehYZ3St2oGUF0vg1B+urm2jOatlgFk7GoOHr5k+9BGmXCkYOsXYsZGj42kIKQdXskNmaGOZeTEnPqSBR4G8B1Muh1Taqalh6cyZN8yG54D/0CqHdADD3CK1hQj2OLMnNeL8RXyQUH/NhMYjSQX61JJAXksu9sCiJB4frD6lAXAW0i842w/rODybd0IrPdh+Yo3kkXwTmRUMDbMnyFlqIE4c5y2CcCTTUJSaWY0pvdKrLJT9a9Uy8l2sDTnqc+0Atb2CLhZb/VRDjFgxJW2jbks+adV8fub7TEEq2tjxOcnmQ3AMBFL3cOb7OAZWSJeKPzw4ETai BJTJ6I1V IocCvaObRMUdDnDTUkvJpw0RkMZ6E/kExWiML X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Dec 18, 2022 at 07:19:00PM +0900, Hyeonggon Yoo wrote: > %pGp format is used to print 'flags' field of struct page. > As some page flags (e.g. PG_buddy, see page-flags.h for more details) > are set in page_type field, introduce %pGt format which provides > human readable output of page_type. > > Note that the sense of bits are different in page_type. if page_type is > 0xffffffff, no flags are set. if PG_slab (0x00100000) flag is set, > page_type is 0xffefffff. Clearing a bit means we set the bit. > > Bits in page_type are inverted when printing page type names. ... > +#define __def_pagetype_names \ > + {PG_slab, "slab" }, \ > + {PG_offline, "offline" }, \ > + {PG_guard, "guard" }, \ > + {PG_table, "table" }, \ > + {PG_buddy, "buddy" } Wondering if it will be more robust to define a helper macro #define DEF_PAGETYPE_NAME(_name) { PG_##_name, __stringify(_name) } ... #undef DEF_PAGETYPE_MASK In this case it decreases the chances of typo in the strings and flags. -- With Best Regards, Andy Shevchenko