From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6026C4332F for ; Mon, 19 Dec 2022 07:16:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0F2458E0002; Mon, 19 Dec 2022 02:16:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0A4A68E0001; Mon, 19 Dec 2022 02:16:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EAD798E0002; Mon, 19 Dec 2022 02:16:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D77918E0001 for ; Mon, 19 Dec 2022 02:16:29 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 929E2AB084 for ; Mon, 19 Dec 2022 07:16:29 +0000 (UTC) X-FDA: 80258197698.23.3DA02F6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf16.hostedemail.com (Postfix) with ESMTP id 337EF18000B for ; Mon, 19 Dec 2022 07:16:27 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NZAziHm5; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf16.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671434187; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BdWW4mbATFocYlfd/RqNiXq7z60CEKDBIQVxKlktu5Q=; b=LpiRs+l79q9vdH8x5IAlxtcJPv9gC/NAAbY9EqgKG3l3dvMq8gYij1AN/rszZ/h/gGFSZg u4hJMwibuO8DxQZ5Q5aYCIobiAiYjGnwqO+CI+Zhp16CudVj9U11CHUULAty8R+YiE+D8p Y1plrdW5AwRcVE7LF0fdvF/58G7WhLQ= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NZAziHm5; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf16.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671434187; a=rsa-sha256; cv=none; b=PS/162CfXXPt5UFJ4mMjjcZvu7+7VLW5V+mInUTj4qc6OkceBOrIux8sIq0MVblQkZoA/T aFMYoJU6snBud+4yyNXDtlUDDLgVv+GLtV/evqXjzphVMGjS7CGTV6mzYVK9wZnxi2sUU4 zhgCg49jLECFlIq5qzafNInHjoKxeKs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1671434186; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BdWW4mbATFocYlfd/RqNiXq7z60CEKDBIQVxKlktu5Q=; b=NZAziHm5CmG4H0w3Rdkyk97iCYRnGGLCT3QriTAInjJAbGl8Cj6ajFRI6hHNMQZdq/Ctew EuVaxtbrCOEZQWBeK9WCSSL4MaXBbwt+3zFnnFTBiK9wgRvUFJ5Yt4D7QOjwqmcdNUFQW5 Sk71CcvjIxRRNKt/c1MIvVF77koEIEg= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-141-FyoKMx-XPI-HEcyT7J2yAQ-1; Mon, 19 Dec 2022 02:16:22 -0500 X-MC-Unique: FyoKMx-XPI-HEcyT7J2yAQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3B11A2A59557; Mon, 19 Dec 2022 07:16:22 +0000 (UTC) Received: from localhost (ovpn-12-41.pek2.redhat.com [10.72.12.41]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 017562026D4B; Mon, 19 Dec 2022 07:16:20 +0000 (UTC) Date: Mon, 19 Dec 2022 15:16:17 +0800 From: Baoquan He To: Lorenzo Stoakes Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, urezki@gmail.com, stephen.s.brennan@oracle.com, willy@infradead.org, akpm@linux-foundation.org, hch@infradead.org Subject: Re: [PATCH v2 5/7] mm/vmalloc: skip the uninitilized vmalloc areas Message-ID: References: <20221217015435.73889-1-bhe@redhat.com> <20221217015435.73889-6-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 337EF18000B X-Stat-Signature: wxk6azgua4pix1uqc8ci5pocmw635zxg X-HE-Tag: 1671434187-197385 X-HE-Meta: U2FsdGVkX1+i4aWalOAWgnWJnoe2OUgdG2kHMtLHW5vwLwz5z0A3YbYRRiANXQ6wRbcMsdqRE2e/dZzqv6TgWz8ATbEsQQqJ0RipOtiay5tvbDpjsV4oDLJRLMpMr09d3XjFEUBK+hER9VPOxWjJxPU4Z6wOEcuuL2TZ75cW9hkJxrIREZSrlsH4oNYSBw3Cd3jS5/ZN1KSXUN+hVmePmLH76O7tnWjQz21MYasgp78mTPeuDldii6IEP5DCz3UH8jPbzu6/xGXIaTOajkQ75baYjCepEP4lJWtWo30Zk1ol96spHY0ku7NE/viOii/WOEsFVzwt101oJubxo69sqL6AGHzPAa38eDH0K6tyS2oT2cyso0A3XUGuR3rnehxLsasYRqvs8IAmFjPs5G/gIQqT06Dx49BFoOrU8zGIxOYg57ksQrAr1dq3N76fPGAQOpNqkrEfDhh5xdJmDq7sMgpt4pttCA+8JS6/Fq2I4SReSurjahP2H2aHZuS3kOvehwz2l008kjqZNJTuY63BVR5Y3ZXXeyo0CfzDvw+3lxswRq1yjEoKu9cShb9YTTCf/ebTwm6Oj5s77UGAzH3DngI33kp5VVQ5Kct91Ei6EuamF3BW8ceNvKK+sxJiyVtpdzSYKEAijwdO3ilMNp4JVc3bQeun8BW5j9LlgUzi41zjnBXWc1tsh4DhfiFZA8QoIM/vYRdxkFNQm0Pb5mlNYKQrxAOgrY0lybiey8wjPPQdFWJEqmatAVxIl8JlwMDBLjW9usJqL28lz/9LJXFV//O4288uF7cvVrXmEoObxtWoGS1KXQpZdMLh82A/MYkuKJHObCdoWDesHwtSrpiuLVc6v/Zpg0GqN48OYWvWhMTqTR32apvHIDnHXdL7ea2uRB2quRpJjNrl1ufgNphDQF37YJHg1jYu X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 12/17/22 at 12:07pm, Lorenzo Stoakes wrote: > On Sat, Dec 17, 2022 at 09:54:33AM +0800, Baoquan He wrote: > > @@ -3617,6 +3617,11 @@ long vread(char *buf, char *addr, unsigned long count) > > if (!vm && !flags) > > continue; > > > > + if (vm->flags & VM_UNINITIALIZED) > > + continue; > > This comes immediately after asserting that vm _might be null_. This surely must become:- > > if (vm && vm->flags & VM_UNINITIALIZED) > continue; You are right, will fix it in v3. Thanks for careful reivewing.