From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48001C10F1B for ; Fri, 30 Dec 2022 11:53:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 810E68E0002; Fri, 30 Dec 2022 06:53:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7C0228E0001; Fri, 30 Dec 2022 06:53:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 687518E0002; Fri, 30 Dec 2022 06:53:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 56C3A8E0001 for ; Fri, 30 Dec 2022 06:53:43 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 219A6C08F3 for ; Fri, 30 Dec 2022 11:53:43 +0000 (UTC) X-FDA: 80298813126.06.0F8BBE6 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by imf04.hostedemail.com (Postfix) with ESMTP id 21D9F40002 for ; Fri, 30 Dec 2022 11:53:37 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=temperror ("DNS error when getting key") header.d=alien8.de header.s=dkim header.b="aZ/ZVHx2"; spf=pass (imf04.hostedemail.com: domain of bp@alien8.de designates 5.9.137.197 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672401221; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Laxh/C9ZxuZYfqJQTUOidfRa5K1UWorXoXDiSpqTcos=; b=3CCJXhcCuj8t5QMs3OdzFO6MFqp+TB25joB/V3T7IqXlGSAMhpjjEEHviI9BboB9H3x6A5 6ISQX5x5x/cdNC2lT2oHglr664y4TGoQ+pPfrOwTtZFTvbfc9livZ9rO6lrHI51IwjOAAB ZJsB48cHcWSY7I0N4Xk3tNZgGZiXcXg= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=temperror ("DNS error when getting key") header.d=alien8.de header.s=dkim header.b="aZ/ZVHx2"; spf=pass (imf04.hostedemail.com: domain of bp@alien8.de designates 5.9.137.197 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672401221; a=rsa-sha256; cv=none; b=g6qw+VkWuMS65jOA3Mm7X/k6TX8XZoAcUt3niPRNKqpGxo5OiHuSXjhcVA6A0QGHRoF2Em Pgk0wIDbMr2vgU9tCYqAO+JjnQXGPw0HwHZnmLbZLeruMaNfZH8REzZYuJwN6NCqKsAsB3 m4UVovi41ajNt5xATfqRWBPPJ/e+SpE= Received: from zn.tnic (p5de8e9fe.dip0.t-ipconnect.de [93.232.233.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 48FB11EC01CE; Fri, 30 Dec 2022 12:53:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1672401216; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=Laxh/C9ZxuZYfqJQTUOidfRa5K1UWorXoXDiSpqTcos=; b=aZ/ZVHx2XblvvfDYa6I5gkaw9K45VXC1wGgMmR4Rt+0TxEdwHLGzcLwR7kAhCQg8FBQooo 27XdQk6Z6g84QV53TMX4/pmTCe+yXe20CXRFBG55EiRKgfOlFegblcNhjA4dqU8ll15E7A bahtGtrJuBN+3vTzS5obIjnUDVeQgu0= Date: Fri, 30 Dec 2022 12:53:31 +0100 From: Borislav Petkov To: Michael Roth Cc: kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, wanpengli@tencent.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, dovmurik@linux.ibm.com, tobin@ibm.com, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, dgilbert@redhat.com, jarkko@kernel.org, ashish.kalra@amd.com, harald@profian.com Subject: Re: [PATCH RFC v7 06/64] KVM: x86: Add platform hooks for private memory invalidations Message-ID: References: <20221214194056.161492-1-michael.roth@amd.com> <20221214194056.161492-7-michael.roth@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20221214194056.161492-7-michael.roth@amd.com> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 21D9F40002 X-Stat-Signature: 76bqrsjx7zws4ni4aq55k4y1r35qkcx8 X-HE-Tag: 1672401217-985828 X-HE-Meta: U2FsdGVkX183+e6u7VG5C/6YN6+v0502Zkw/NmAogaivzd4Hgo/Hp1MJdP3KcZPy77XoAZM37RsSnC0lvLzL6l/+76QTlTG0ErUm+HchsEXrQSto1qQ/JOkXlxLiYCNxSLI0Y4tTKQ9iFFRYXRa+iPk8CBOjJgdMyQ+3f+FaRjzMWS6fkGcv2/IH2bZTwlQS1oJtuhkUZCQ3t+Iyv/Qf5p7bxDk85ZoGu/wKr38//Te+cM00azVr397UrxIjPdhF6du+43EsRLwwGK1BFTGGaF7Ez1EsCD5WvaOfs63tiaAEurMwSdUsWjM3wWHlwH87oz1v4lFqxfdVgVRNa58CDGUhAuTFgFNSS5NY5cOQNhR9LQL2kkP6uBHd2ySzM1i6FAc7UWLz5bwJXFUTQGziCdtsI/C641LUeqJQr+Ap85ODcskDlQcIyfddzbLxK9LRIX+v87uWGTRqhmpjidD/1KJYlPps4JBZw82E6oSpHk5eKaczu0J4oTfDs05fLqj2zPGThitCHLzz2Lope1QMLFg0SIAjbg0EePqCwTvUEqt4WLK3l0P257xLNuCRDUtiRNLTnuRYHGA+r+fmw+PM8riYgukjRTk5qcwMzTQytzFYyy/VXu6OK+Yj+YL77EAxvv5wVmG1CxpL5RxakiclqfgStiTFoFpk5l483dpzjjoqrWMC7BBd2P1FaSVqGxlvT824W91OHImY7oOjOkutsRkfJ/Mld2jHJJ7EJ1eZGGwX2dQTpjMY49yOdTBkXIJT/VK7pbT8R6dLwjYoFv5R1WYGYc+Pv2nnt7RSuGmD2hE2o7fGfVPX7u99iBrh7Qiz/PZi4K5aaGqgiJiGpSxsoch/O6lEFZYTzOlO0PLXWQ4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Dec 14, 2022 at 01:39:58PM -0600, Michael Roth wrote: > diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c > index a0c41d391547..2713632e5061 100644 > --- a/arch/x86/kvm/mmu/mmu.c > +++ b/arch/x86/kvm/mmu/mmu.c > @@ -7183,3 +7183,8 @@ void kvm_arch_set_memory_attributes(struct kvm *kvm, > kvm_update_lpage_private_shared_mixed(kvm, slot, attrs, > start, end); > } > + > +void kvm_arch_invalidate_restricted_mem(struct kvm_memory_slot *slot, gfn_t start, gfn_t end) > +{ > + static_call_cond(kvm_x86_invalidate_restricted_mem)(slot, start, end); Why _cond? > @@ -258,6 +263,17 @@ void restrictedmem_unregister_notifier(struct file *file, > struct restrictedmem_notifier *notifier) > { > struct restrictedmem_data *data = file->f_mapping->private_data; > + struct inode *inode = file_inode(data->memfd); > + > + /* TODO: this will issue notifications to all registered notifiers, First of all: verify_comment_style: WARNING: Multi-line comment needs to start text on the second line: [+ /* TODO: this will issue notifications to all registered notifiers,] Then, if you only want to run the callbacks for the one going away only, why don't you simply do: mutex_lock(&data->lock); notifier->ops->invalidate_start(notifier, 0, inode->i_size >> PAGE_SHIFT); notifier->ops->invalidate_end(notifier, 0, inode->i_size >> PAGE_SHIFT); list_del(¬ifier->list); mutex_unlock(&data->lock); here? -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette