From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AA17C4167B for ; Fri, 30 Dec 2022 08:14:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A636B8E0002; Fri, 30 Dec 2022 03:14:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A13618E0001; Fri, 30 Dec 2022 03:14:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8DB0B8E0002; Fri, 30 Dec 2022 03:14:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 7AD298E0001 for ; Fri, 30 Dec 2022 03:14:33 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 489F11C105B for ; Fri, 30 Dec 2022 08:14:33 +0000 (UTC) X-FDA: 80298260826.26.1A1DED0 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf05.hostedemail.com (Postfix) with ESMTP id F119F100004 for ; Fri, 30 Dec 2022 08:14:30 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=jETa2IMT; spf=none (imf05.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672388072; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wKcxZEuFQAuAVN1fDLHfDtQJh2W3Whfhs8zJpFzcCak=; b=Kct77bC9gKNbz5I3JMJlO3I4J5rEZs3odNDk9YoVT2pphR4sKw4KqXgUQBc8U1IBaT88pL my2+KHwW7mjy1ke/n+xM51md5mXc8xteP4R7shrqIa7x7hJoIYU5smNG3DIXl/2aG9uYZq KQyCkVMP5d1FowpARX0/YUcKin1zyDo= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=jETa2IMT; spf=none (imf05.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672388072; a=rsa-sha256; cv=none; b=qOC/x19qUUsPO7tXOnKyIQc7GYazZ8aO8AIkjhkP7rRmq1dU6CVZfoyPNPWvi8KBvXrZF/ zzfFtStHEZpQQ52hVnDKNax6tUFQ5L0vwnTRSc6lheLGGSytfNCppUgilCXPrpJJKEF8CG FL6/xIbqi95PPU3h4Ul3EqtgdvzwfI8= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=wKcxZEuFQAuAVN1fDLHfDtQJh2W3Whfhs8zJpFzcCak=; b=jETa2IMTXRHLMYIFcEgHxbxej1 6upl737hSk1SkbOJmq4z/v+XT8Wbzj8iwsdp/ZHZBBfsrybBSuL1PxSea7MiUd34vTJE2sMu6pnMD WBLbw7arNFYYgCEx9UwyfuD4nMyzvGy5Z36FXeMERSRcEWUMshZ+34CEdlsBcqn9Tj2Ngzr8cTWpH EOvEC/T28uIAmY2BbQBNaBWA8QuXxdTdQ6yVHceT2MxAi69QzRvdYvyMDahCrAtLjSEuRq+MtrN66 YsNN/yjI64IfQ6dUbMDg5RL8/uNkKrL/vhrxMdSc0ELwdXjGN/JRs4xGi3Zp8s1/lS/w2XvsB9p+N QwxJJrdQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pBAXB-00ARil-UI; Fri, 30 Dec 2022 08:14:33 +0000 Date: Fri, 30 Dec 2022 08:14:33 +0000 From: Matthew Wilcox To: Kefeng Wang Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: huge_memory: convert split_huge_pages_all() to use a folio Message-ID: References: <20221229122503.149083-1-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221229122503.149083-1-wangkefeng.wang@huawei.com> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: F119F100004 X-Stat-Signature: jgt1pzizks6ffb5cx83a14wo5wbduyai X-Rspam-User: X-HE-Tag: 1672388070-294077 X-HE-Meta: U2FsdGVkX18zNl/fzAFN16QPU3t3oJjauad5TimsAZXRXs+b4m+e9n5dXjxzSzt6ixokxithjjBMnDmqmKV5QlcNacRYVYnNgA/n64lTNksCG9G2dj8bvffN6aFZwzZv+Z2TvOoIHxi366YdTFymAHU76L6NHESt79a3enAnC9R+e2RUKK43pdotELh/B+4w54n5EMJrpuW7H9Q25HhBwT8HjMjU80IKBiVnL0Nng3PloTIgp5vpBBZAWtQeyfHg2LS5c5+Yy3hluQDTdmnwmSpP3xGXTP9OZ76HPegGMagOztU5OC2BXBNONgOykkxfm6Bmorj4Wt7UPfJaUkYZ0ZmR+Zte43qZMHzYkJhc5m5i9XX/vcx75TRDsAM9l23nwtFq2u/xTi3UtEZdfeKEQnaLiDOEuGL1XGVesDcsOnMpou4X3goJ8Fx4Ngg/AXpE+gYBFJ/QLH2jG6FWTvjTYBiXRowHgjJq8Xb1PDfQLcMoxKPd5Bbg2LmtfpF8pqzXCtj4/V46Q0Sp/LrUeXyDw0+dNMfbxyL87+U2/E1VovmGawjrAFVz5TmJtiiCZcLdge9Mgw1t37ClVusJgmGMwkDz8RJIM6REpt8hPvDsBrAHAOJ0lF0D5NJk9+0+OSFXmcYYltwdBbM0frnt97q1dhnU+NJCov8YFzlPRPW1I/RkyHMTGzqeZqGNDuVmjMBQQRh9i+JF5eq+46JbOk1FWWltzJ1G7jKrzw8LbaUcDswkiUmZXxYC5dOD28LfBQkOR6YBhNoRgkU9h+sD5HuQtuZTSI38mkRrUs7hDncdiRdjCVrC9Z+eWS9sIgSX7bNZF5t/osZb4TjG1zqfbfE6CJKhyK0hYlnCTsA23VP7TKli9zOwy5EhJxsTjJBJDHHZ9Fx8CBe/mh9qERZy5OS/Gg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000006, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Dec 29, 2022 at 08:25:03PM +0800, Kefeng Wang wrote: > - if (!PageHead(page) || PageHuge(page) || !PageLRU(page)) > + if (!folio_test_large(folio) > + || folio_test_hugetlb(folio) > + || !folio_test_lru(folio)) > goto next; That is a completely illegible way of indenting this code! There's no visual cue when the condition stops and when the next statement begins. Try one of these: if (!folio_test_large(folio) || folio_test_hugetlb(folio) || !folio_test_lru(folio)) goto next; if (!folio_test_large(folio) || folio_test_hugetlb(folio) || !folio_test_lru(folio)) goto next;