From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA067C4167B for ; Thu, 29 Dec 2022 17:09:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2FAB18E0002; Thu, 29 Dec 2022 12:09:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2AA3B8E0001; Thu, 29 Dec 2022 12:09:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 199678E0002; Thu, 29 Dec 2022 12:09:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 0AEF18E0001 for ; Thu, 29 Dec 2022 12:09:47 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id D8A091C0F49 for ; Thu, 29 Dec 2022 17:09:46 +0000 (UTC) X-FDA: 80295980772.14.BAB4673 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by imf08.hostedemail.com (Postfix) with ESMTP id D5CD9160014 for ; Thu, 29 Dec 2022 17:09:41 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=alien8.de header.s=dkim header.b=ZZ5a6aHw; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf08.hostedemail.com: domain of bp@alien8.de designates 5.9.137.197 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672333785; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+OOhnZUur7/65XYNN5FmieX2LDevIBg+5FobdbkM0V4=; b=1SQI/yU4Ti+uW7K5hZHQ8LBghtcMzmOajAGUzFpjaBNo6P5uq3tNOX3/eHKexaBxNTLoIw woQS4t+O6zBLh1wlrrssB/awywcAHXvXcyNDUgMHFRfU8gXbzLN7Qxhn5ZWnuJBj6cxOCx gSRe2L505Dh2oRRPU4327JMSP/UwLN0= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=alien8.de header.s=dkim header.b=ZZ5a6aHw; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf08.hostedemail.com: domain of bp@alien8.de designates 5.9.137.197 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672333785; a=rsa-sha256; cv=none; b=XExIyQpLRlAX40M/Rl3QB2ab1zqfHzU1kq0TRoEMTisEt3VNIH0jbHoUNPYBU8rIm1Add/ cAqwgaQxJUaF2hJ8IRDZS06vHKLrD/4EEyad1AQsiOZ4RjhDcI/b+llbjqlofdbmOh3Kk1 70dr92P18gB0dgNVNinQ1KMkDnHmJmI= Received: from zn.tnic (p5de8e9fe.dip0.t-ipconnect.de [93.232.233.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 36C1E1EC01CE; Thu, 29 Dec 2022 18:09:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1672333780; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=+OOhnZUur7/65XYNN5FmieX2LDevIBg+5FobdbkM0V4=; b=ZZ5a6aHw8mkatXdcTQjTIBD0qcmeQny18h0PJgtL3SDF/M34eLTxnFU2ln362VqwAnk9cW HmuFwJeKmNCRp8KTd2O86F+ZNQ7Zb2KrYhShQl84Tbw1xAmuPzmUh3VGZhvASwYz38MQrL lWkFhXIbJA9GKPkwwHAxZXMwVNKAGuE= Date: Thu, 29 Dec 2022 18:09:35 +0100 From: Borislav Petkov To: "Kalra, Ashish" Cc: Michael Roth , x86@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, dovmurik@linux.ibm.com, tobin@ibm.com, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, dgilbert@redhat.com, jarkko@kernel.org Subject: Re: [PATCH Part2 v6 07/49] x86/sev: Invalid pages from direct map when adding it to RMP table Message-ID: References: <243778c282cd55a554af9c11d2ecd3ff9ea6820f.1655761627.git.ashish.kalra@amd.com> <20221219150026.bltiyk72pmdc2ic3@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: D5CD9160014 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: 9kj39w7trhswrd9rnwt5pimdna336om7 X-HE-Tag: 1672333781-776376 X-HE-Meta: U2FsdGVkX1/YyCkNCJg4DSBOCXzZIZ/4RpxEsiAIJCBfJVAB43ZldkKS0/6FsJbLK51VkOGUjz/l8zbvzc8VvestwRril73aA3eYBRTMMcFdqirGeV8vUQIDpqaWHMVdRKknaJaEOQ7ilrvry2ZmpKkb3q43xVrvU5mtEQ2pSGxXRKajpPhpKcOrEB7UFn8NROjzjk401FyEkyGMV7spzLIndB8gnm3KEXhRDGgJlmxahNW9h2py/dbJ8EK38DXTJNKDDC5Xb2xTTFo6qIFoBMU5QrhS1QK3bTMX+6i6wNzyLQRfTAJvhF+t9gX8BCMk4GzZvhr134COMHzJnhFqYL+kJf34SmkG1n1CnLfoWayJRYdszT5sOsdSjXnsGTI+NsN6/c6KtMKMrdaQhlZyNuLFWvnH8cFkxhie2JJdfy3zit4ILYKeZUuRapFOM2CeBc4x2DUbXAvi3iW5RtoOlFVIyrfruIFTHIHIIPmFYZk30/5XMXvoNoBnoFS2bED64cLBUaVMEfb+jKYvKAFVpG2P6/ygY/oQGk1k15Dycyc7aqyGFvC7mMolhTWKCp9/W2Fr1zF5c0fxiSvOM6fq7OuE6YZzJaGHzf9lP+JuOf6T1FpK4wDFVcAJL5mevkDL8YcbAeeN/XWwk8L6iGfAS4na9FJ/cNu2uP+pLoqs0KgqoJqP9v6bqTC1QOWi2zKyJAYrltl7RGOZU5nbEfOMiSidXJbxd+TKuz28c0PgCCnoRQQWmSN35s96zmy5GdRff7Vg+0AKvzgpzMM2xvFwm4LzNKJd5qVMBGd/iyIrGOyTgHgJAdkHMjZBVGBehOWc3WMKDVkUISy4Qn4RvuGgshbjEYaMzzk8 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Dec 27, 2022 at 03:49:39PM -0600, Kalra, Ashish wrote: > Milan onward, And before ML there's no SNP, right? > there is H/W support for coherency between mappings of the > same physical page with different encryption keys, so AFAIK, there should be > no need to flush during page state transitions, where we invoke these direct > map interface functions for re-mapping/invalidating pages. Yah, that rings a bell. In any case, the fact that flushing is not needed should be stated somewhere in text so that it is clear why. > I don't know if there is any other reason to flush after modifying > the direct map ? There's /* * No need to flush, when we did not set any of the caching * attributes: */ cache = !!pgprot2cachemode(mask_set); Does the above HW cover this case too? Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette