From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13DB2C4332F for ; Thu, 29 Dec 2022 17:03:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4FB568E0002; Thu, 29 Dec 2022 12:03:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4AAD28E0001; Thu, 29 Dec 2022 12:03:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 39B488E0002; Thu, 29 Dec 2022 12:03:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 29E728E0001 for ; Thu, 29 Dec 2022 12:03:26 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D9B4EC0A31 for ; Thu, 29 Dec 2022 17:03:25 +0000 (UTC) X-FDA: 80295964770.10.989F1C9 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf10.hostedemail.com (Postfix) with ESMTP id A29C2C000A for ; Thu, 29 Dec 2022 17:03:22 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="VTl9/194"; dmarc=none; spf=none (imf10.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672333403; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FpO/eHt+84zbk9M68yu6DzZDNP2UCbAiX18klEN4/yA=; b=X8jSpxRpdKzlGm+4U9yo2C4DDJ53ID2ig2Ud1ETRj5DlKPAf39XNYZlMFkax/JPn0VBwSK 3weJs+P5Xwl7DdCanA5ImH57uohdrSUw4SdYNbtSIwgLGHq0dQpR11X/k9k8FdRGdKaqGC R4c55xvySZWIMfu7tQVkhYXKF/CqMEU= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="VTl9/194"; dmarc=none; spf=none (imf10.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672333403; a=rsa-sha256; cv=none; b=NUUU5/O/phsjfJGuYYITtwivcsZlooTyOdNs/ldW97S3LmzhrdiXx6HrmHHEI1siusmuEA 0lIaPuKXm015p30kL79UKqowRO8FSBmdMDb3T/dzSCLf7Tw1LyjZhQY/wY3CPhl0OrH3KT b6gJiRxRxGKoPN4nrtgZumoWZSvWHx4= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=FpO/eHt+84zbk9M68yu6DzZDNP2UCbAiX18klEN4/yA=; b=VTl9/194oI/R+TtJ/HBvlyV61k HXcMgF2toNI6pBRb/3FHLQ7fLcPI0De+9GfAn2n5NX6yL2Typvq+RiYIcsDx1KIKxdNXB73jKNStO y1hvemZd5yjmRV5iKBeY3t0A3bHEc9QUbAbvksyewg4PTT+MD3jWxtB9SyQkDPFAodEySLBeJ+kOi q14YcbDb7g1Pyv4wdK/VoGJsKmkJVN4vD/3GnbVg2kWT8j5qAqZu+OrmgkMwzNxi0D2vd7dII/VsH FSR5Y94CqlYw8/uRlVgYZY5rbq+p6wBi3UwYIXOx6hiLT80jAE+FT8noE9bjw6Q1DL/ANFIki+p1J GZGVUxeg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pAwJN-00A0P1-1z; Thu, 29 Dec 2022 17:03:21 +0000 Date: Thu, 29 Dec 2022 17:03:21 +0000 From: Matthew Wilcox To: yang.yang29@zte.com.cn Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, iamjoonsoo.kim@lge.com Subject: Re: [PATCH linux-next] swap_state: update shadow_nodes for anonymous page Message-ID: References: <202212292130035747813@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202212292130035747813@zte.com.cn> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: A29C2C000A X-Stat-Signature: 13pjr9b7y8ijr8uhcdz545w1o1nucibs X-HE-Tag: 1672333402-255367 X-HE-Meta: U2FsdGVkX1/47w8ohh0KOPYkN1CMoExymI/8up5fTZpfYYkzaDWBR7B+plVp6uzoZHIIIejOjfVrCXDEr8FfT/3PGFEDrK5jpebtYmXIlOld3GT3lIok3NDZIFZc/RTvws7bYmeK9lwRSYI5JYhTD8j4WcuQknkDuu0MSay9S5HCPwtVeniD7ouuLKiAnNZ+6KVhl9b0gNPfG1B5bVgKrTxIeSE0lKs0I7U63WjMrSyYSXM9u3WG2K6kYgZSbpAOZ7Oe+j1EBocT4Ach/6nI7D3b4UeySNt3xSNeCrvH+7UKOguWQH+K0A0Y4xzF1EzlDLo+hCEOsNGRZ3YZjaDd7u/2OsaYorQ3aj4aZTOM7YB7hq+HiPTVNySDv+MYu2Qv+hgotl7XvuAs5Q+a1YE6jq3WTov9wC9ViPTuN5hWgvqLy+mN/4b4h59I2WezkfnSqQiLj2p526bNVpDOjeMQbtoQA6eTbiKP9GBI/ve+sWvnZLYKjUVzpLhImlmPKJPEGYVBqEKgVxbnLngdulFw5GSaUUFcghSMGawJUkWAKIlPFFDfhLqLTE/BYATToPy90BBwuBEqvZ0x2BCtVEczy4MhBBAHAT0pTbyh8+N0RIDWDEjaEl5Q7TrMfakw/U3q64uwsdNrLD1iQ6ZmCzyrFZTJ3ujJJfOliwMC4BYaJ0vP5/lMaYWg4SjffPSVZoUHSDj1rmQVGQ+zrElhqHZmYFb8JdOLkOlmRJN8hjnHEEhYFZ1n8mSHFzpYCwhrJyKn8SnRzcsOhV/OHhFUxuCqN+ZYSR1J1Gv+D8UJG3yAOWwI5xtIha7XIjhC6IZV+Uyq2qv/LQYH2Vp45lOFnLpDGJIH4gDRl65Fno3jpfgEgiMNDySJRpmliKW589RURwDD30qgE7+PQrQsydN4UAeJIg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Dec 29, 2022 at 09:30:03PM +0800, yang.yang29@zte.com.cn wrote: > From: Yang Yang > > Shadow_nodes is for shadow nodes reclaiming of workingset handling, > it is updated when page cache add or delete since long time ago > workingset only supported page cache. But when workingset supports > anonymous page detection[1], we missied updating shadow nodes for > it. Please include a description of the user-visible effect of this (I think I can guess, but I'd like it spelled out) > [1] commit aae466b0052e ("mm/swap: implement workingset detection for anonymous LRU") > > Signed-off-by: Yang Yang No Fixes: line? It doesn't need to be backported? > --- > include/linux/xarray.h | 3 ++- > mm/swap_state.c | 4 ++++ > 2 files changed, 6 insertions(+), 1 deletion(-) > > diff --git a/include/linux/xarray.h b/include/linux/xarray.h > index 44dd6d6e01bc..cd2ccb09c596 100644 > --- a/include/linux/xarray.h > +++ b/include/linux/xarray.h > @@ -1643,7 +1643,8 @@ static inline void xas_set_order(struct xa_state *xas, unsigned long index, > * @update: Function to call when updating a node. > * > * The XArray can notify a caller after it has updated an xa_node. > - * This is advanced functionality and is only needed by the page cache. > + * This is advanced functionality and is only needed by the page cache > + * and anonymous page. ... "and swap cache.", not anonymous page.