From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2E0FC4332F for ; Thu, 29 Dec 2022 13:41:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5A6718E0002; Thu, 29 Dec 2022 08:41:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 556B28E0001; Thu, 29 Dec 2022 08:41:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 41E368E0002; Thu, 29 Dec 2022 08:41:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 3211C8E0001 for ; Thu, 29 Dec 2022 08:41:47 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id EC4C51C6048 for ; Thu, 29 Dec 2022 13:41:46 +0000 (UTC) X-FDA: 80295456612.13.29E5678 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by imf15.hostedemail.com (Postfix) with ESMTP id 4EF8AA000A for ; Thu, 29 Dec 2022 13:41:45 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="WFu/SR8Z"; spf=pass (imf15.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.214.178 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672321305; a=rsa-sha256; cv=none; b=LBv+WQmHam08A5WRkMPozUEWqBnvdD3TL67dvyKLwxK2r8EIlkRuRxG/hmoBreJaSEITEJ fGrAZVHW+OhH4yN4myu2+efdYIFWiuExj95FG+2WxEg+DjZlq3bA9tQYbG7NASnmhuMDPQ rAf7m7hiV9nd8obEe9pz0pIGQk06thQ= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="WFu/SR8Z"; spf=pass (imf15.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.214.178 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672321305; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=v5HPkp/bFHtlvqu2/9jRhTUPSjVDvmYX0Z0JICpgPF4=; b=Jv2Sn1AE4RxyPi7M0d6KIB60wdC6SX8E91tLpndENoAnmKEKBRb+aIvuO/En2G+TOCLPdA kVDKrzdF2G3Ddfohq1wGhuCRr61iyIFxxdlujX1AQr3XfC4xJwFL8Yh5gCeqhOXCf2YLJl q9jEdGtQBjF7R5gfVpUaqDCJpuH1AoE= Received: by mail-pl1-f178.google.com with SMTP id 20so5523046plo.3 for ; Thu, 29 Dec 2022 05:41:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=v5HPkp/bFHtlvqu2/9jRhTUPSjVDvmYX0Z0JICpgPF4=; b=WFu/SR8ZQg4bvs/mrWjdnOB/Wz2Hq7FEggZ6qtDdUaH3RW37YntXntNMzjPxuJEZz1 bWXfmgfwr2pjRdqhtqhlh2rnan7W+xaAEybVXbumaqFNwc3FBXNSQc3pItIDGuoFQ6CP hFGnj5tnxjKsjyDi9+yxuaIPAG4dPpGYLJeT1IZZXDNvUpNXoK5Ni/IcVULmfe0QzYFL H/Rfzj/pI6Um4SsLjrCTtvovY8n5F3snqxXV5pR6wXTZamfBZ6gQ52XgmFh7gTibj2wX xQW4og84vn1ayRFb5A+Us/AMEbEI+6Ut2XhwHEt2A4zQV4o7WVQTlj4RGX05i5jcUPRB FtOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=v5HPkp/bFHtlvqu2/9jRhTUPSjVDvmYX0Z0JICpgPF4=; b=a0jnn+oFh4NIlP3bufU9uS5StTHX0Cr71WEHC+SHllMy/QqUC+afC6QSHM4k0V/x3Y K/0Luz2dE4UXmHoFGp531e1c4o9iFVTydYUvOnGcDiy4vT1nr0egUl4uQYF94oWxbpDU oB3SodkExT/45oQI6n2NenQQZSUOKR/urcxeN9FsDxwbdoy1ZYBCsGZv+w/wJvunKlFG 7fdGZH8ibZfqeD9h0E0Kvw+auqxQOoGCnF3T3kUGJ/5KHOSABgFnI1W1Q8VKTx0QwjlH r12tvPYG5K6hpu/867G2Yobp6Yi2HVg8UPEHKhW4sqS7iv0l4x1iRDTEhtqZrhyv3i61 kxNQ== X-Gm-Message-State: AFqh2kqFHLWn8e2ytdWMMpqKhmPqHaEtFPYlS1hPZZadwv0T5xUQtiJG cWpRij6Lgsc0drUhC39Xxqw= X-Google-Smtp-Source: AMrXdXt/NRkAl9nuAw4qYUXU/X7DpyDKQIWmG9aLNEm2LrPvqt3ErvGsqUoxY7op3IzjLMckXTZJwA== X-Received: by 2002:a17:902:f68a:b0:192:49f4:fe67 with SMTP id l10-20020a170902f68a00b0019249f4fe67mr40899472plg.57.1672321304209; Thu, 29 Dec 2022 05:41:44 -0800 (PST) Received: from hyeyoo ([114.29.91.56]) by smtp.gmail.com with ESMTPSA id e9-20020a170902784900b001895b2c4cf6sm12830895pln.297.2022.12.29.05.41.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Dec 2022 05:41:43 -0800 (PST) Date: Thu, 29 Dec 2022 22:41:38 +0900 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: David Rientjes Cc: Andrew Morton , Christoph Lameter , Pekka Enberg , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [patch] mm, slab: periodically resched in drain_freelist() Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: 4EF8AA000A X-Rspamd-Server: rspam01 X-Stat-Signature: bwkxakkurws6yj7oxdpedkf6bjpfqpww X-HE-Tag: 1672321305-43572 X-HE-Meta: U2FsdGVkX1/7nvt99d6SiFpxQ9sHQr9GugNla3O9Y5YPMZHdjhq1YUKMT2J6Ifq+gIdrFHYE45wsr9L6c4/AS89ltK7AoNCuUXNZvlBPPpZvu5lorYcfjOUJZxFkyMFVkeJ22YW6EVCHSeGi531IMmUzXW4MQxFVwx6DiYRVhaFhG4dsSv1Y/qXa1ONmSc1+95NqWTEhE8FOrIqbuNIVycA9Jnx/TnENHiDSAJ8rWc44J5SKQPlAcPZ+dOcUIrA1oOpnRf+i/kEDP8yOAoHy8y5J9f6NjZs12bb3jFw7k8BhIQjqa/LEj5h/79VyVs1tSbKN/XJd8Yg9jNwJhTaT3SfEo329GaUuMiByjTHGAkv0m+T33L3Pfwp0YTu3awpHLkW5gc8CHBiPt8mf7TlHy87XxEOdUa5T4IxSm9sZXivWfUkg28u8m7vKRuyJCcy7XwqfrGUmUtFiRzsx8ekYMYu5ryBhjvkVKVSAIEX7XikJJp9SIy8KeKAO5UUPsJ+tuSciD1nYpvN5jV7N5MG+yRGXZI4efikBLYY93hMDcvw4MVS5gMBpBDNsBNOKqzRHPgKzntAm2PEbhWkPEyNI7TZ4TvcM+i5VcVrOEBQE4JkSFuE/Hf8QWr0KlE4m7UWynFbEHUGe7MOcCi0FDKurpgKnxq6mkltgkfahCCvuNbILllLTMJp4LicPwCmZ2z4O6VXG/voVRJo0DynOiS0xtSPuWwIki/ZqwSgZHvbknQymgANEIZRQlD8Mh9u0/yTsxJuoM9691Lmf0FggcWVPHl+VH7Bgo5AspK14Ups5nbdD73ZfotpkB5trDbDA8zEq09/T0wDiejol8iEsi2KN5p/5nRU7+TeLfp/gPl05RpI+WGN3RnDiqfpVIVLWTqv4sIkXo9JiG4kPpTaa37tVd8THm3U9eyAb/mnNuR/PMaU3rPi7DeKh4i1jTA09fvQGBNmfT8t/fZYMfNSzpRG 6XvbHGmE asTzpDx5GzF4B3od/DXpSy65b4OMkp23gaqvjAgNOQfMZHKAAClkMsb5FZJ/CvgR3E9e/+02S+AI2hksJmkjGD6suSKdO6J7vKEp2IQVUeZN3egDDxaAHce4wJ4ft3rcP4nrJDxbhsTYT2BbSqe7WVheeZGeVeJ/nTm8mMnloBsEfeb0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Dec 27, 2022 at 10:05:48PM -0800, David Rientjes wrote: > drain_freelist() can be called with a very large number of slabs to free, > such as for kmem_cache_shrink(), or depending on various settings of the > slab cache when doing periodic reaping. > > If there is a potentially long list of slabs to drain, periodically > schedule to ensure we aren't saturating the cpu for too long. > > Signed-off-by: David Rientjes > --- > mm/slab.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/mm/slab.c b/mm/slab.c > --- a/mm/slab.c > +++ b/mm/slab.c > @@ -2211,6 +2211,8 @@ static int drain_freelist(struct kmem_cache *cache, > raw_spin_unlock_irq(&n->list_lock); > slab_destroy(cache, slab); > nr_freed++; > + > + cond_resched(); > } > out: > return nr_freed; Looks good to me, Reviewed-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> -- Thanks, Hyeonggon