From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 209D5C4332F for ; Thu, 29 Dec 2022 13:35:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9A5F38E0002; Thu, 29 Dec 2022 08:35:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 956008E0001; Thu, 29 Dec 2022 08:35:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7F62D8E0002; Thu, 29 Dec 2022 08:35:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 6F8E88E0001 for ; Thu, 29 Dec 2022 08:35:47 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 346CEA0817 for ; Thu, 29 Dec 2022 13:35:47 +0000 (UTC) X-FDA: 80295441534.11.7570C59 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by imf21.hostedemail.com (Postfix) with ESMTP id 80FB21C000A for ; Thu, 29 Dec 2022 13:35:45 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=DZ4mL9PW; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf21.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.214.176 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672320945; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yLcd8CiyLYIlvCRq1660gY/l+h/v8zU2lfmkPPHTSdQ=; b=yO5qL5bBRte34pGAOmGBMkLtUVOC5XS7jKquiZFwovqY7ePEw+JueU/BIG+e7FAwBoadJZ 0LLoe21MedA3omoBY/0yJ39DfgSqd9gxhW5ZxDbDoUdR48KeiYodCXRhg5/D2s/aAEWsdh dlPp7KwDPDjcV/z8qq1oFRLe68Xpwc4= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=DZ4mL9PW; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf21.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.214.176 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672320945; a=rsa-sha256; cv=none; b=Rz4vvGCLsnVu96p/hMhaurqpmGoT1htHmHzRM3x2nTx78CHW6fTe7M8O5jJFKuqJq0E29E 0aalPnksYWAdyt1K6vHiAOQA6vK77o6gd3pl+dinhSQluanClvHieefW7B+0XqyCKsH8WW p/rjHcRqN4BiplDTrOiHrG3MsflGDJU= Received: by mail-pl1-f176.google.com with SMTP id jn22so18909432plb.13 for ; Thu, 29 Dec 2022 05:35:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=yLcd8CiyLYIlvCRq1660gY/l+h/v8zU2lfmkPPHTSdQ=; b=DZ4mL9PWqEgn4n3LYbFe8pA/69bpQ95H0RcO+2+3yq4x0SDTKvnduhg67Plac3jB1l 4xNZgV135z+HodeqouoXU1um1hMg6Ht4VF3h9BF3M+VGRViTTRDTgCdp7AN8Yy+QL9vN Ct5Eq0YBS2OjbzgkhOheLEOwEIhcN45ExNXkHQD9ALc9mPkJ+n2RnTbjA3XTN2qIml+X x7b/enqqiIUwB4qETNRqPfgoBJHWsRxplVg9hU/Od5tRUMZmBw//kaAkhsFcb2VZJaZ+ G1hdb0CoNsyXKhBxHYzuMnf3q5dqseWxv1LRGFD17x09d90h+AMuNvEUtxRN2K6nskg2 4nUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=yLcd8CiyLYIlvCRq1660gY/l+h/v8zU2lfmkPPHTSdQ=; b=ekpscgZtz9LrIDKMW5764X4O6SEu+HTiP4PxxCmq2SoI+6q2E8aUnT3LEAN02iB9tq SUrSyaUO5BEP3zOmFZbwbkOkk/E9/gBoKGNCN4Vw9rR6rSz8O4eoBSDRIMGy0ujLYEqg QlsbJtuiLI2mFnB+EmG+SSFtlwk87syFkMeKQ9Ht5+FbNGNHb+xxH6dBnjqzA6E4QwEq uXNl9oyXg05jbcRJ9N1ifWHrMsA5d4PfnVnKGHyle4TSxLY/gtyMAALHYSSMTPUDCHUD PEt8XsixHP1WV7aInZGzLXWCXKTtC7/xdHU+qvi4kK9EHKiO2r1iAnOkGIBwusZm/El6 nQNA== X-Gm-Message-State: AFqh2kotoAGPdbDqpt1p88yopSql0Gds/8tSYdw/h/t9qbcOZCMZZKsz /zEnrOinC8u12cJBYsxBhFs= X-Google-Smtp-Source: AMrXdXuaF2hKa0CKPGYmhiCk8cIr5uNdjSWMYoXwWFt8y4Cco8mStUDpXzudgxQ/f9QRGK5XpnVy2w== X-Received: by 2002:a17:902:ebc9:b0:189:a6be:85db with SMTP id p9-20020a170902ebc900b00189a6be85dbmr33011377plg.39.1672320944404; Thu, 29 Dec 2022 05:35:44 -0800 (PST) Received: from hyeyoo ([114.29.91.56]) by smtp.gmail.com with ESMTPSA id t8-20020a170902e84800b0017849a2b56asm13002488plg.46.2022.12.29.05.35.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Dec 2022 05:35:43 -0800 (PST) Date: Thu, 29 Dec 2022 22:35:37 +0900 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Andy Shevchenko Cc: Randy Dunlap , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , HORIGUCHI =?utf-8?B?TkFPWUEo5aCA5Y+jIOebtOS5nyk=?= , Joe Perches , Petr Mladek , Matthew WilCox , David Hildenbrand , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC v3 3/4] mm, printk: introduce new format %pGt for page_type Message-ID: References: <20221218101901.373450-1-42.hyeyoo@gmail.com> <20221218101901.373450-4-42.hyeyoo@gmail.com> <82feabee-0446-b913-adbb-0e96ecb10c94@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 80FB21C000A X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: yibr4axtgdqyow9uxdun534u45abn47a X-HE-Tag: 1672320945-698075 X-HE-Meta: U2FsdGVkX18bcEWg2XTfKt3sh2hp2LMuApucVMZtV5OQ4gQOPsoIamXq2pUku6VKs3SZZ/Oo0on//Er2gT8esgzbpKgWFqmvYIeI8kbb0mRvFJdDKqta86nd+QPxonpN/Yq4VxPUNCnhOV2p367G8QVwJwm/jaKqsNxBsCGOR4qZ3HIWPUMNsYMilDX2kfOOX0MjPSTGP/WZjUTfS0qtiV/FLRg28+QWKU3bNXy0SnY+b9SmdZcVVhpl7esKXU5YuXYiIU50VVPnTopdofQ18YpZkZjG3fwPuE80J2/NC+kvA43E3kKo+B76pLdKPjBG87j7Hmt304BNz/t3PGvSL6xbLUQVSWu9riC0s9882Q0OHWuoRnnGIUUnuMEttYcfhelYkgXl6PF6qLMhBqkV4pDWXCeQLqAttIXsNSjmeOaZr+643E0DzL2tF7+12YalI3ECqlrrp2RDLdMdNiP+frj+mxFbgENQfDc3wmsF5IWZFZPAmc8Atg6k1Z7qiF9mIB8Pze8Mz8QRGkO4SANb9ULtANvkPmv+yVhW2WwsPfOOl9ulX5VYW17x0rWdAMf26VSD048uo1DjS32wVGimuq6QBtMXs0zhdGSh8muIKZ4MuJJ8hdOdmeldUX2ImG/bwh73zpXHxK1fVTIDziwRmOeMkJUOZRgym7JqS6GDKch8UmHJDG75DEay8IRksDj3iaKMEQdj9W4/osuMOJqrGJP2bP7SNoPep5K+a1zXhQ4pStx+2624RFfRROnfaFRCP4EGDnjcrQrjdD6fPPjE7EyRHETF6adF9S9urs8ojwiDPv5SSEbg66fsOOczed6OsG6GjVZK7YZv/oCMHdb8/lR046rEjSQZ6+gAyjMh0rBxNIVDF9NCUg4oUxzsphHnXXXp+o3oQl+CvvDJPDer+aTQABw1fLos9uLD3aeZ6lO5wUzH7+yQW+jpQcU7wE/OIs2d+KO+Ps6isxS1lRq PkbfbA9W anqxgPmDltLfKPaPasb9ujbmTQEc8wywUVKo/tmqr5bw2r9eXo9zB8UcKU5EaEtK0eLVvYYojOgbTV19agkxeHzRgjODpb9bd1JUljYiI14XmAPVR/0gktEIthbzF03rPOk2aLZZME7/ueyfM6iaMwgngFd6wLvlzHEtWYw0EAGRECMA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Dec 20, 2022 at 12:58:53PM +0200, Andy Shevchenko wrote: > On Mon, Dec 19, 2022 at 11:35:38AM -0800, Randy Dunlap wrote: > > On 12/19/22 01:44, Andy Shevchenko wrote: > > > On Sun, Dec 18, 2022 at 07:19:00PM +0900, Hyeonggon Yoo wrote: > > ... > > > > #define DEF_PAGETYPE_NAME(_name) { PG_##_name, __stringify(_name) } > > > ... > > > #undef DEF_PAGETYPE_MASK > > > > > > In this case it decreases the chances of typo in the strings and flags. > > > > I'd say Yes. (and #undef DEF_PAGETYPE_NAME methinks; or change both to _MASK) > > Ah, it's me who used two different names for the same macro :-) It seems like a good way to make fewer mistakes. Will do in next version, thanks! :-) -- Thanks, Hyeonggon