From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F11EC4332F for ; Thu, 29 Dec 2022 13:17:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F0A718E0002; Thu, 29 Dec 2022 08:17:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EB9D58E0001; Thu, 29 Dec 2022 08:17:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D82428E0002; Thu, 29 Dec 2022 08:17:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id C87508E0001 for ; Thu, 29 Dec 2022 08:17:34 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 836EE160C9B for ; Thu, 29 Dec 2022 13:17:34 +0000 (UTC) X-FDA: 80295395628.10.E42F21B Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) by imf09.hostedemail.com (Postfix) with ESMTP id D5E1D14000D for ; Thu, 29 Dec 2022 13:17:31 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=WSaNH1wY; spf=pass (imf09.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.216.53 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672319851; a=rsa-sha256; cv=none; b=I1t7c2bWqU5Wi3Wa3/HsYAWEaAY8LuUqbr90e9p/OODVjWpnQyqdTfO3JYVbUvaJm7wlyj RLkU4Rcq8nB4dvKqZtE2ShIWYkj00zZ3huYWiI6JCiKAx1+dCcQnUPPA5saQGDo7EZHIHZ nMzjBsNY88b/dIAexNZD2RBq/05LQD0= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=WSaNH1wY; spf=pass (imf09.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.216.53 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672319851; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XB/5UP/6Hlg6zTc+Ud2YT+DViPlugAJ2lyEfvvnjKZo=; b=Bw/Wjf2uySzOzfGs+2Ce4Am/mOleN6ETWfofUnmTAArvX2GeKsQNiQNz71bVgWlGl6NoXj SksWDZxhtHdk7Tal3w+V7qCUV5AKTaPMJZVjiA3k2rZNzATmGU2JdiVvXUs811xMfe2mVd oRzge3nTABJAViM4hPgBydlr+4Iesgs= Received: by mail-pj1-f53.google.com with SMTP id ge16so15503669pjb.5 for ; Thu, 29 Dec 2022 05:17:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=XB/5UP/6Hlg6zTc+Ud2YT+DViPlugAJ2lyEfvvnjKZo=; b=WSaNH1wYnCQ2F4DfK3LHH0f36myjyXNNCEIsNZkta/yfavxOHNCpUlSzOrQwL/vrLV X/5TG/lQ4yV2U/NZDmutVlMglPI8WZDfS4Gi1mZ/M9LK6hv0RbU4+626/qrrOChAdT9N VTL6GoSUVR31hVmRJKTNkusi5IjqZWAMWiwQSD0alNUCNgjboCsFVkjx6BT2yJnG2s9R 39j2EoSFIdbU51W7KWOABz5jar/dogLdycBNuuynrzpdxyPsxIz6BXGOMrg7bdAvXDyy h3o2tvth78JuiWpzmmXGvBVoi2Yteq3/8rKMG9sOJyJf6jOKB7wHnFBGIMsOYaQNiXAd qaCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XB/5UP/6Hlg6zTc+Ud2YT+DViPlugAJ2lyEfvvnjKZo=; b=Mpq6Z/K1laSM7ovHhSh89FF1m+SDgDZPKCjT8E+RcJ+uDcFWlgDaQGntx5kxyW1Lne wlEzzXZK1syOcxzgMKAG7cRjtNS7QBA39en2A7Mur+QNt8esTIiHCs5Lm72IwgLx0evm jkKppIHmrZYGdUGyCBAGWja6MnTvMJyVCF2I8VAekhaBJHgtsDQslZ4yTRKRHM0oGbpx Wj7yIsDz1JhNlV6y/z3v5+wuscioRlIClL2ZeBla8l6rCMXQ/ENwIKSaivZNylA9W1xz rDmFVFvKOTuBY5HMA422QJeVxnGIXlbpsz15WRs71/DkjcgqDgQy1FvXOwYvjgVYnL2B +DUA== X-Gm-Message-State: AFqh2kpxcN9IUiKHHt+SYusNji8OJWSxzT/guivFN7riFr+hPb6xwo8H Tt8kAbsNakVChai4tEEBkDU= X-Google-Smtp-Source: AMrXdXtIST9doYDjZbreinPfq6LLl8u+EjrKg8kUSPl4LiBW+zcgu1u3TK6StxalYI7xvOmgrq9nUw== X-Received: by 2002:a17:902:7601:b0:192:8e8b:bcf with SMTP id k1-20020a170902760100b001928e8b0bcfmr8590295pll.56.1672319850632; Thu, 29 Dec 2022 05:17:30 -0800 (PST) Received: from hyeyoo ([114.29.91.56]) by smtp.gmail.com with ESMTPSA id n6-20020a170902d2c600b0018962933a3esm12945038plc.181.2022.12.29.05.17.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Dec 2022 05:17:29 -0800 (PST) Date: Thu, 29 Dec 2022 22:17:23 +0900 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: HORIGUCHI =?utf-8?B?TkFPWUEo5aCA5Y+j44CA55u05LmfKQ==?= Cc: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Joe Perches , Petr Mladek , Andy Shevchenko , Matthew WilCox , David Hildenbrand , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" Subject: Re: [RFC v3 1/4] mm/hwpoison: remove MF_MSG_SLAB from action_page_types Message-ID: References: <20221218101901.373450-1-42.hyeyoo@gmail.com> <20221218101901.373450-2-42.hyeyoo@gmail.com> <20221220235246.GA2334024@hori.linux.bs1.fc.nec.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221220235246.GA2334024@hori.linux.bs1.fc.nec.co.jp> X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: D5E1D14000D X-Stat-Signature: f35socyq8xwe8psw1iqx9yxwini3ngho X-HE-Tag: 1672319851-242915 X-HE-Meta: U2FsdGVkX1+aGAVjdESw/8kxUA1+OkBxjZV+CKJr1a6Dtsu+oQSE2kCWwRj5wVkqlKFZxxyUjE/r/VS8y56Dy9P6AGqCh9lm3nPpC0+9OtYGQ90XP0saWjF+1LmSOGuxykRI4R18af30uz+wJWsJtVf2jKblJjvjj4/R49nBHXEJNVkYxO5kqJFy7r8bxTzz5Ux+GQwAVzSQ/WNkBf35fCET/3bAQg/xp8BOGjbIwd+j5ejT9nuPtbzMbg8M8gRIhjX6oNIIuiCynHCLYSArwoAQcBFt6Oxp2EYsv2VxM2lMUMhqJ0hZli4oMsd3HAhA70fSym3q/9wjfMVVzwYxbcWk8T5S81QnjVih43gRqZrORjVhVFbHRClCMGDKl8PyfItX9zWyLHTqVC/u8+mi9Gafhhx44rRpek+6k652foKVTN43MAGjDw0cBFip7Px0wIcRDyOdBWQTrk5Ofo2x7lw3VBcg8h+0EUHuLcT02A8TfvE9Jt3CmJHR/ARqa0BT2pqcW1vNlxT/fu49s9v1yN87jt44Gw0mojj4RFbJtTSs3uiQz65PtU7u3Gz7Djisn8pRWMNwhi79xniJo2EL8ajVImsPcA7KbUhL7LoZTUNzERmV9NeSV6hIF1wWtriTzUoD5AM1bhxJZU5nVbo/B8Ll7Dc/kk4O2LjjUGeYFm/Vxb/9ghNEhXBPcXZQroEESxnLEpBNX5+308GZoUI46CF889qbwekq676cfPCoTZxpHSQ3yzL05MWsgUnWdY9ekTKznYPQclhiYchyb6hi7Qb+Z7YaS57WzbgdDz0DlllVw1nmBrW2f4WoCMKmbdBqW8r1VJAtp7+DK6rXuwq641JWhfsjy5PIpQE82vinqsnqCXzZ0daYA7Gxu5Jo4y2yinMvPwZ8UbV2G/IpLhpiFIk+XP4VYkflovsJtQ1mVEveFI27pEGfmWw0n1dB7QwyABrUnEdxk46DO/NY7pM 7woA33A9 4bLs9AdrioEPKmVmAatXo6e6xsA6LacgCi+avOdxxiQbFynPYmaiHdeF+gxrGmehAOquPcE4QelNnvFZfF1+nu/NeIWL5u3IDnbPMl9y/2f2ICUle4f2PaXv5PyCndiP0XXSIxztZlJkIBn65kI0vjz5WVFNdvfvRXaFnzGXXfOSyQT7ck2nsiSVqu5RsRl6/EL0+0r7IIFma4WlKab5IzPx+yA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Dec 20, 2022 at 11:53:11PM +0000, HORIGUCHI NAOYA(堀口 直也) wrote: > On Sun, Dec 18, 2022 at 07:18:58PM +0900, Hyeonggon Yoo wrote: > > As suggested by Naoya [1], identify_page_state() is never > > called when handling memory error on a slab page. > > > > Clean this up before moving PG_slab flag to page_type in later patch. > > > > [1] https://lore.kernel.org/linux-mm/Y2s+dnBsHAJu19ob@hyeyoo/#r > > > > Suggested-by: Naoya Horiguchi > > Signed-off-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> > > Thank you for the patch, > I think there're a few other places to remove under include/. > > $ grep -inr MF_MSG_SLA include > include/ras/ras_event.h:359: EM ( MF_MSG_SLAB, "kernel slab page" ) \ > include/linux/mm.h:3502: MF_MSG_SLAB, > > , so could you update them together? Oh, missed this. Will do in next version. -- Thanks, Hyeonggon