From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C01CC3DA7D for ; Thu, 29 Dec 2022 12:47:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EF6D78E0002; Thu, 29 Dec 2022 07:47:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EA4E28E0001; Thu, 29 Dec 2022 07:47:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D6CA08E0002; Thu, 29 Dec 2022 07:47:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C40D28E0001 for ; Thu, 29 Dec 2022 07:47:50 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 8CED71A09CD for ; Thu, 29 Dec 2022 12:47:50 +0000 (UTC) X-FDA: 80295320700.21.93C036E Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) by imf18.hostedemail.com (Postfix) with ESMTP id CE6081C0014 for ; Thu, 29 Dec 2022 12:47:48 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=PxKTeQb+; spf=pass (imf18.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.53 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672318068; a=rsa-sha256; cv=none; b=ZgmEAAiHO8fnucnpLgwBSJfpy84lIGqFyK0L6UyNf0n7UJzzdeDPn8C+VhffavoUvM9Lrv tZSWreQ0oK8ABoqW2EC0FgRm7/xew5fbO+IgES76G5iZo78g2F4lhpTXFvzBMXgHoLWGtH xsa9cT1oaAwfDWmnnIN//JtWwESGYns= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=PxKTeQb+; spf=pass (imf18.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.53 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672318068; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2HXheRu1dQbpoYyygoUpbH2Rv+D8A+p3lB+rWKexBOo=; b=XqFDgADfqkeybh/GJhPknsrPdy+h9Odn90lZDG91bQ1YcHpX3Q3iseCnGi7xASsMrAdU9Y 0tr3lUdqAzQcqYTcidNtGCg0VJZ4spCgBt/iAuuHH1cmLUgiDnbTNPcNL3jZVGW/nnaaEH cgbUTH3ce2tua1CiNT5McUv8U3OO1/8= Received: by mail-lf1-f53.google.com with SMTP id j17so17863135lfr.3 for ; Thu, 29 Dec 2022 04:47:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=2HXheRu1dQbpoYyygoUpbH2Rv+D8A+p3lB+rWKexBOo=; b=PxKTeQb+UavEDvyMVmHJf2HQSpqc2uu+sfVBpVpoZHd4sfN/POkyPykRSCVD1jkR6o fRdMtGHcXyH3D0/Uaa4WtTGArly1jYD3+hYd67Y8hR50EZ0NQ1J2ZgvWhDzupq0KWYTG fYAjTBFdrbA0wqQrzmTx6W3JhgkxY6y7R2rQHHYKjXPgZf6vwP0JV+yg6gVFpbTXXXjc ZcRIhKWO9oSR2KGhTt4eEp5R6glBZXydQrCWcOYdxWywLHAEqXUzHiqpbXzJSQU1JiAG ykmclOSpxQnMfovCswvcuMoYR8AZF3NjHPhsmUbyvKQxbtvG6ouupb4VFyNzMMlOmrv+ oEPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2HXheRu1dQbpoYyygoUpbH2Rv+D8A+p3lB+rWKexBOo=; b=myEQGEaIRyI+PCzfEWhJrI+n8qTn5cBr1pJynvUXQ7MViMzOAzvDw0kJMyT/rocfcB JHYDDFck36MT92yIHHrDqQQfRI5mQC6YoUMtVg4cr7FULulKT/Ohok6w9ZorMmClDJQm lWBRfDUvG9the+9Q2qJILxaJn38d/Pm22kJcCU3LOGo63HduGcbfvT1SxxcAW5HSwBxf lIwPG5DHox4P7KJgEEiQXIBdz55Vqq3uuTk+FS6tqkqJt5luH2nlw0dF40o0F/PoCUpC UGQJbkGn/dDDyG7ZgRXvjiHEm7VvCC+Fnl1jmniHwuNZgar80X3X6HjS8p5eM04SA5Tm nygQ== X-Gm-Message-State: AFqh2kpie2S4A3qLWK0E1RsHRNS488PMDBFoaUzi57dct+SV2eupwaoy 1fEc00Ek4ihqJ6jeGqqMGTM= X-Google-Smtp-Source: AMrXdXuIHJFWKzgwr5b7gyRTuZ7rfNwzf68SClV98VMvfHdknq9/nDZk0tV629b5vNuGr518o4+Q9A== X-Received: by 2002:ac2:5e2f:0:b0:4b5:5a15:8050 with SMTP id o15-20020ac25e2f000000b004b55a158050mr7808148lfg.32.1672318066963; Thu, 29 Dec 2022 04:47:46 -0800 (PST) Received: from pc636 (host-90-233-208-74.mobileonline.telia.com. [90.233.208.74]) by smtp.gmail.com with ESMTPSA id q13-20020a056512210d00b004b5732080d1sm3040948lfr.150.2022.12.29.04.47.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Dec 2022 04:47:46 -0800 (PST) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Thu, 29 Dec 2022 13:47:43 +0100 To: Andrew Morton Cc: Uladzislau Rezki , linux-mm@kvack.org, LKML , Baoquan He , Lorenzo Stoakes , Matthew Wilcox , Nicholas Piggin , Oleksiy Avramchenko , Christoph Hellwig Subject: Re: [PATCH v3 2/3] mm: vmalloc: Switch to find_unlink_vmap_area() in vm_unmap_ram() Message-ID: References: <20221222190022.134380-1-urezki@gmail.com> <20221222190022.134380-2-urezki@gmail.com> <20221228154707.432e8900855122712f98037c@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221228154707.432e8900855122712f98037c@linux-foundation.org> X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: CE6081C0014 X-Stat-Signature: 1exsbsgz33yactt9mcymx1mc7xseegbg X-HE-Tag: 1672318068-767579 X-HE-Meta: U2FsdGVkX1/Dp3B08/G4ktuE0z7+ssRcNpL+/OelFsmUyQ7UE/WvwuaIBLkFwCyVKxyvkROgMZq5tg/NAfZULOTRlEH/MO+ZDIVEEhyMrBbnfqfBe40MP1nAnv9VDqyNE4ajLHscOuEH1YNuUSMTfn13BSpPFjE59QFjB51JBzGdKPq7buyzvDnZLg16PgLwR8tTmQS6teo8ljpDY5uKhALTNEtgSRXTJQiDJ+1lwYxC7cPeKuLVlhTBAaEBf/33xkx3ARfNJkIaQe2Ml2whvAe/6wvgBieo2hAn+ScbUdzrjGRbmtcWq0drDpyujd60vpGuCKItIhhovKNoTLEQqAEXJOzdMdMOs3W4izzM6IO4Mxy/gocWpTjZeFxbAmphatuJ87EqabZuRXIqxjYGmtTQyf8Orh8EL+0XMiS8rJHKBjRAAj4z1Dp5jGPe9qL44XMoG3FlXIy7U/LhCXSo81z3i40JfTTvZ/FI4aL47cQJJX+JT5WThqqLzxVVZTTIc14UtHvG+862g3koHOuXL9vPeLciQd6ecl7kei8TvaDEm6493gVhFCWgQs8TIrsl85WSMq2rMxSKhoeFI7I22L0xeSDQKumwemkIGwaG2OPZMepHOzF6i7Z1vCb3RTW6Gx0mnEVUFLHE84xwBvVcAp5rBsIVpO+eOXIfWADIt0yZ+8VFZezJLZCXcZI7pB9zzKs37Jj9pT9M2DMqb0XsQe/OiVss1ERdqfcw2ZMKeYSxlVTE2P9gEMOsYQY6X28ofAc5x/EjQsZLjo+UwanPj9Yd1sEXrw2Ace9PYL0/qvXFf5+6DIZnNcyx9ON4dI6bb3iVJPALUth4yPzJA42Ypn68NE6xzL25j3kZHykRcDhxFRZ0eGqEMB1qpO9TBaDe7iclawybdwgE738pWphmdLMXHtv//s8vtYOh6C6Lj/0y2BK2gr32oLIYxsT7m5jJNB+nP/nLCqOmMolwqyb GdKHM3nz FvmN4OsYG+tFFzIKMK1MOKcZ50uygDe3PbICjVhznsFUG56rN1c+2odlGy1nHcMrvcy3E9+XC9hP6zDqKvy45qYDv3dVup/mMcb8e/DuwoSsoO8vDxHHSNDJ9c7rc1LaBfWdK X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Dec 28, 2022 at 03:47:07PM -0800, Andrew Morton wrote: > On Fri, 23 Dec 2022 17:41:48 +0100 Uladzislau Rezki wrote: > > > > Don't we also need to remove the manual unlink that was done > > > here previously? Actually it seems like that manual unlink is missing > > > after patch 1, creating a bisection hazard. So either add it there, > > > or just fold this patch into the previous one. > > > > > Right. In terms of bisection it is not so good. I think folding is the > > best. > > > > Andrew, could you please fold this patch into the: > > which patch ;) > Currently the next-20221226 contains three patches: [1] commit c83b70c3cc1ecf99897ca0ea6e44aa2125a61ccb Author: Uladzislau Rezki (Sony) Date: Wed Dec 21 18:44:54 2022 +0100 mm: vmalloc: replace BUG_ON() by WARN_ON_ONCE() [2] commit 8a85ea97b35924ee39d51e00ecb3f6d07f748a36 Author: Uladzislau Rezki (Sony) Date: Wed Dec 21 18:44:53 2022 +0100 mm: vmalloc: switch to find_unlink_vmap_area() in vm_unmap_ram() [3] commit a7c84c673c71cdfad20fe25e5d2051ed229859f7 Author: Uladzislau Rezki (Sony) Date: Wed Dec 21 18:44:52 2022 +0100 mm: vmalloc: avoid calling __find_vmap_area() twise in __vunmap() It would be good if you could fold [2] into [3] making it as one patch. The problem is that, if we leave it as it is, the bisection mechanism would consider [3] as a buggy patch, because it is not fully accomplished and depends on [2]. Is that OK for you, i mean to squash on your own? Or i just should resend one more time? Thank you in advance! -- Uladzislau Rezki