From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBAC2C3DA7D for ; Sat, 31 Dec 2022 09:17:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3D6448E0002; Sat, 31 Dec 2022 04:17:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3860A8E0001; Sat, 31 Dec 2022 04:17:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 24D6E8E0002; Sat, 31 Dec 2022 04:17:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 12CFF8E0001 for ; Sat, 31 Dec 2022 04:17:48 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id DA88680F41 for ; Sat, 31 Dec 2022 09:17:47 +0000 (UTC) X-FDA: 80302048974.29.2F98813 Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com [209.85.208.180]) by imf15.hostedemail.com (Postfix) with ESMTP id 294D5A0008 for ; Sat, 31 Dec 2022 09:17:45 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=IKCFduhp; spf=pass (imf15.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.180 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672478266; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vxCpl0YoEChLON3RwXmdSKop5AoTZZptT3NhkKbnI3c=; b=TeGfPh0x5rrBhLEWf6Ybobf5QFv7ilWZlozYeUrV/t1N5bI+iQkDfksgyIrBkmrfGLTzXu u+9JbIPVCDng8Y27RgMVqShBH9ZNa9LE1z4qs9YfI/l64S95Wi8Ke3AAIeEUdxWccOBRRc SDdt1EXqn6qoDrd+LPQqoPyzlK/oxkw= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=IKCFduhp; spf=pass (imf15.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.180 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672478266; a=rsa-sha256; cv=none; b=gxR7EJ9CpgrQSdzJ+LEFlC+W2MWYcA0lplHxS4gdgjYodKybgwTJTGryJ3LZWizTjRXdI5 7rOZMUbDSR9zOuM2GzrYNbkcKcpJG+z+24PjYs4KxUJkNLcv6FkdKmYQ8BLKQ43LhVVfoN A/UxAjzdM3qGjjmjveSONCbdrCWbxuw= Received: by mail-lj1-f180.google.com with SMTP id u12so20602215ljj.11 for ; Sat, 31 Dec 2022 01:17:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=vxCpl0YoEChLON3RwXmdSKop5AoTZZptT3NhkKbnI3c=; b=IKCFduhp6xQ+Em5nBIBlTGJXJuQ+tqLH3ePjakyfanO9YFUqCHn2PGO1YAlTBZv7GJ 7Q2hxvdRGIQAz+RGkcu2xdY9kPOHDasAMzKK0EyBW5y+8pepAen3XQ+qiAv6WSsIFtAE UXwBFzvx6k+f49BZr8LzCnc7lFPwpVDb/5ZOuR9Bv71eCXCIZViRZKGU89ud/2Aoqubr YzpV01vgtnf13UD2GiChB8AyTFzLcXGcfVid4nZc2EyW/2mrN/FdhxvZaXt8RQo6Od9b i7KV0elOg+dPglADhwUEfwas041wfcz4w1fOcyJwS21NAVSyWnM9747LqWkJG6Nf+TF9 GSeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vxCpl0YoEChLON3RwXmdSKop5AoTZZptT3NhkKbnI3c=; b=kMe7tkgiZWUg9NqQhjvDeEoyvrNMJ6/V3+syz3uGbWl9UimEDD1Nu/d+qE+moOOIhU 3HAUBducW1YhKyd6lZQ9JIUWivg0BrvPtzPF4OvjC39RLSxBpaWKBEbmWeFqYLLOVvSR bFrnMoQhWZsCklqsEzaxIejSnKHT89EYGSXjtI5n8+mNzJ0evFlrFO85P6mtXdCmCDMm QwdU3914P1B9Q11dv6Ag5vvXZSFGPxyh7OTtTlUZ37T1PyTMiyHGR3NdT+SYgyOS58uu t4z4h97N8lA7gD24Qjwcyb0jajZwK3he5cBnM7crww7LeaL5AuP9P4xJVACyU1HCaWo4 kfYg== X-Gm-Message-State: AFqh2kqicr48Dt3k6jwfsdidNL1PTWjHJDcbOwdq0FDVwN1PfZMUMNOD CMFajLh0O/MSeiifsUAB7wc= X-Google-Smtp-Source: AMrXdXvgB7luwJVYxUdOyfTRh2AbrHR7D0SzwZVboOhFm3jHh2F5jZ22Tkj6hWKLEmumIO5H9d/zhQ== X-Received: by 2002:a2e:bf2a:0:b0:27f:a95e:94ba with SMTP id c42-20020a2ebf2a000000b0027fa95e94bamr10419415ljr.33.1672478264293; Sat, 31 Dec 2022 01:17:44 -0800 (PST) Received: from pc636 (host-217-213-136-176.mobileonline.telia.com. [217.213.136.176]) by smtp.gmail.com with ESMTPSA id x12-20020a2e880c000000b0027fe97a7f40sm99286ljh.61.2022.12.31.01.17.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 31 Dec 2022 01:17:43 -0800 (PST) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Sat, 31 Dec 2022 10:17:40 +0100 To: Andrew Morton Cc: Uladzislau Rezki , linux-mm@kvack.org, LKML , Baoquan He , Lorenzo Stoakes , Matthew Wilcox , Nicholas Piggin , Oleksiy Avramchenko , Christoph Hellwig Subject: Re: [PATCH v3 2/3] mm: vmalloc: Switch to find_unlink_vmap_area() in vm_unmap_ram() Message-ID: References: <20221222190022.134380-1-urezki@gmail.com> <20221222190022.134380-2-urezki@gmail.com> <20221228154707.432e8900855122712f98037c@linux-foundation.org> <20221229151706.da16baab4cb6c2bc30e3061a@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221229151706.da16baab4cb6c2bc30e3061a@linux-foundation.org> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 294D5A0008 X-Stat-Signature: 6fs3hu7iyzfmejw5qmphmkqpuzqcihor X-Rspam-User: X-HE-Tag: 1672478265-269069 X-HE-Meta: U2FsdGVkX1/X1JswRKYLVRq7i2t+n0YLPtvvvWvXACdUorsq/DBdOEdSkotjtBJ28xAhu9VeKcONHYn5NtQSwXHcHCsd5PsOMvD7zU+iQciR7XLFhUefRnKQGFKIaNx3RKdZqec8RKRi5Ky3T+ReT2pGskbjA7b6+DHnw7y0qKAaf1fW5vzk8WDGQPydzyd4KP5Hifbe/qkaQZYYgVRNEYLaDI3f0767ZQVa6dJEJWF92DocUNGAZnpLItfV31Tn/UFhYEDpAwGaKijocShH2tSogfyRdB85euSyHabTCATAUNHoJ4lTdUFvLa7ej29XadbbyYk1VCP16mXg98glIVlmSZdKU3xHJ3zwDKPxzfsSkJ3o00zUXLau5DMrvTaKjwEIa/EnZlgYfIeJniR20+Lw1cXMbMEvcFDE4FbJpy4qbulWFxOixdavcQ5Cy6dUM6tIh56qRD7iiWvxBs9k4doLH3y7+N7pVkz8YwYPydy1ZRBjo7AfFNTZ0QtO61FoqdK1DpHY2LrCDr8XhFrEPnq/746MFNld+CRWkcaR0AbvsqZDkiqQxmijJeko9GjVUoFk31nokK1gYwu5Lve616tXz9gys81bclUEOfMW3pYiy6WKRV81VmejD4tij1QbfQEWX7USCNs+TztcEjCIZ9ZEN5dG5TrG+ZnTp0oj8N/TQ7VHeRvN/OAoIe1CpqKX9Un/VO6X6a8hGJyN6D2kDfTK0LnBnxmteCEHd2OYV9D9aZABduyoZlwVgRWKTFVFEZXUuZrNmLZCOIU3uky7MdJjdp3NMbs4GgDugfQLqnXDpCl57IRMF21yArlzlRuKYd490xp1XxLxeTcmfg8NWPYw/kEcw+6Rl70ToKtUyw9MHOYbRm6/1uiDGVj6zoMkrAH9oo4shVdNKZRSAQO+ZqVpTGYFrH5OdgtNOgOgxEvcj+Y1tbleTQ90WHNNZgPNG1PEK92KE9jIRKr3D20 CsPQ8/TN Nfb25rAMHAGjD9AWi5a78YW/3VLj7lDzLZPD+0G6fRKeyUYEQGBiou9DqV7vhrzsV5wwB6S/ZQNZOHcTM+up+fpQwGfEGaOuhHE9KeOgBr61KWjmWhSM/4TBOWqpjK7t19YKi X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Dec 29, 2022 at 03:17:06PM -0800, Andrew Morton wrote: > On Thu, 29 Dec 2022 13:47:43 +0100 Uladzislau Rezki wrote: > > > [2] > > commit 8a85ea97b35924ee39d51e00ecb3f6d07f748a36 > > Author: Uladzislau Rezki (Sony) > > Date: Wed Dec 21 18:44:53 2022 +0100 > > > > mm: vmalloc: switch to find_unlink_vmap_area() in vm_unmap_ram() > > > > [3] > > commit a7c84c673c71cdfad20fe25e5d2051ed229859f7 > > Author: Uladzislau Rezki (Sony) > > Date: Wed Dec 21 18:44:52 2022 +0100 > > > > mm: vmalloc: avoid calling __find_vmap_area() twise in __vunmap() > > > > > > It would be good if you could fold [2] into [3] making it as one > > patch. The problem is that, if we leave it as it is, the bisection > > mechanism would consider [3] as a buggy patch, because it is not > > fully accomplished and depends on [2]. > > > > Is that OK for you, i mean to squash on your own? > > I did that. I updated the "mm: vmalloc: avoid calling > __find_vmap_area() twice in __vunmap()" accordingly, thanks. > At least bisection part will not detect anything wrong now. Happy New Year and thank you! -- Uladzislau Rezki